* Re: [PATCH] ASoC: imx-card: Add WM8524 support
[not found] <20250619062413.3946142-1-chancel.liu@nxp.com>
@ 2025-06-19 20:53 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-06-19 20:53 UTC (permalink / raw)
To: Chancel Liu, shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka,
lgirdwood, broonie, perex, tiwai, shawnguo, linux-kernel,
linuxppc-dev, linux-sound, imx, linux-arm-kernel
Cc: llvm, oe-kbuild-all
Hi Chancel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on linus/master v6.16-rc2 next-20250619]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chancel-Liu/ASoC-imx-card-Add-WM8524-support/20250619-142646
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20250619062413.3946142-1-chancel.liu%40nxp.com
patch subject: [PATCH] ASoC: imx-card: Add WM8524 support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250620/202506200415.ATjQ5KCu-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250620/202506200415.ATjQ5KCu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506200415.ATjQ5KCu-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/soc/fsl/imx-card.c:884:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
884 | default:
| ^
sound/soc/fsl/imx-card.c:884:3: note: insert 'break;' to avoid fall-through
884 | default:
| ^
| break;
1 warning generated.
vim +884 sound/soc/fsl/imx-card.c
aa736700f42fa0 Shengjiu Wang 2021-05-17 747
aa736700f42fa0 Shengjiu Wang 2021-05-17 748 static int imx_card_probe(struct platform_device *pdev)
aa736700f42fa0 Shengjiu Wang 2021-05-17 749 {
aa736700f42fa0 Shengjiu Wang 2021-05-17 750 struct snd_soc_dai_link *link_be = NULL, *link;
aa736700f42fa0 Shengjiu Wang 2021-05-17 751 struct imx_card_plat_data *plat_data;
aa736700f42fa0 Shengjiu Wang 2021-05-17 752 struct imx_card_data *data;
aa736700f42fa0 Shengjiu Wang 2021-05-17 753 int ret, i;
aa736700f42fa0 Shengjiu Wang 2021-05-17 754
aa736700f42fa0 Shengjiu Wang 2021-05-17 755 data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
aa736700f42fa0 Shengjiu Wang 2021-05-17 756 if (!data)
aa736700f42fa0 Shengjiu Wang 2021-05-17 757 return -ENOMEM;
aa736700f42fa0 Shengjiu Wang 2021-05-17 758
aa736700f42fa0 Shengjiu Wang 2021-05-17 759 plat_data = devm_kzalloc(&pdev->dev, sizeof(*plat_data), GFP_KERNEL);
aa736700f42fa0 Shengjiu Wang 2021-05-17 760 if (!plat_data)
aa736700f42fa0 Shengjiu Wang 2021-05-17 761 return -ENOMEM;
aa736700f42fa0 Shengjiu Wang 2021-05-17 762
aa736700f42fa0 Shengjiu Wang 2021-05-17 763 data->plat_data = plat_data;
aa736700f42fa0 Shengjiu Wang 2021-05-17 764 data->card.dev = &pdev->dev;
47d7d3fd72afc7 Hui Wang 2024-10-02 765 data->card.owner = THIS_MODULE;
aa736700f42fa0 Shengjiu Wang 2021-05-17 766
aa736700f42fa0 Shengjiu Wang 2021-05-17 767 dev_set_drvdata(&pdev->dev, &data->card);
aa736700f42fa0 Shengjiu Wang 2021-05-17 768 snd_soc_card_set_drvdata(&data->card, data);
aa736700f42fa0 Shengjiu Wang 2021-05-17 769 ret = imx_card_parse_of(data);
aa736700f42fa0 Shengjiu Wang 2021-05-17 770 if (ret)
aa736700f42fa0 Shengjiu Wang 2021-05-17 771 return ret;
aa736700f42fa0 Shengjiu Wang 2021-05-17 772
aa736700f42fa0 Shengjiu Wang 2021-05-17 773 data->num_dapm_routes = plat_data->num_codecs + 1;
aa736700f42fa0 Shengjiu Wang 2021-05-17 774 data->dapm_routes = devm_kcalloc(&pdev->dev, data->num_dapm_routes,
aa736700f42fa0 Shengjiu Wang 2021-05-17 775 sizeof(struct snd_soc_dapm_route),
aa736700f42fa0 Shengjiu Wang 2021-05-17 776 GFP_KERNEL);
aa736700f42fa0 Shengjiu Wang 2021-05-17 777 if (!data->dapm_routes)
aa736700f42fa0 Shengjiu Wang 2021-05-17 778 return -ENOMEM;
aa736700f42fa0 Shengjiu Wang 2021-05-17 779
aa736700f42fa0 Shengjiu Wang 2021-05-17 780 /* configure the dapm routes */
aa736700f42fa0 Shengjiu Wang 2021-05-17 781 switch (plat_data->type) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 782 case CODEC_AK4458:
aa736700f42fa0 Shengjiu Wang 2021-05-17 783 case CODEC_AK4497:
aa736700f42fa0 Shengjiu Wang 2021-05-17 784 if (plat_data->num_codecs == 1) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 785 data->dapm_routes[0].sink = "Playback";
aa736700f42fa0 Shengjiu Wang 2021-05-17 786 data->dapm_routes[0].source = "CPU-Playback";
aa736700f42fa0 Shengjiu Wang 2021-05-17 787 i = 1;
aa736700f42fa0 Shengjiu Wang 2021-05-17 788 } else {
aa736700f42fa0 Shengjiu Wang 2021-05-17 789 for (i = 0; i < plat_data->num_codecs; i++) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 790 data->dapm_routes[i].sink =
aa736700f42fa0 Shengjiu Wang 2021-05-17 791 devm_kasprintf(&pdev->dev, GFP_KERNEL, "%d %s",
aa736700f42fa0 Shengjiu Wang 2021-05-17 792 i + 1, "Playback");
93d34608fd162f Henry Martin 2025-04-01 793 if (!data->dapm_routes[i].sink)
93d34608fd162f Henry Martin 2025-04-01 794 return -ENOMEM;
aa736700f42fa0 Shengjiu Wang 2021-05-17 795 data->dapm_routes[i].source = "CPU-Playback";
aa736700f42fa0 Shengjiu Wang 2021-05-17 796 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 797 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 798 data->dapm_routes[i].sink = "CPU-Playback";
aa736700f42fa0 Shengjiu Wang 2021-05-17 799 data->dapm_routes[i].source = "ASRC-Playback";
aa736700f42fa0 Shengjiu Wang 2021-05-17 800 break;
aa736700f42fa0 Shengjiu Wang 2021-05-17 801 case CODEC_AK5558:
aa736700f42fa0 Shengjiu Wang 2021-05-17 802 case CODEC_AK5552:
aa736700f42fa0 Shengjiu Wang 2021-05-17 803 if (plat_data->num_codecs == 1) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 804 data->dapm_routes[0].sink = "CPU-Capture";
aa736700f42fa0 Shengjiu Wang 2021-05-17 805 data->dapm_routes[0].source = "Capture";
aa736700f42fa0 Shengjiu Wang 2021-05-17 806 i = 1;
aa736700f42fa0 Shengjiu Wang 2021-05-17 807 } else {
aa736700f42fa0 Shengjiu Wang 2021-05-17 808 for (i = 0; i < plat_data->num_codecs; i++) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 809 data->dapm_routes[i].source =
aa736700f42fa0 Shengjiu Wang 2021-05-17 810 devm_kasprintf(&pdev->dev, GFP_KERNEL, "%d %s",
aa736700f42fa0 Shengjiu Wang 2021-05-17 811 i + 1, "Capture");
93d34608fd162f Henry Martin 2025-04-01 812 if (!data->dapm_routes[i].source)
93d34608fd162f Henry Martin 2025-04-01 813 return -ENOMEM;
aa736700f42fa0 Shengjiu Wang 2021-05-17 814 data->dapm_routes[i].sink = "CPU-Capture";
aa736700f42fa0 Shengjiu Wang 2021-05-17 815 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 816 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 817 data->dapm_routes[i].sink = "ASRC-Capture";
aa736700f42fa0 Shengjiu Wang 2021-05-17 818 data->dapm_routes[i].source = "CPU-Capture";
aa736700f42fa0 Shengjiu Wang 2021-05-17 819 break;
b39eec95b84d5d Chancel Liu 2024-10-09 820 case CODEC_CS42888:
b39eec95b84d5d Chancel Liu 2024-10-09 821 data->dapm_routes[0].sink = "Playback";
b39eec95b84d5d Chancel Liu 2024-10-09 822 data->dapm_routes[0].source = "CPU-Playback";
b39eec95b84d5d Chancel Liu 2024-10-09 823 data->dapm_routes[1].sink = "CPU-Capture";
b39eec95b84d5d Chancel Liu 2024-10-09 824 data->dapm_routes[1].source = "Capture";
b39eec95b84d5d Chancel Liu 2024-10-09 825 break;
52377234f3ed64 Chancel Liu 2025-06-19 826 case CODEC_WM8524:
52377234f3ed64 Chancel Liu 2025-06-19 827 data->dapm_routes[0].sink = "Playback";
52377234f3ed64 Chancel Liu 2025-06-19 828 data->dapm_routes[0].source = "CPU-Playback";
52377234f3ed64 Chancel Liu 2025-06-19 829 break;
aa736700f42fa0 Shengjiu Wang 2021-05-17 830 default:
aa736700f42fa0 Shengjiu Wang 2021-05-17 831 break;
aa736700f42fa0 Shengjiu Wang 2021-05-17 832 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 833
aa736700f42fa0 Shengjiu Wang 2021-05-17 834 /* default platform data for akcodecs */
aa736700f42fa0 Shengjiu Wang 2021-05-17 835 if (codec_is_akcodec(plat_data->type)) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 836 plat_data->support_rates = akcodec_rates;
aa736700f42fa0 Shengjiu Wang 2021-05-17 837 plat_data->num_rates = ARRAY_SIZE(akcodec_rates);
aa736700f42fa0 Shengjiu Wang 2021-05-17 838 plat_data->support_tdm_rates = akcodec_tdm_rates;
aa736700f42fa0 Shengjiu Wang 2021-05-17 839 plat_data->num_tdm_rates = ARRAY_SIZE(akcodec_tdm_rates);
aa736700f42fa0 Shengjiu Wang 2021-05-17 840
aa736700f42fa0 Shengjiu Wang 2021-05-17 841 switch (plat_data->type) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 842 case CODEC_AK4458:
aa736700f42fa0 Shengjiu Wang 2021-05-17 843 plat_data->fs_mul = ak4458_fs_mul;
aa736700f42fa0 Shengjiu Wang 2021-05-17 844 plat_data->num_fs_mul = ARRAY_SIZE(ak4458_fs_mul);
aa736700f42fa0 Shengjiu Wang 2021-05-17 845 plat_data->tdm_fs_mul = ak4458_tdm_fs_mul;
aa736700f42fa0 Shengjiu Wang 2021-05-17 846 plat_data->num_tdm_fs_mul = ARRAY_SIZE(ak4458_tdm_fs_mul);
aa736700f42fa0 Shengjiu Wang 2021-05-17 847 plat_data->support_channels = ak4458_channels;
aa736700f42fa0 Shengjiu Wang 2021-05-17 848 plat_data->num_channels = ARRAY_SIZE(ak4458_channels);
aa736700f42fa0 Shengjiu Wang 2021-05-17 849 plat_data->support_tdm_channels = ak4458_tdm_channels;
aa736700f42fa0 Shengjiu Wang 2021-05-17 850 plat_data->num_tdm_channels = ARRAY_SIZE(ak4458_tdm_channels);
aa736700f42fa0 Shengjiu Wang 2021-05-17 851 break;
aa736700f42fa0 Shengjiu Wang 2021-05-17 852 case CODEC_AK4497:
aa736700f42fa0 Shengjiu Wang 2021-05-17 853 plat_data->fs_mul = ak4497_fs_mul;
aa736700f42fa0 Shengjiu Wang 2021-05-17 854 plat_data->num_fs_mul = ARRAY_SIZE(ak4497_fs_mul);
aa736700f42fa0 Shengjiu Wang 2021-05-17 855 plat_data->support_channels = ak4458_channels;
aa736700f42fa0 Shengjiu Wang 2021-05-17 856 plat_data->num_channels = ARRAY_SIZE(ak4458_channels);
aa736700f42fa0 Shengjiu Wang 2021-05-17 857 break;
aa736700f42fa0 Shengjiu Wang 2021-05-17 858 case CODEC_AK5558:
aa736700f42fa0 Shengjiu Wang 2021-05-17 859 case CODEC_AK5552:
aa736700f42fa0 Shengjiu Wang 2021-05-17 860 plat_data->fs_mul = ak5558_fs_mul;
aa736700f42fa0 Shengjiu Wang 2021-05-17 861 plat_data->num_fs_mul = ARRAY_SIZE(ak5558_fs_mul);
aa736700f42fa0 Shengjiu Wang 2021-05-17 862 plat_data->tdm_fs_mul = ak5558_tdm_fs_mul;
aa736700f42fa0 Shengjiu Wang 2021-05-17 863 plat_data->num_tdm_fs_mul = ARRAY_SIZE(ak5558_tdm_fs_mul);
aa736700f42fa0 Shengjiu Wang 2021-05-17 864 plat_data->support_channels = ak5558_channels;
aa736700f42fa0 Shengjiu Wang 2021-05-17 865 plat_data->num_channels = ARRAY_SIZE(ak5558_channels);
aa736700f42fa0 Shengjiu Wang 2021-05-17 866 plat_data->support_tdm_channels = ak5558_tdm_channels;
aa736700f42fa0 Shengjiu Wang 2021-05-17 867 plat_data->num_tdm_channels = ARRAY_SIZE(ak5558_tdm_channels);
aa736700f42fa0 Shengjiu Wang 2021-05-17 868 break;
b39eec95b84d5d Chancel Liu 2024-10-09 869 case CODEC_CS42888:
b39eec95b84d5d Chancel Liu 2024-10-09 870 plat_data->fs_mul = cs42888_fs_mul;
b39eec95b84d5d Chancel Liu 2024-10-09 871 plat_data->num_fs_mul = ARRAY_SIZE(cs42888_fs_mul);
b39eec95b84d5d Chancel Liu 2024-10-09 872 plat_data->tdm_fs_mul = cs42888_tdm_fs_mul;
b39eec95b84d5d Chancel Liu 2024-10-09 873 plat_data->num_tdm_fs_mul = ARRAY_SIZE(cs42888_tdm_fs_mul);
b39eec95b84d5d Chancel Liu 2024-10-09 874 plat_data->support_channels = cs42888_channels;
b39eec95b84d5d Chancel Liu 2024-10-09 875 plat_data->num_channels = ARRAY_SIZE(cs42888_channels);
b39eec95b84d5d Chancel Liu 2024-10-09 876 plat_data->support_tdm_channels = cs42888_tdm_channels;
b39eec95b84d5d Chancel Liu 2024-10-09 877 plat_data->num_tdm_channels = ARRAY_SIZE(cs42888_tdm_channels);
b39eec95b84d5d Chancel Liu 2024-10-09 878 break;
52377234f3ed64 Chancel Liu 2025-06-19 879 case CODEC_WM8524:
52377234f3ed64 Chancel Liu 2025-06-19 880 plat_data->fs_mul = wm8524_fs_mul;
52377234f3ed64 Chancel Liu 2025-06-19 881 plat_data->num_fs_mul = ARRAY_SIZE(wm8524_fs_mul);
52377234f3ed64 Chancel Liu 2025-06-19 882 plat_data->support_channels = wm8524_channels;
52377234f3ed64 Chancel Liu 2025-06-19 883 plat_data->num_channels = ARRAY_SIZE(wm8524_channels);
aa736700f42fa0 Shengjiu Wang 2021-05-17 @884 default:
aa736700f42fa0 Shengjiu Wang 2021-05-17 885 break;
aa736700f42fa0 Shengjiu Wang 2021-05-17 886 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 887 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 888
aa736700f42fa0 Shengjiu Wang 2021-05-17 889 /* with asrc as front end */
aa736700f42fa0 Shengjiu Wang 2021-05-17 890 if (data->card.num_links == 3) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 891 data->card.dapm_routes = data->dapm_routes;
aa736700f42fa0 Shengjiu Wang 2021-05-17 892 data->card.num_dapm_routes = data->num_dapm_routes;
aa736700f42fa0 Shengjiu Wang 2021-05-17 893 for_each_card_prelinks(&data->card, i, link) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 894 if (link->no_pcm == 1)
aa736700f42fa0 Shengjiu Wang 2021-05-17 895 link_be = link;
aa736700f42fa0 Shengjiu Wang 2021-05-17 896 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 897 for_each_card_prelinks(&data->card, i, link) {
aa736700f42fa0 Shengjiu Wang 2021-05-17 898 if (link->dynamic == 1 && link_be) {
efa527f984a110 Kuninori Morimoto 2024-10-20 899 link->playback_only = link_be->playback_only;
efa527f984a110 Kuninori Morimoto 2024-10-20 900 link->capture_only = link_be->capture_only;
aa736700f42fa0 Shengjiu Wang 2021-05-17 901 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 902 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 903 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 904
aa736700f42fa0 Shengjiu Wang 2021-05-17 905 ret = devm_snd_soc_register_card(&pdev->dev, &data->card);
2e6f557ca35aa3 Kuninori Morimoto 2021-12-14 906 if (ret)
2e6f557ca35aa3 Kuninori Morimoto 2021-12-14 907 return dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n");
aa736700f42fa0 Shengjiu Wang 2021-05-17 908
aa736700f42fa0 Shengjiu Wang 2021-05-17 909 return 0;
aa736700f42fa0 Shengjiu Wang 2021-05-17 910 }
aa736700f42fa0 Shengjiu Wang 2021-05-17 911
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread