[ulfh-mmc:next 88/90] drivers/mmc/host/rtsx_usb_sdmmc.c:1042:2: warning: unannotated fall-through between switch labels

[ulfh-mmc:next 88/90] drivers/mmc/host/rtsx_usb_sdmmc.c:1042:2: warning: unannotated fall-through between switch labels

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
head:   f5c755ef810009b85350884c483705bd04365370
commit: 2c3809bd6f65cdd8c13853af1ab2a80ddf80528d [88/90] mmc: rtsx_usb_sdmmc: Add 74 clocks in poweron flow
config: i386-buildonly-randconfig-003-20250620 (https://download.01.org/0day-ci/archive/20250620/202506200902.0b5Z1InC-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250620/202506200902.0b5Z1InC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506200902.0b5Z1InC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mmc/host/rtsx_usb_sdmmc.c:1042:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    1042 |         case MMC_POWER_UNDEFINED:
         |         ^
   drivers/mmc/host/rtsx_usb_sdmmc.c:1042:2: note: insert 'break;' to avoid fall-through
    1042 |         case MMC_POWER_UNDEFINED:
         |         ^
         |         break; 
   1 warning generated.


vim +1042 drivers/mmc/host/rtsx_usb_sdmmc.c

c7f6558d84afe6 Roger Tseng 2014-04-11  1012  
ddf60f1cf1d2c0 Ulf Hansson 2025-06-10  1013  static void sd_set_power_mode(struct rtsx_usb_sdmmc *host,
c7f6558d84afe6 Roger Tseng 2014-04-11  1014  		unsigned char power_mode)
c7f6558d84afe6 Roger Tseng 2014-04-11  1015  {
c7f6558d84afe6 Roger Tseng 2014-04-11  1016  	int err;
2c3809bd6f65cd Ricky Wu    2025-06-16  1017  	struct rtsx_ucr *ucr = host->ucr;
c7f6558d84afe6 Roger Tseng 2014-04-11  1018  
c7f6558d84afe6 Roger Tseng 2014-04-11  1019  	if (power_mode == host->power_mode)
ddf60f1cf1d2c0 Ulf Hansson 2025-06-10  1020  		return;
c7f6558d84afe6 Roger Tseng 2014-04-11  1021  
4a4b1d2837322e Ulf Hansson 2025-06-10  1022  	switch (power_mode) {
4a4b1d2837322e Ulf Hansson 2025-06-10  1023  	case MMC_POWER_OFF:
c7f6558d84afe6 Roger Tseng 2014-04-11  1024  		err = sd_power_off(host);
e7c56431e1996f Ulf Hansson 2025-06-10  1025  		if (err)
e7c56431e1996f Ulf Hansson 2025-06-10  1026  			dev_dbg(sdmmc_dev(host), "power-off (err = %d)\n", err);
f275179f7bdcf0 Ulf Hansson 2018-05-31  1027  		pm_runtime_put_noidle(sdmmc_dev(host));
4a4b1d2837322e Ulf Hansson 2025-06-10  1028  		break;
4a4b1d2837322e Ulf Hansson 2025-06-10  1029  
4a4b1d2837322e Ulf Hansson 2025-06-10  1030  	case MMC_POWER_UP:
f275179f7bdcf0 Ulf Hansson 2018-05-31  1031  		pm_runtime_get_noresume(sdmmc_dev(host));
c7f6558d84afe6 Roger Tseng 2014-04-11  1032  		err = sd_power_on(host);
e7c56431e1996f Ulf Hansson 2025-06-10  1033  		if (err)
e7c56431e1996f Ulf Hansson 2025-06-10  1034  			dev_dbg(sdmmc_dev(host), "power-on (err = %d)\n", err);
2c3809bd6f65cd Ricky Wu    2025-06-16  1035  		/* issue the clock signals to card at least 74 clocks */
2c3809bd6f65cd Ricky Wu    2025-06-16  1036  		rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, SD_CLK_TOGGLE_EN);
4a4b1d2837322e Ulf Hansson 2025-06-10  1037  		break;
4a4b1d2837322e Ulf Hansson 2025-06-10  1038  
4a4b1d2837322e Ulf Hansson 2025-06-10  1039  	case MMC_POWER_ON:
2c3809bd6f65cd Ricky Wu    2025-06-16  1040  		/* stop to send the clock signals */
2c3809bd6f65cd Ricky Wu    2025-06-16  1041  		rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, 0x00);
4a4b1d2837322e Ulf Hansson 2025-06-10 @1042  	case MMC_POWER_UNDEFINED:
4a4b1d2837322e Ulf Hansson 2025-06-10  1043  		break;
4a4b1d2837322e Ulf Hansson 2025-06-10  1044  
4a4b1d2837322e Ulf Hansson 2025-06-10  1045  	default:
4a4b1d2837322e Ulf Hansson 2025-06-10  1046  		break;
c7f6558d84afe6 Roger Tseng 2014-04-11  1047  	}
c7f6558d84afe6 Roger Tseng 2014-04-11  1048  
c7f6558d84afe6 Roger Tseng 2014-04-11  1049  	host->power_mode = power_mode;
c7f6558d84afe6 Roger Tseng 2014-04-11  1050  }
c7f6558d84afe6 Roger Tseng 2014-04-11  1051  

:::::: The code at line 1042 was first introduced by commit
:::::: 4a4b1d2837322e9cc46c93a2e88ec40977a56afc mmc: rtsx_usb_sdmmc: Re-work the code in sd_set_power_mode()

:::::: TO: Ulf Hansson <ulf.hansson@linaro.org>
:::::: CC: Ulf Hansson <ulf.hansson@linaro.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki