* Re: [PATCH 3/3] nfsd: split nfsd_mutex into one mutex per net-namespace.
[not found] <20250618213347.425503-4-neil@brown.name>
@ 2025-06-19 12:33 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-06-19 12:33 UTC (permalink / raw)
To: NeilBrown, Chuck Lever, Jeff Layton
Cc: llvm, oe-kbuild-all, linux-nfs, Olga Kornievskaia, Dai Ngo,
Tom Talpey, Li Lingfeng
Hi NeilBrown,
kernel test robot noticed the following build warnings:
[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on trondmy-nfs/linux-next linus/master v6.16-rc2 next-20250619]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/NeilBrown/nfsd-provide-proper-locking-for-all-write_-function/20250619-053514
base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link: https://lore.kernel.org/r/20250618213347.425503-4-neil%40brown.name
patch subject: [PATCH 3/3] nfsd: split nfsd_mutex into one mutex per net-namespace.
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20250619/202506192052.L9tj28RJ-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506192052.L9tj28RJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506192052.L9tj28RJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/nfsd/nfsctl.c:1891:14: warning: variable 'nn' is uninitialized when used here [-Wuninitialized]
1891 | mutex_lock(&nn->nfsd_info.mutex);
| ^~
fs/nfsd/nfsctl.c:1877:21: note: initialize the variable 'nn' to silence this warning
1877 | struct nfsd_net *nn;
| ^
| = NULL
1 warning generated.
vim +/nn +1891 fs/nfsd/nfsctl.c
1867
1868 /**
1869 * nfsd_nl_version_get_doit - get the enabled status for all supported nfs versions
1870 * @skb: reply buffer
1871 * @info: netlink metadata and command arguments
1872 *
1873 * Return 0 on success or a negative errno.
1874 */
1875 int nfsd_nl_version_get_doit(struct sk_buff *skb, struct genl_info *info)
1876 {
1877 struct nfsd_net *nn;
1878 int i, err;
1879 void *hdr;
1880
1881 skb = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL);
1882 if (!skb)
1883 return -ENOMEM;
1884
1885 hdr = genlmsg_iput(skb, info);
1886 if (!hdr) {
1887 err = -EMSGSIZE;
1888 goto err_free_msg;
1889 }
1890
> 1891 mutex_lock(&nn->nfsd_info.mutex);
1892 nn = net_generic(genl_info_net(info), nfsd_net_id);
1893
1894 for (i = 2; i <= 4; i++) {
1895 int j;
1896
1897 for (j = 0; j <= NFSD_SUPPORTED_MINOR_VERSION; j++) {
1898 struct nlattr *attr;
1899
1900 /* Don't record any versions the kernel doesn't have
1901 * compiled in
1902 */
1903 if (!nfsd_support_version(i))
1904 continue;
1905
1906 /* NFSv{2,3} does not support minor numbers */
1907 if (i < 4 && j)
1908 continue;
1909
1910 attr = nla_nest_start(skb,
1911 NFSD_A_SERVER_PROTO_VERSION);
1912 if (!attr) {
1913 err = -EINVAL;
1914 goto err_nfsd_unlock;
1915 }
1916
1917 if (nla_put_u32(skb, NFSD_A_VERSION_MAJOR, i) ||
1918 nla_put_u32(skb, NFSD_A_VERSION_MINOR, j)) {
1919 err = -EINVAL;
1920 goto err_nfsd_unlock;
1921 }
1922
1923 /* Set the enabled flag if the version is enabled */
1924 if (nfsd_vers(nn, i, NFSD_TEST) &&
1925 (i < 4 || nfsd_minorversion(nn, j, NFSD_TEST)) &&
1926 nla_put_flag(skb, NFSD_A_VERSION_ENABLED)) {
1927 err = -EINVAL;
1928 goto err_nfsd_unlock;
1929 }
1930
1931 nla_nest_end(skb, attr);
1932 }
1933 }
1934
1935 mutex_unlock(&nn->nfsd_info.mutex);
1936 genlmsg_end(skb, hdr);
1937
1938 return genlmsg_reply(skb, info);
1939
1940 err_nfsd_unlock:
1941 mutex_unlock(&nn->nfsd_info.mutex);
1942 err_free_msg:
1943 nlmsg_free(skb);
1944
1945 return err;
1946 }
1947
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] nfsd: split nfsd_mutex into one mutex per net-namespace.
[not found] <20250620233802.1453016-4-neil@brown.name>
@ 2025-06-21 13:02 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-06-21 13:02 UTC (permalink / raw)
To: NeilBrown, Chuck Lever, Jeff Layton
Cc: llvm, oe-kbuild-all, linux-nfs, Olga Kornievskaia, Dai Ngo,
Tom Talpey, Li Lingfeng
Hi NeilBrown,
kernel test robot noticed the following build errors:
[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on trondmy-nfs/linux-next linus/master v6.16-rc2 next-20250620]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/NeilBrown/nfsd-provide-proper-locking-for-all-write_-function/20250621-073955
base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link: https://lore.kernel.org/r/20250620233802.1453016-4-neil%40brown.name
patch subject: [PATCH 3/3] nfsd: split nfsd_mutex into one mutex per net-namespace.
config: i386-buildonly-randconfig-003-20250621 (https://download.01.org/0day-ci/archive/20250621/202506212005.LpUsPRa3-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250621/202506212005.LpUsPRa3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506212005.LpUsPRa3-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/nfsd/nfsctl.c:1699:3: error: cannot jump from this goto statement to its label
1699 | goto err_free_msg;
| ^
fs/nfsd/nfsctl.c:1702:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
1702 | guard(mutex)(&nn->config_mutex);
| ^
include/linux/cleanup.h:338:15: note: expanded from macro 'guard'
338 | CLASS(_name, __UNIQUE_ID(guard))
| ^
include/linux/compiler.h:166:29: note: expanded from macro '__UNIQUE_ID'
166 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
| ^
include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
84 | #define __PASTE(a,b) ___PASTE(a,b)
| ^
include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
83 | #define ___PASTE(a,b) a##b
| ^
<scratch space>:45:1: note: expanded from here
45 | __UNIQUE_ID_guard1097
| ^
fs/nfsd/nfsctl.c:1825:3: error: cannot jump from this goto statement to its label
1825 | goto err_free_msg;
| ^
fs/nfsd/nfsctl.c:1829:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
1829 | guard(mutex)(&nn->config_mutex);
| ^
include/linux/cleanup.h:338:15: note: expanded from macro 'guard'
338 | CLASS(_name, __UNIQUE_ID(guard))
| ^
include/linux/compiler.h:166:29: note: expanded from macro '__UNIQUE_ID'
166 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
| ^
include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
84 | #define __PASTE(a,b) ___PASTE(a,b)
| ^
include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
83 | #define ___PASTE(a,b) a##b
| ^
<scratch space>:68:1: note: expanded from here
68 | __UNIQUE_ID_guard1099
| ^
fs/nfsd/nfsctl.c:2044:3: error: cannot jump from this goto statement to its label
2044 | goto err_free_msg;
| ^
fs/nfsd/nfsctl.c:2048:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
2048 | guard(mutex)(&nn->config_mutex);
| ^
include/linux/cleanup.h:338:15: note: expanded from macro 'guard'
338 | CLASS(_name, __UNIQUE_ID(guard))
| ^
include/linux/compiler.h:166:29: note: expanded from macro '__UNIQUE_ID'
166 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
| ^
include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
84 | #define __PASTE(a,b) ___PASTE(a,b)
| ^
include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
83 | #define ___PASTE(a,b) a##b
| ^
<scratch space>:118:1: note: expanded from here
118 | __UNIQUE_ID_guard1101
| ^
3 errors generated.
vim +1699 fs/nfsd/nfsctl.c
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1677
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1678 /**
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1679 * nfsd_nl_threads_get_doit - get the number of running threads
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1680 * @skb: reply buffer
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1681 * @info: netlink metadata and command arguments
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1682 *
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1683 * Return 0 on success or a negative errno.
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1684 */
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1685 int nfsd_nl_threads_get_doit(struct sk_buff *skb, struct genl_info *info)
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1686 {
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1687 struct net *net = genl_info_net(info);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1688 struct nfsd_net *nn = net_generic(net, nfsd_net_id);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1689 void *hdr;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1690 int err;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1691
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1692 skb = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1693 if (!skb)
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1694 return -ENOMEM;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1695
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1696 hdr = genlmsg_iput(skb, info);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1697 if (!hdr) {
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1698 err = -EMSGSIZE;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 @1699 goto err_free_msg;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1700 }
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1701
40677c06f2c6a4 NeilBrown 2025-06-21 1702 guard(mutex)(&nn->config_mutex);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1703
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1704 err = nla_put_u32(skb, NFSD_A_SERVER_GRACETIME,
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1705 nn->nfsd4_grace) ||
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1706 nla_put_u32(skb, NFSD_A_SERVER_LEASETIME,
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1707 nn->nfsd4_lease) ||
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1708 nla_put_string(skb, NFSD_A_SERVER_SCOPE,
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1709 nn->nfsd_name);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1710 if (err)
40677c06f2c6a4 NeilBrown 2025-06-21 1711 goto err_free_msg;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1712
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1713 if (nn->nfsd_serv) {
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1714 int i;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1715
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1716 for (i = 0; i < nfsd_nrpools(net); ++i) {
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1717 struct svc_pool *sp = &nn->nfsd_serv->sv_pools[i];
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1718
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1719 err = nla_put_u32(skb, NFSD_A_SERVER_THREADS,
60749cbe3d8ae5 NeilBrown 2024-07-15 1720 sp->sp_nrthreads);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1721 if (err)
40677c06f2c6a4 NeilBrown 2025-06-21 1722 goto err_free_msg;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1723 }
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1724 } else {
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1725 err = nla_put_u32(skb, NFSD_A_SERVER_THREADS, 0);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1726 if (err)
40677c06f2c6a4 NeilBrown 2025-06-21 1727 goto err_free_msg;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1728 }
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1729
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1730 genlmsg_end(skb, hdr);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1731
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1732 return genlmsg_reply(skb, info);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1733
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1734 err_free_msg:
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1735 nlmsg_free(skb);
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1736
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1737 return err;
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1738 }
924f4fb003ba11 Lorenzo Bianconi 2024-04-23 1739
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-21 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250620233802.1453016-4-neil@brown.name>
2025-06-21 13:02 ` [PATCH 3/3] nfsd: split nfsd_mutex into one mutex per net-namespace kernel test robot
[not found] <20250618213347.425503-4-neil@brown.name>
2025-06-19 12:33 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox