Re: [PATCH 1/1] i2c: amd-mp2-pci: Simplify PM code using DEFINE_RUNTIME_DEV_PM_OPS

Re: [PATCH 1/1] i2c: amd-mp2-pci: Simplify PM code using DEFINE_RUNTIME_DEV_PM_OPS

[kernel test robot]

Hi Artem,

kernel test robot noticed the following build errors:

[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on linus/master v6.17-rc4 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/i2c-amd-mp2-pci-Simplify-PM-code-using-DEFINE_RUNTIME_DEV_PM_OPS/20250906-081304
base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link:    https://lore.kernel.org/r/20250906001217.3792723-2-artyom.shimko%40gmail.com
patch subject: [PATCH 1/1] i2c: amd-mp2-pci: Simplify PM code using DEFINE_RUNTIME_DEV_PM_OPS
config: x86_64-buildonly-randconfig-002-20250907 (https://download.01.org/0day-ci/archive/20250907/202509070541.ilqlMkml-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250907/202509070541.ilqlMkml-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509070541.ilqlMkml-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-amd-mp2-pci.c:393:16: error: no member named 'suspend' in 'struct amd_i2c_common'
     393 |                         i2c_common->suspend(i2c_common);
         |                         ~~~~~~~~~~  ^
>> drivers/i2c/busses/i2c-amd-mp2-pci.c:424:22: error: no member named 'resume' in 'struct amd_i2c_common'
     424 |                         ret = i2c_common->resume(i2c_common);
         |                               ~~~~~~~~~~  ^
   2 errors generated.


vim +393 drivers/i2c/busses/i2c-amd-mp2-pci.c

529766e0a01144 Elie Morisse    2019-03-05  381  
529766e0a01144 Elie Morisse    2019-03-05  382  static int amd_mp2_pci_suspend(struct device *dev)
529766e0a01144 Elie Morisse    2019-03-05  383  {
529766e0a01144 Elie Morisse    2019-03-05  384  	struct pci_dev *pci_dev = to_pci_dev(dev);
529766e0a01144 Elie Morisse    2019-03-05  385  	struct amd_mp2_dev *privdata = pci_get_drvdata(pci_dev);
529766e0a01144 Elie Morisse    2019-03-05  386  	struct amd_i2c_common *i2c_common;
529766e0a01144 Elie Morisse    2019-03-05  387  	unsigned int bus_id;
529766e0a01144 Elie Morisse    2019-03-05  388  	int ret = 0;
529766e0a01144 Elie Morisse    2019-03-05  389  
529766e0a01144 Elie Morisse    2019-03-05  390  	for (bus_id = 0; bus_id < 2; bus_id++) {
529766e0a01144 Elie Morisse    2019-03-05  391  		i2c_common = privdata->busses[bus_id];
529766e0a01144 Elie Morisse    2019-03-05  392  		if (i2c_common)
529766e0a01144 Elie Morisse    2019-03-05 @393  			i2c_common->suspend(i2c_common);
529766e0a01144 Elie Morisse    2019-03-05  394  	}
529766e0a01144 Elie Morisse    2019-03-05  395  
529766e0a01144 Elie Morisse    2019-03-05  396  	ret = pci_save_state(pci_dev);
529766e0a01144 Elie Morisse    2019-03-05  397  	if (ret) {
267e82b9592d0d Richard Neumann 2021-02-01  398  		pci_err(pci_dev, "pci_save_state failed = %d\n", ret);
529766e0a01144 Elie Morisse    2019-03-05  399  		return ret;
529766e0a01144 Elie Morisse    2019-03-05  400  	}
529766e0a01144 Elie Morisse    2019-03-05  401  
529766e0a01144 Elie Morisse    2019-03-05  402  	pci_disable_device(pci_dev);
529766e0a01144 Elie Morisse    2019-03-05  403  	return ret;
529766e0a01144 Elie Morisse    2019-03-05  404  }
529766e0a01144 Elie Morisse    2019-03-05  405  
529766e0a01144 Elie Morisse    2019-03-05  406  static int amd_mp2_pci_resume(struct device *dev)
529766e0a01144 Elie Morisse    2019-03-05  407  {
529766e0a01144 Elie Morisse    2019-03-05  408  	struct pci_dev *pci_dev = to_pci_dev(dev);
529766e0a01144 Elie Morisse    2019-03-05  409  	struct amd_mp2_dev *privdata = pci_get_drvdata(pci_dev);
529766e0a01144 Elie Morisse    2019-03-05  410  	struct amd_i2c_common *i2c_common;
529766e0a01144 Elie Morisse    2019-03-05  411  	unsigned int bus_id;
529766e0a01144 Elie Morisse    2019-03-05  412  	int ret = 0;
529766e0a01144 Elie Morisse    2019-03-05  413  
529766e0a01144 Elie Morisse    2019-03-05  414  	pci_restore_state(pci_dev);
529766e0a01144 Elie Morisse    2019-03-05  415  	ret = pci_enable_device(pci_dev);
529766e0a01144 Elie Morisse    2019-03-05  416  	if (ret < 0) {
267e82b9592d0d Richard Neumann 2021-02-01  417  		pci_err(pci_dev, "pci_enable_device failed = %d\n", ret);
529766e0a01144 Elie Morisse    2019-03-05  418  		return ret;
529766e0a01144 Elie Morisse    2019-03-05  419  	}
529766e0a01144 Elie Morisse    2019-03-05  420  
529766e0a01144 Elie Morisse    2019-03-05  421  	for (bus_id = 0; bus_id < 2; bus_id++) {
529766e0a01144 Elie Morisse    2019-03-05  422  		i2c_common = privdata->busses[bus_id];
529766e0a01144 Elie Morisse    2019-03-05  423  		if (i2c_common) {
529766e0a01144 Elie Morisse    2019-03-05 @424  			ret = i2c_common->resume(i2c_common);
529766e0a01144 Elie Morisse    2019-03-05  425  			if (ret < 0)
529766e0a01144 Elie Morisse    2019-03-05  426  				return ret;
529766e0a01144 Elie Morisse    2019-03-05  427  		}
529766e0a01144 Elie Morisse    2019-03-05  428  	}
529766e0a01144 Elie Morisse    2019-03-05  429  
529766e0a01144 Elie Morisse    2019-03-05  430  	return ret;
529766e0a01144 Elie Morisse    2019-03-05  431  }
529766e0a01144 Elie Morisse    2019-03-05  432  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki