* Re: [PATCH v3] stm: class: Add MIPI OST protocol support
[not found] <20251022071834.1658684-1-yingchao.deng@oss.qualcomm.com>
@ 2025-10-22 21:59 ` kernel test robot
2025-10-23 0:03 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-10-22 21:59 UTC (permalink / raw)
To: Yingchao Deng, Steven Rostedt, Masami Hiramatsu,
Mathieu Desnoyers, Jonathan Corbet, Alexander Shishkin,
Maxime Coquelin, Alexandre Torgue
Cc: llvm, oe-kbuild-all, Yingchao Deng, linux-kernel,
linux-trace-kernel, linux-doc, linux-stm32, linux-arm-kernel,
quic_yingdeng, Tingwei Zhang, Yuanfang Zhang, Jinlong Mao
Hi Yingchao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on atorgue-stm32/stm32-next]
[also build test WARNING on linus/master v6.18-rc2 next-20251022]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yingchao-Deng/stm-class-Add-MIPI-OST-protocol-support/20251022-152642
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link: https://lore.kernel.org/r/20251022071834.1658684-1-yingchao.deng%40oss.qualcomm.com
patch subject: [PATCH v3] stm: class: Add MIPI OST protocol support
config: x86_64-randconfig-071-20251023 (https://download.01.org/0day-ci/archive/20251023/202510230738.OD0OO0n6-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510230738.OD0OO0n6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510230738.OD0OO0n6-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/hwtracing/stm/p_ost.c:172:6: warning: unused variable 'i' [-Wunused-variable]
172 | int i;
| ^
1 warning generated.
vim +/i +172 drivers/hwtracing/stm/p_ost.c
154
155 static ssize_t
156 notrace ost_write(struct stm_data *data, struct stm_output *output,
157 unsigned int chan, const char *buf, size_t count,
158 struct stm_source_data *source)
159 {
160 unsigned int c = output->channel + chan;
161 unsigned int m = output->master;
162 const unsigned char nil = 0;
163 u32 header = DATA_HEADER;
164 struct trc_hdr {
165 u16 version;
166 u16 magic;
167 u32 cpu;
168 u64 timestamp;
169 u64 tgid;
170 } hdr;
171 ssize_t sz;
> 172 int i;
173 struct ost_output *op = output->pdrv_private;
174
175 /*
176 * Identify the source by entity type.
177 * If entity type is not set, return error value.
178 */
179 if (op->node.entity_type)
180 header |= ost_entity_value[op->node.entity_type];
181 else
182 return -EINVAL;
183
184 /*
185 * STP framing rules for OST frames:
186 * * the first packet of the OST frame is marked;
187 * * the last packet is a FLAG with timestamped tag.
188 */
189 /* Message layout: HEADER / DATA / TAIL */
190 /* HEADER */
191 sz = data->packet(data, m, c, STP_PACKET_DATA, STP_PACKET_MARKED,
192 4, (u8 *)&header);
193 if (sz <= 0)
194 return sz;
195
196 /* DATA */
197 hdr.version = STM_MAKE_VERSION(0, 3);
198 hdr.magic = STM_HEADER_MAGIC;
199 hdr.cpu = raw_smp_processor_id();
200 hdr.timestamp = sched_clock();
201 hdr.tgid = task_tgid_nr(current);
202 sz = stm_data_write(data, m, c, false, &hdr, sizeof(hdr));
203 if (sz <= 0)
204 return sz;
205
206 sz = stm_data_write(data, m, c, false, buf, count);
207
208 /* TAIL */
209 if (sz > 0)
210 data->packet(data, m, c, STP_PACKET_FLAG,
211 STP_PACKET_TIMESTAMPED, 0, &nil);
212
213 return sz;
214 }
215
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v3] stm: class: Add MIPI OST protocol support
[not found] <20251022071834.1658684-1-yingchao.deng@oss.qualcomm.com>
2025-10-22 21:59 ` [PATCH v3] stm: class: Add MIPI OST protocol support kernel test robot
@ 2025-10-23 0:03 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-10-23 0:03 UTC (permalink / raw)
To: Yingchao Deng, Steven Rostedt, Masami Hiramatsu,
Mathieu Desnoyers, Jonathan Corbet, Alexander Shishkin,
Maxime Coquelin, Alexandre Torgue
Cc: llvm, oe-kbuild-all, Yingchao Deng, linux-kernel,
linux-trace-kernel, linux-doc, linux-stm32, linux-arm-kernel,
quic_yingdeng, Tingwei Zhang, Yuanfang Zhang, Jinlong Mao
Hi Yingchao,
kernel test robot noticed the following build errors:
[auto build test ERROR on atorgue-stm32/stm32-next]
[also build test ERROR on linus/master v6.18-rc2 next-20251022]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yingchao-Deng/stm-class-Add-MIPI-OST-protocol-support/20251022-152642
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link: https://lore.kernel.org/r/20251022071834.1658684-1-yingchao.deng%40oss.qualcomm.com
patch subject: [PATCH v3] stm: class: Add MIPI OST protocol support
config: i386-randconfig-013-20251023 (https://download.01.org/0day-ci/archive/20251023/202510230717.u8tTLt9x-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510230717.u8tTLt9x-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510230717.u8tTLt9x-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/hwtracing/stm/p_ost.c:201:13: error: call to undeclared function 'task_tgid_nr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
201 | hdr.tgid = task_tgid_nr(current);
| ^
drivers/hwtracing/stm/p_ost.c:172:6: warning: unused variable 'i' [-Wunused-variable]
172 | int i;
| ^
1 warning and 1 error generated.
vim +/task_tgid_nr +201 drivers/hwtracing/stm/p_ost.c
154
155 static ssize_t
156 notrace ost_write(struct stm_data *data, struct stm_output *output,
157 unsigned int chan, const char *buf, size_t count,
158 struct stm_source_data *source)
159 {
160 unsigned int c = output->channel + chan;
161 unsigned int m = output->master;
162 const unsigned char nil = 0;
163 u32 header = DATA_HEADER;
164 struct trc_hdr {
165 u16 version;
166 u16 magic;
167 u32 cpu;
168 u64 timestamp;
169 u64 tgid;
170 } hdr;
171 ssize_t sz;
172 int i;
173 struct ost_output *op = output->pdrv_private;
174
175 /*
176 * Identify the source by entity type.
177 * If entity type is not set, return error value.
178 */
179 if (op->node.entity_type)
180 header |= ost_entity_value[op->node.entity_type];
181 else
182 return -EINVAL;
183
184 /*
185 * STP framing rules for OST frames:
186 * * the first packet of the OST frame is marked;
187 * * the last packet is a FLAG with timestamped tag.
188 */
189 /* Message layout: HEADER / DATA / TAIL */
190 /* HEADER */
191 sz = data->packet(data, m, c, STP_PACKET_DATA, STP_PACKET_MARKED,
192 4, (u8 *)&header);
193 if (sz <= 0)
194 return sz;
195
196 /* DATA */
197 hdr.version = STM_MAKE_VERSION(0, 3);
198 hdr.magic = STM_HEADER_MAGIC;
199 hdr.cpu = raw_smp_processor_id();
200 hdr.timestamp = sched_clock();
> 201 hdr.tgid = task_tgid_nr(current);
202 sz = stm_data_write(data, m, c, false, &hdr, sizeof(hdr));
203 if (sz <= 0)
204 return sz;
205
206 sz = stm_data_write(data, m, c, false, buf, count);
207
208 /* TAIL */
209 if (sz > 0)
210 data->packet(data, m, c, STP_PACKET_FLAG,
211 STP_PACKET_TIMESTAMPED, 0, &nil);
212
213 return sz;
214 }
215
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread