* Re: [PATCH v4 10/14] cxl: Enable AMD Zen5 address translation using ACPI PRMT
[not found] <20251103184804.509762-11-rrichter@amd.com>
@ 2025-11-04 9:33 ` kernel test robot
2025-11-04 12:49 ` Robert Richter
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-11-04 9:33 UTC (permalink / raw)
To: Robert Richter, Alison Schofield, Vishal Verma, Ira Weiny,
Dan Williams, Jonathan Cameron, Dave Jiang, Davidlohr Bueso
Cc: llvm, oe-kbuild-all, linux-cxl, linux-kernel, Gregory Price,
Fabio M. De Francesco, Terry Bowman, Joshua Hahn, Robert Richter
Hi Robert,
kernel test robot noticed the following build errors:
[auto build test ERROR on 211ddde0823f1442e4ad052a2f30f050145ccada]
url: https://github.com/intel-lab-lkp/linux/commits/Robert-Richter/cxl-region-Store-root-decoder-in-struct-cxl_region/20251104-025351
base: 211ddde0823f1442e4ad052a2f30f050145ccada
patch link: https://lore.kernel.org/r/20251103184804.509762-11-rrichter%40amd.com
patch subject: [PATCH v4 10/14] cxl: Enable AMD Zen5 address translation using ACPI PRMT
config: x86_64-randconfig-072-20251104 (https://download.01.org/0day-ci/archive/20251104/202511041721.oCz4BaCp-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251104/202511041721.oCz4BaCp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511041721.oCz4BaCp-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/cxl/core/atl.c:63:42: error: incomplete definition of type 'struct cxl_region_context'
63 | struct cxl_endpoint_decoder *cxled = ctx->cxled;
| ~~~^
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:65:32: error: incomplete definition of type 'struct cxl_region_context'
65 | struct cxl_memdev *cxlmd = ctx->cxlmd;
| ~~~^
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:66:30: error: incomplete definition of type 'struct cxl_region_context'
66 | struct range hpa_range = ctx->hpa_range;
| ~~~^
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:92:9: error: incomplete definition of type 'struct cxl_region_context'
92 | if (ctx->interleave_ways != 1) {
| ~~~^
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:94:7: error: incomplete definition of type 'struct cxl_region_context'
94 | ctx->interleave_ways, ctx->interleave_granularity);
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:139:35: note: expanded from macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:94:29: error: incomplete definition of type 'struct cxl_region_context'
94 | ctx->interleave_ways, ctx->interleave_granularity);
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:139:35: note: expanded from macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:114:39: error: incomplete definition of type 'struct cxl_region_context'
114 | hpa_range.start, hpa_range.end, ctx->hpa_range.start,
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:139:35: note: expanded from macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:115:7: error: incomplete definition of type 'struct cxl_region_context'
115 | ctx->hpa_range.end, dev_name(&cxld->dev));
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:139:35: note: expanded from macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:130:39: error: incomplete definition of type 'struct cxl_region_context'
130 | hpa_range.start, hpa_range.end, ctx->hpa_range.start,
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:139:35: note: expanded from macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:131:7: error: incomplete definition of type 'struct cxl_region_context'
131 | ctx->hpa_range.end, dev_name(&cxld->dev));
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:139:35: note: expanded from macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/cxl/core/atl.c:62:9: note: forward declaration of 'struct cxl_region_context'
62 | struct cxl_region_context *ctx = data;
| ^
drivers/cxl/core/atl.c:156:39: error: incomplete definition of type 'struct cxl_region_context'
156 | hpa_range.start, hpa_range.end, ctx->hpa_range.start,
| ~~~^
include/linux/dev_printk.h:171:49: note: expanded from macro 'dev_dbg'
171 | dev_no_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
vim +63 drivers/cxl/core/atl.c
59
60 static int cxl_prm_translate_hpa_range(struct cxl_root *cxl_root, void *data)
61 {
62 struct cxl_region_context *ctx = data;
> 63 struct cxl_endpoint_decoder *cxled = ctx->cxled;
64 struct cxl_decoder *cxld = &cxled->cxld;
65 struct cxl_memdev *cxlmd = ctx->cxlmd;
66 struct range hpa_range = ctx->hpa_range;
67 struct pci_dev *pci_dev;
68 u64 spa_len, len = range_len(&hpa_range);
69 u64 addr, base_spa, base = hpa_range.start;
70 int ways, gran;
71
72 /*
73 * When Normalized Addressing is enabled, the endpoint
74 * maintains a 1:1 mapping between HPA and DPA. If disabled,
75 * skip address translation and perform only a range check.
76 */
77 if (hpa_range.start != cxled->dpa_res->start)
78 return 0;
79
80 if (!IS_ALIGNED(hpa_range.start, SZ_256M) ||
81 !IS_ALIGNED(hpa_range.end + 1, SZ_256M)) {
82 dev_dbg(cxld->dev.parent,
83 "CXL address translation: Unaligned decoder HPA range: %#llx-%#llx(%s)\n",
84 hpa_range.start, hpa_range.end, dev_name(&cxld->dev));
85 return -ENXIO;
86 }
87
88 /*
89 * Endpoints are programmed passthrough in Normalized
90 * Addressing mode.
91 */
92 if (ctx->interleave_ways != 1) {
93 dev_dbg(&cxld->dev, "unexpected interleaving config: ways: %d granularity: %d\n",
94 ctx->interleave_ways, ctx->interleave_granularity);
95 return -ENXIO;
96 }
97
98 if (!cxlmd || !dev_is_pci(cxlmd->dev.parent)) {
99 dev_dbg(&cxld->dev, "No endpoint found: %s, range %#llx-%#llx\n",
100 dev_name(cxld->dev.parent), hpa_range.start,
101 hpa_range.end);
102 return -ENXIO;
103 }
104
105 pci_dev = to_pci_dev(cxlmd->dev.parent);
106
107 /* Translate HPA range to SPA. */
108 hpa_range.start = base_spa = prm_cxl_dpa_spa(pci_dev, hpa_range.start);
109 hpa_range.end = prm_cxl_dpa_spa(pci_dev, hpa_range.end);
110
111 if (hpa_range.start == ULLONG_MAX || hpa_range.end == ULLONG_MAX) {
112 dev_dbg(cxld->dev.parent,
113 "CXL address translation: Failed to translate HPA range: %#llx-%#llx:%#llx-%#llx(%s)\n",
114 hpa_range.start, hpa_range.end, ctx->hpa_range.start,
115 ctx->hpa_range.end, dev_name(&cxld->dev));
116 return -ENXIO;
117 }
118
119 /*
120 * Since translated addresses include the interleaving
121 * offsets, align the range to 256 MB.
122 */
123 hpa_range.start = ALIGN_DOWN(hpa_range.start, SZ_256M);
124 hpa_range.end = ALIGN(hpa_range.end, SZ_256M) - 1;
125
126 spa_len = range_len(&hpa_range);
127 if (!len || !spa_len || spa_len % len) {
128 dev_dbg(cxld->dev.parent,
129 "CXL address translation: HPA range not contiguous: %#llx-%#llx:%#llx-%#llx(%s)\n",
130 hpa_range.start, hpa_range.end, ctx->hpa_range.start,
131 ctx->hpa_range.end, dev_name(&cxld->dev));
132 return -ENXIO;
133 }
134
135 ways = spa_len / len;
136 gran = SZ_256;
137
138 /*
139 * Determine interleave granularity
140 *
141 * Note: The position of the chunk from one interleaving block
142 * to the next may vary and thus cannot be considered
143 * constant. Address offsets larger than the interleaving
144 * block size cannot be used to calculate the granularity.
145 */
146 while (ways > 1 && gran <= SZ_16M) {
147 addr = prm_cxl_dpa_spa(pci_dev, base + gran);
148 if (addr != base_spa + gran)
149 break;
150 gran <<= 1;
151 }
152
153 if (gran > SZ_16M) {
154 dev_dbg(cxld->dev.parent,
155 "CXL address translation: Cannot determine granularity: %#llx-%#llx:%#llx-%#llx(%s)\n",
156 hpa_range.start, hpa_range.end, ctx->hpa_range.start,
157 ctx->hpa_range.end, dev_name(&cxld->dev));
158 return -ENXIO;
159 }
160
161 ctx->hpa_range = hpa_range;
162 ctx->interleave_ways = ways;
163 ctx->interleave_granularity = gran;
164
165 dev_dbg(&cxld->dev,
166 "address mapping found for %s (hpa -> spa): %#llx+%#llx -> %#llx+%#llx ways:%d granularity:%d\n",
167 dev_name(ctx->cxlmd->dev.parent), base, len, hpa_range.start,
168 spa_len, ways, gran);
169
170 return 0;
171 }
172
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread