* Re: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change
[not found] <20251104-iris-seek-fix-v2-1-c9dace39b43d@oss.qualcomm.com>
@ 2025-11-05 1:08 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-11-05 1:08 UTC (permalink / raw)
To: Dikshita Agarwal, Vikash Garodia, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Hans Verkuil,
Stefan Schmidt
Cc: llvm, oe-kbuild-all, linux-media, linux-arm-msm, linux-kernel,
Val Packett, Dikshita Agarwal
Hi Dikshita,
kernel test robot noticed the following build errors:
[auto build test ERROR on 163917839c0eea3bdfe3620f27f617a55fd76302]
url: https://github.com/intel-lab-lkp/linux/commits/Dikshita-Agarwal/media-iris-Refine-internal-buffer-reconfiguration-logic-for-resolution-change/20251104-131307
base: 163917839c0eea3bdfe3620f27f617a55fd76302
patch link: https://lore.kernel.org/r/20251104-iris-seek-fix-v2-1-c9dace39b43d%40oss.qualcomm.com
patch subject: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20251105/202511050842.FTUh6ym8-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251105/202511050842.FTUh6ym8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511050842.FTUh6ym8-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/media/platform/qcom/iris/iris_common.c:99:2: error: use of undeclared identifier 'first_ipsc'
99 | first_ipsc = inst->sub_state & IRIS_INST_SUB_FIRST_IPSC;
| ^
>> drivers/media/platform/qcom/iris/iris_common.c:101:2: error: use of undeclared identifier 'drain_active'
101 | drain_active = inst->sub_state & IRIS_INST_SUB_DRAIN &&
| ^
>> drivers/media/platform/qcom/iris/iris_common.c:104:2: error: use of undeclared identifier 'drc_active'
104 | drc_active = inst->sub_state & IRIS_INST_SUB_DRC &&
| ^
drivers/media/platform/qcom/iris/iris_common.c:107:6: error: use of undeclared identifier 'drc_active'
107 | if (drc_active)
| ^
drivers/media/platform/qcom/iris/iris_common.c:109:11: error: use of undeclared identifier 'drain_active'; did you mean 'swait_active'?
109 | else if (drain_active)
| ^~~~~~~~~~~~
| swait_active
include/linux/swait.h:121:19: note: 'swait_active' declared here
121 | static inline int swait_active(struct swait_queue_head *wq)
| ^
drivers/media/platform/qcom/iris/iris_common.c:113:6: error: use of undeclared identifier 'first_ipsc'
113 | if (first_ipsc || drc_active) {
| ^
drivers/media/platform/qcom/iris/iris_common.c:113:20: error: use of undeclared identifier 'drc_active'
113 | if (first_ipsc || drc_active) {
| ^
drivers/media/platform/qcom/iris/iris_common.c:127:8: error: use of undeclared identifier 'drain_active'; did you mean 'swait_active'?
127 | if (!drain_active)
| ^~~~~~~~~~~~
| swait_active
include/linux/swait.h:121:19: note: 'swait_active' declared here
121 | static inline int swait_active(struct swait_queue_head *wq)
| ^
>> drivers/media/platform/qcom/iris/iris_common.c:127:8: warning: address of function 'swait_active' will always evaluate to 'true' [-Wpointer-bool-conversion]
127 | if (!drain_active)
| ~^~~~~~~~~~~~
drivers/media/platform/qcom/iris/iris_common.c:127:8: note: prefix with the address-of operator to silence this warning
127 | if (!drain_active)
| ^
| &
1 warning and 8 errors generated.
vim +/first_ipsc +99 drivers/media/platform/qcom/iris/iris_common.c
90
91 int iris_process_streamon_output(struct iris_inst *inst)
92 {
93 const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops;
94 enum iris_inst_sub_state clear_sub_state = 0;
95 int ret = 0;
96
97 iris_scale_power(inst);
98
> 99 first_ipsc = inst->sub_state & IRIS_INST_SUB_FIRST_IPSC;
100
> 101 drain_active = inst->sub_state & IRIS_INST_SUB_DRAIN &&
102 inst->sub_state & IRIS_INST_SUB_DRAIN_LAST;
103
> 104 drc_active = inst->sub_state & IRIS_INST_SUB_DRC &&
105 inst->sub_state & IRIS_INST_SUB_DRC_LAST;
106
107 if (drc_active)
108 clear_sub_state = IRIS_INST_SUB_DRC | IRIS_INST_SUB_DRC_LAST;
109 else if (drain_active)
110 clear_sub_state = IRIS_INST_SUB_DRAIN | IRIS_INST_SUB_DRAIN_LAST;
111
112 /* Input internal buffer reconfiguration required in case of resolution change */
113 if (first_ipsc || drc_active) {
114 ret = iris_alloc_and_queue_input_int_bufs(inst);
115 if (ret)
116 return ret;
117 ret = iris_set_stage(inst, STAGE);
118 if (ret)
119 return ret;
120 ret = iris_set_pipe(inst, PIPE);
121 if (ret)
122 return ret;
123 }
124
125 if (inst->state == IRIS_INST_INPUT_STREAMING &&
126 inst->sub_state & IRIS_INST_SUB_INPUT_PAUSE) {
> 127 if (!drain_active)
128 ret = hfi_ops->session_resume_drc(inst,
129 V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
130 else if (hfi_ops->session_resume_drain)
131 ret = hfi_ops->session_resume_drain(inst,
132 V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
133 if (ret)
134 return ret;
135 clear_sub_state |= IRIS_INST_SUB_INPUT_PAUSE;
136 }
137
138 if (inst->sub_state & IRIS_INST_SUB_FIRST_IPSC)
139 clear_sub_state |= IRIS_INST_SUB_FIRST_IPSC;
140
141 ret = hfi_ops->session_start(inst, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
142 if (ret)
143 return ret;
144
145 if (inst->sub_state & IRIS_INST_SUB_OUTPUT_PAUSE)
146 clear_sub_state |= IRIS_INST_SUB_OUTPUT_PAUSE;
147
148 ret = iris_inst_state_change_streamon(inst, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
149 if (ret)
150 return ret;
151
152 inst->last_buffer_dequeued = false;
153
154 return iris_inst_change_sub_state(inst, clear_sub_state, 0);
155 }
156
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread