Re: [PATCH] genirq: move clear of kstat_irqs to free_desc()

Re: [PATCH] genirq: move clear of kstat_irqs to free_desc()

[kernel test robot]

Hi Luigi,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on linus/master v6.19-rc4 next-20260109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Luigi-Rizzo/genirq-move-clear-of-kstat_irqs-to-free_desc/20260112-031857
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20260111191710.1993867-1-lrizzo%40google.com
patch subject: [PATCH] genirq: move clear of kstat_irqs to free_desc()
config: hexagon-allnoconfig (https://download.01.org/0day-ci/archive/20260112/202601120627.Dd67Hehl-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260112/202601120627.Dd67Hehl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601120627.Dd67Hehl-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/irq/irqdesc.c:118:6: warning: unused variable 'cpu' [-Wunused-variable]
     118 |         int cpu;
         |             ^~~
>> kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
     625 |                 for_each_possible_cpu(cpu)
         |                                       ^~~
>> kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
     625 |                 for_each_possible_cpu(cpu)
         |                                       ^~~
>> kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
     625 |                 for_each_possible_cpu(cpu)
         |                                       ^~~
   kernel/irq/irqdesc.c:626:35: error: use of undeclared identifier 'cpu'
     626 |                         *per_cpu_ptr(desc->kstat_irqs, cpu) = (struct irqstat) { };
         |                                                        ^~~
   1 warning and 4 errors generated.


vim +/cpu +625 kernel/irq/irqdesc.c

   618	
   619	static void free_desc(unsigned int irq)
   620	{
   621		struct irq_desc *desc = irq_to_desc(irq);
   622	
   623		scoped_guard(raw_spinlock_irqsave, &desc->lock) {
   624			desc_set_defaults(irq, desc, irq_desc_get_node(desc), NULL, NULL);
 > 625			for_each_possible_cpu(cpu)
   626				*per_cpu_ptr(desc->kstat_irqs, cpu) = (struct irqstat) { };
   627		}
   628		delete_irq_desc(irq);
   629	}
   630	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] genirq: move clear of kstat_irqs to free_desc()

[kernel test robot]

Hi Luigi,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on linus/master v6.19-rc5 next-20260109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Luigi-Rizzo/genirq-move-clear-of-kstat_irqs-to-free_desc/20260112-031857
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20260111191710.1993867-1-lrizzo%40google.com
patch subject: [PATCH] genirq: move clear of kstat_irqs to free_desc()
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260112/202601121654.B4jBkJbI-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260112/202601121654.B4jBkJbI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601121654.B4jBkJbI-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/irq/irqdesc.c:118:6: warning: unused variable 'cpu' [-Wunused-variable]
     118 |         int cpu;
         |             ^~~
   kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
     625 |                 for_each_possible_cpu(cpu)
         |                                       ^
   kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
   kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
   kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
   kernel/irq/irqdesc.c:625:25: error: use of undeclared identifier 'cpu'
   kernel/irq/irqdesc.c:626:35: error: use of undeclared identifier 'cpu'
     626 |                         *per_cpu_ptr(desc->kstat_irqs, cpu) = (struct irqstat) { };
         |                                                        ^
>> kernel/irq/irqdesc.c:626:4: error: indirection requires pointer operand ('unsigned long' invalid)
     626 |                         *per_cpu_ptr(desc->kstat_irqs, cpu) = (struct irqstat) { };
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning and 7 errors generated.


vim +626 kernel/irq/irqdesc.c

   618	
   619	static void free_desc(unsigned int irq)
   620	{
   621		struct irq_desc *desc = irq_to_desc(irq);
   622	
   623		scoped_guard(raw_spinlock_irqsave, &desc->lock) {
   624			desc_set_defaults(irq, desc, irq_desc_get_node(desc), NULL, NULL);
 > 625			for_each_possible_cpu(cpu)
 > 626				*per_cpu_ptr(desc->kstat_irqs, cpu) = (struct irqstat) { };
   627		}
   628		delete_irq_desc(irq);
   629	}
   630	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki