[driver-core:driver-core-testing 3/16] Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

[driver-core:driver-core-testing 3/16] Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
head:   e7ccc9e054beb4c366228d24786f67c738206605
commit: eea5d2bb34ba11dccd9c53f392dc50cf060150a9 [3/16] kernfs: Send IN_DELETE_SELF and IN_IGNORED
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260313/202603130112.2FcCzv1g-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/202603130112.2FcCzv1g-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603130112.2FcCzv1g-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
>> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [driver-core:driver-core-testing 3/16] Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

[T.J. Mercier]

On Thu, Mar 12, 2026 at 5:46 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
> head:   e7ccc9e054beb4c366228d24786f67c738206605
> commit: eea5d2bb34ba11dccd9c53f392dc50cf060150a9 [3/16] kernfs: Send IN_DELETE_SELF and IN_IGNORED
> config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260313/202603130112.2FcCzv1g-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/202603130112.2FcCzv1g-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202603130112.2FcCzv1g-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
> >> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

Ah, yes. This will fix it. Greg should I resend the patches?

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 715b651e35a0..7f355316704c 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -481,6 +481,8 @@ void kernfs_put_active(struct kernfs_node *kn)
 /**
  * kernfs_drain - drain kernfs_node
  * @kn: kernfs_node to drain
+ * @drop_supers: Set to true if this function is called with the
+ *               kernfs_supers_rwsem locked.

Re: [driver-core:driver-core-testing 3/16] Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

[Greg Kroah-Hartman]

On Thu, Mar 12, 2026 at 06:27:56PM -0700, T.J. Mercier wrote:
> On Thu, Mar 12, 2026 at 5:46 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
> > head:   e7ccc9e054beb4c366228d24786f67c738206605
> > commit: eea5d2bb34ba11dccd9c53f392dc50cf060150a9 [3/16] kernfs: Send IN_DELETE_SELF and IN_IGNORED
> > config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260313/202603130112.2FcCzv1g-lkp@intel.com/config)
> > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/202603130112.2FcCzv1g-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202603130112.2FcCzv1g-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
> > >> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> Ah, yes. This will fix it. Greg should I resend the patches?
> 
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index 715b651e35a0..7f355316704c 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -481,6 +481,8 @@ void kernfs_put_active(struct kernfs_node *kn)
>  /**
>   * kernfs_drain - drain kernfs_node
>   * @kn: kernfs_node to drain
> + * @drop_supers: Set to true if this function is called with the
> + *               kernfs_supers_rwsem locked.

Just send this as a fix-up, as it is just a documentation update.

thanks,

greg k-h