* Re: [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper
[not found] <ff936ce4ad3044102c367c55e7a455ab0020e4b7.1774136876.git.daniel@makrotopia.org>
@ 2026-03-23 10:39 ` kernel test robot
2026-03-24 20:58 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-03-23 10:39 UTC (permalink / raw)
To: Daniel Golle, Andrew Lunn, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Russell King, linux-kernel
Cc: llvm, oe-kbuild-all, netdev, Frank Wunderlich, Chad Monroe,
Cezary Wilmanski, Liang Xu, Benny (Ying-Tsan) Weng,
Jose Maria Verdu Munoz, Avinash Jayaraman, John Crispin
Hi Daniel,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/net-dsa-add-driver-private-pointer-to-struct-dsa_bridge/20260323-041502
base: net-next/main
patch link: https://lore.kernel.org/r/ff936ce4ad3044102c367c55e7a455ab0020e4b7.1774136876.git.daniel%40makrotopia.org
patch subject: [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper
config: arm-randconfig-002-20260323 (https://download.01.org/0day-ci/archive/20260323/202603231807.3CRfrjTg-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project c911b8492374942bf4cfe35411e90a35d3837f6a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260323/202603231807.3CRfrjTg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603231807.3CRfrjTg-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/dsa/yt921x.c:2158:1: error: conflicting types for 'dsa_bridge_ports'
2158 | dsa_bridge_ports(struct dsa_switch *ds, const struct net_device *bdev)
| ^
include/net/dsa.h:845:19: note: previous definition is here
845 | static inline u32 dsa_bridge_ports(struct dsa_switch *ds,
| ^
>> drivers/net/dsa/yt921x.c:2213:38: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'const struct dsa_bridge *' [-Wincompatible-pointer-types]
2213 | ports_mask = dsa_bridge_ports(ds, bdev);
| ^~~~
include/net/dsa.h:846:33: note: passing argument to parameter 'bridge' here
846 | const struct dsa_bridge *bridge)
| ^
drivers/net/dsa/yt921x.c:2285:36: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'const struct dsa_bridge *' [-Wincompatible-pointer-types]
2285 | ports_mask = dsa_bridge_ports(ds, bridge.dev);
| ^~~~~~~~~~
include/net/dsa.h:846:33: note: passing argument to parameter 'bridge' here
846 | const struct dsa_bridge *bridge)
| ^
3 errors generated.
vim +/dsa_bridge_ports +2158 drivers/net/dsa/yt921x.c
186623f4aa724c David Yang 2025-10-17 2156
186623f4aa724c David Yang 2025-10-17 2157 static u32
186623f4aa724c David Yang 2025-10-17 @2158 dsa_bridge_ports(struct dsa_switch *ds, const struct net_device *bdev)
186623f4aa724c David Yang 2025-10-17 2159 {
186623f4aa724c David Yang 2025-10-17 2160 struct dsa_port *dp;
186623f4aa724c David Yang 2025-10-17 2161 u32 mask = 0;
186623f4aa724c David Yang 2025-10-17 2162
186623f4aa724c David Yang 2025-10-17 2163 dsa_switch_for_each_user_port(dp, ds)
186623f4aa724c David Yang 2025-10-17 2164 if (dsa_port_offloads_bridge_dev(dp, bdev))
186623f4aa724c David Yang 2025-10-17 2165 mask |= BIT(dp->index);
186623f4aa724c David Yang 2025-10-17 2166
186623f4aa724c David Yang 2025-10-17 2167 return mask;
186623f4aa724c David Yang 2025-10-17 2168 }
186623f4aa724c David Yang 2025-10-17 2169
186623f4aa724c David Yang 2025-10-17 2170 static int
186623f4aa724c David Yang 2025-10-17 2171 yt921x_bridge_flags(struct yt921x_priv *priv, int port,
186623f4aa724c David Yang 2025-10-17 2172 struct switchdev_brport_flags flags)
186623f4aa724c David Yang 2025-10-17 2173 {
186623f4aa724c David Yang 2025-10-17 2174 struct yt921x_port *pp = &priv->ports[port];
186623f4aa724c David Yang 2025-10-17 2175 bool do_flush;
186623f4aa724c David Yang 2025-10-17 2176 u32 mask;
186623f4aa724c David Yang 2025-10-17 2177 int res;
186623f4aa724c David Yang 2025-10-17 2178
186623f4aa724c David Yang 2025-10-17 2179 if (flags.mask & BR_LEARNING) {
186623f4aa724c David Yang 2025-10-17 2180 bool learning = flags.val & BR_LEARNING;
186623f4aa724c David Yang 2025-10-17 2181
186623f4aa724c David Yang 2025-10-17 2182 mask = YT921X_PORT_LEARN_DIS;
186623f4aa724c David Yang 2025-10-17 2183 res = yt921x_reg_toggle_bits(priv, YT921X_PORTn_LEARN(port),
186623f4aa724c David Yang 2025-10-17 2184 mask, !learning);
186623f4aa724c David Yang 2025-10-17 2185 if (res)
186623f4aa724c David Yang 2025-10-17 2186 return res;
186623f4aa724c David Yang 2025-10-17 2187 }
186623f4aa724c David Yang 2025-10-17 2188
186623f4aa724c David Yang 2025-10-17 2189 /* BR_FLOOD, BR_MCAST_FLOOD: see the comment where ACT_UNK_ACTn_TRAP
186623f4aa724c David Yang 2025-10-17 2190 * is set
186623f4aa724c David Yang 2025-10-17 2191 */
186623f4aa724c David Yang 2025-10-17 2192
186623f4aa724c David Yang 2025-10-17 2193 /* BR_BCAST_FLOOD: we can filter bcast, but cannot trap them */
186623f4aa724c David Yang 2025-10-17 2194
186623f4aa724c David Yang 2025-10-17 2195 do_flush = false;
186623f4aa724c David Yang 2025-10-17 2196 if (flags.mask & BR_HAIRPIN_MODE) {
186623f4aa724c David Yang 2025-10-17 2197 pp->hairpin = flags.val & BR_HAIRPIN_MODE;
186623f4aa724c David Yang 2025-10-17 2198 do_flush = true;
186623f4aa724c David Yang 2025-10-17 2199 }
186623f4aa724c David Yang 2025-10-17 2200 if (flags.mask & BR_ISOLATED) {
186623f4aa724c David Yang 2025-10-17 2201 pp->isolated = flags.val & BR_ISOLATED;
186623f4aa724c David Yang 2025-10-17 2202 do_flush = true;
186623f4aa724c David Yang 2025-10-17 2203 }
186623f4aa724c David Yang 2025-10-17 2204 if (do_flush) {
186623f4aa724c David Yang 2025-10-17 2205 struct dsa_switch *ds = &priv->ds;
186623f4aa724c David Yang 2025-10-17 2206 struct dsa_port *dp = dsa_to_port(ds, port);
186623f4aa724c David Yang 2025-10-17 2207 struct net_device *bdev;
186623f4aa724c David Yang 2025-10-17 2208
186623f4aa724c David Yang 2025-10-17 2209 bdev = dsa_port_bridge_dev_get(dp);
186623f4aa724c David Yang 2025-10-17 2210 if (bdev) {
186623f4aa724c David Yang 2025-10-17 2211 u32 ports_mask;
186623f4aa724c David Yang 2025-10-17 2212
186623f4aa724c David Yang 2025-10-17 @2213 ports_mask = dsa_bridge_ports(ds, bdev);
186623f4aa724c David Yang 2025-10-17 2214 ports_mask |= priv->cpu_ports_mask;
186623f4aa724c David Yang 2025-10-17 2215 res = yt921x_bridge(priv, ports_mask);
186623f4aa724c David Yang 2025-10-17 2216 if (res)
186623f4aa724c David Yang 2025-10-17 2217 return res;
186623f4aa724c David Yang 2025-10-17 2218 }
186623f4aa724c David Yang 2025-10-17 2219 }
186623f4aa724c David Yang 2025-10-17 2220
186623f4aa724c David Yang 2025-10-17 2221 return 0;
186623f4aa724c David Yang 2025-10-17 2222 }
186623f4aa724c David Yang 2025-10-17 2223
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper
[not found] <ff936ce4ad3044102c367c55e7a455ab0020e4b7.1774136876.git.daniel@makrotopia.org>
2026-03-23 10:39 ` [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper kernel test robot
@ 2026-03-24 20:58 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-03-24 20:58 UTC (permalink / raw)
To: Daniel Golle, Andrew Lunn, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Russell King, linux-kernel
Cc: llvm, oe-kbuild-all, netdev, Frank Wunderlich, Chad Monroe,
Cezary Wilmanski, Liang Xu, Benny (Ying-Tsan) Weng,
Jose Maria Verdu Munoz, Avinash Jayaraman, John Crispin
Hi Daniel,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/net-dsa-add-driver-private-pointer-to-struct-dsa_bridge/20260323-041502
base: net-next/main
patch link: https://lore.kernel.org/r/ff936ce4ad3044102c367c55e7a455ab0020e4b7.1774136876.git.daniel%40makrotopia.org
patch subject: [PATCH net-next v6 2/4] net: dsa: add bridge member iteration macro and port mask helper
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260325/202603250450.uUuzfUx3-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260325/202603250450.uUuzfUx3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603250450.uUuzfUx3-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/net/dsa/yt921x.c:2158:1: error: conflicting types for 'dsa_bridge_ports'
dsa_bridge_ports(struct dsa_switch *ds, const struct net_device *bdev)
^
include/net/dsa.h:845:19: note: previous definition is here
static inline u32 dsa_bridge_ports(struct dsa_switch *ds,
^
>> drivers/net/dsa/yt921x.c:2213:38: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'const struct dsa_bridge *' [-Werror,-Wincompatible-pointer-types]
ports_mask = dsa_bridge_ports(ds, bdev);
^~~~
include/net/dsa.h:846:33: note: passing argument to parameter 'bridge' here
const struct dsa_bridge *bridge)
^
drivers/net/dsa/yt921x.c:2285:36: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'const struct dsa_bridge *' [-Werror,-Wincompatible-pointer-types]
ports_mask = dsa_bridge_ports(ds, bridge.dev);
^~~~~~~~~~
include/net/dsa.h:846:33: note: passing argument to parameter 'bridge' here
const struct dsa_bridge *bridge)
^
3 errors generated.
vim +2213 drivers/net/dsa/yt921x.c
186623f4aa724c David Yang 2025-10-17 2169
186623f4aa724c David Yang 2025-10-17 2170 static int
186623f4aa724c David Yang 2025-10-17 2171 yt921x_bridge_flags(struct yt921x_priv *priv, int port,
186623f4aa724c David Yang 2025-10-17 2172 struct switchdev_brport_flags flags)
186623f4aa724c David Yang 2025-10-17 2173 {
186623f4aa724c David Yang 2025-10-17 2174 struct yt921x_port *pp = &priv->ports[port];
186623f4aa724c David Yang 2025-10-17 2175 bool do_flush;
186623f4aa724c David Yang 2025-10-17 2176 u32 mask;
186623f4aa724c David Yang 2025-10-17 2177 int res;
186623f4aa724c David Yang 2025-10-17 2178
186623f4aa724c David Yang 2025-10-17 2179 if (flags.mask & BR_LEARNING) {
186623f4aa724c David Yang 2025-10-17 2180 bool learning = flags.val & BR_LEARNING;
186623f4aa724c David Yang 2025-10-17 2181
186623f4aa724c David Yang 2025-10-17 2182 mask = YT921X_PORT_LEARN_DIS;
186623f4aa724c David Yang 2025-10-17 2183 res = yt921x_reg_toggle_bits(priv, YT921X_PORTn_LEARN(port),
186623f4aa724c David Yang 2025-10-17 2184 mask, !learning);
186623f4aa724c David Yang 2025-10-17 2185 if (res)
186623f4aa724c David Yang 2025-10-17 2186 return res;
186623f4aa724c David Yang 2025-10-17 2187 }
186623f4aa724c David Yang 2025-10-17 2188
186623f4aa724c David Yang 2025-10-17 2189 /* BR_FLOOD, BR_MCAST_FLOOD: see the comment where ACT_UNK_ACTn_TRAP
186623f4aa724c David Yang 2025-10-17 2190 * is set
186623f4aa724c David Yang 2025-10-17 2191 */
186623f4aa724c David Yang 2025-10-17 2192
186623f4aa724c David Yang 2025-10-17 2193 /* BR_BCAST_FLOOD: we can filter bcast, but cannot trap them */
186623f4aa724c David Yang 2025-10-17 2194
186623f4aa724c David Yang 2025-10-17 2195 do_flush = false;
186623f4aa724c David Yang 2025-10-17 2196 if (flags.mask & BR_HAIRPIN_MODE) {
186623f4aa724c David Yang 2025-10-17 2197 pp->hairpin = flags.val & BR_HAIRPIN_MODE;
186623f4aa724c David Yang 2025-10-17 2198 do_flush = true;
186623f4aa724c David Yang 2025-10-17 2199 }
186623f4aa724c David Yang 2025-10-17 2200 if (flags.mask & BR_ISOLATED) {
186623f4aa724c David Yang 2025-10-17 2201 pp->isolated = flags.val & BR_ISOLATED;
186623f4aa724c David Yang 2025-10-17 2202 do_flush = true;
186623f4aa724c David Yang 2025-10-17 2203 }
186623f4aa724c David Yang 2025-10-17 2204 if (do_flush) {
186623f4aa724c David Yang 2025-10-17 2205 struct dsa_switch *ds = &priv->ds;
186623f4aa724c David Yang 2025-10-17 2206 struct dsa_port *dp = dsa_to_port(ds, port);
186623f4aa724c David Yang 2025-10-17 2207 struct net_device *bdev;
186623f4aa724c David Yang 2025-10-17 2208
186623f4aa724c David Yang 2025-10-17 2209 bdev = dsa_port_bridge_dev_get(dp);
186623f4aa724c David Yang 2025-10-17 2210 if (bdev) {
186623f4aa724c David Yang 2025-10-17 2211 u32 ports_mask;
186623f4aa724c David Yang 2025-10-17 2212
186623f4aa724c David Yang 2025-10-17 @2213 ports_mask = dsa_bridge_ports(ds, bdev);
186623f4aa724c David Yang 2025-10-17 2214 ports_mask |= priv->cpu_ports_mask;
186623f4aa724c David Yang 2025-10-17 2215 res = yt921x_bridge(priv, ports_mask);
186623f4aa724c David Yang 2025-10-17 2216 if (res)
186623f4aa724c David Yang 2025-10-17 2217 return res;
186623f4aa724c David Yang 2025-10-17 2218 }
186623f4aa724c David Yang 2025-10-17 2219 }
186623f4aa724c David Yang 2025-10-17 2220
186623f4aa724c David Yang 2025-10-17 2221 return 0;
186623f4aa724c David Yang 2025-10-17 2222 }
186623f4aa724c David Yang 2025-10-17 2223
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread