net/core/bpf_sk_storage.c:140:57: error: too many arguments to function call, expected 4, have 5

net/core/bpf_sk_storage.c:140:57: error: too many arguments to function call, expected 4, have 5

[kernel test robot]

tree:   https://github.com/intel-lab-lkp/linux/commits/Amery-Hung/selftests-bpf-Remove-kmalloc-tracing-from-local-storage-create-bench/20260415-163526
head:   22bd953a5faeea8dd0780f885b234d987745e31b
commit: 22bd953a5faeea8dd0780f885b234d987745e31b bpf: Remove gfp_flags plumbing from bpf_local_storage_update()
date:   15 hours ago
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260416/202604160220.9glH3zwm-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260416/202604160220.9glH3zwm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604160220.9glH3zwm-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/core/bpf_sk_storage.c:140:57: error: too many arguments to function call, expected 4, have 5
     140 |         copy_selem = bpf_selem_alloc(smap, newsk, NULL, false, GFP_ATOMIC);
         |                      ~~~~~~~~~~~~~~~                           ^~~~~~~~~~
   include/linux/gfp_types.h:376:20: note: expanded from macro 'GFP_ATOMIC'
     376 | #define GFP_ATOMIC      (__GFP_HIGH|__GFP_KSWAPD_RECLAIM)
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/bpf_local_storage.h:190:1: note: 'bpf_selem_alloc' declared here
     190 | bpf_selem_alloc(struct bpf_local_storage_map *smap, void *owner, void *value,
         | ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     191 |                 bool swap_uptrs);
         |                 ~~~~~~~~~~~~~~~
   net/core/bpf_sk_storage.c:205:59: error: too many arguments to function call, expected 3, have 4
     205 |                         ret = bpf_local_storage_alloc(newsk, smap, copy_selem, GFP_ATOMIC);
         |                               ~~~~~~~~~~~~~~~~~~~~~~~                          ^~~~~~~~~~
   include/linux/gfp_types.h:376:20: note: expanded from macro 'GFP_ATOMIC'
     376 | #define GFP_ATOMIC      (__GFP_HIGH|__GFP_KSWAPD_RECLAIM)
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/bpf_local_storage.h:197:1: note: 'bpf_local_storage_alloc' declared here
     197 | bpf_local_storage_alloc(void *owner,
         | ^                       ~~~~~~~~~~~~
     198 |                         struct bpf_local_storage_map *smap,
         |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     199 |                         struct bpf_local_storage_elem *first_selem);
         |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +140 net/core/bpf_sk_storage.c

6ac99e8f23d4b1 Martin KaFai Lau        2019-04-26  132  
1f00d375af84fb KP Singh                2020-08-25  133  static struct bpf_local_storage_elem *
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  134  bpf_sk_storage_clone_elem(struct sock *newsk,
1f00d375af84fb KP Singh                2020-08-25  135  			  struct bpf_local_storage_map *smap,
1f00d375af84fb KP Singh                2020-08-25  136  			  struct bpf_local_storage_elem *selem)
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  137  {
1f00d375af84fb KP Singh                2020-08-25  138  	struct bpf_local_storage_elem *copy_selem;
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  139  
0e854e55356908 Amery Hung              2025-11-14 @140  	copy_selem = bpf_selem_alloc(smap, newsk, NULL, false, GFP_ATOMIC);
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  141  	if (!copy_selem)
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  142  		return NULL;
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  143  
db559117828d24 Kumar Kartikeya Dwivedi 2022-11-04  144  	if (btf_record_has_field(smap->map.record, BPF_SPIN_LOCK))
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  145  		copy_map_value_locked(&smap->map, SDATA(copy_selem)->data,
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  146  				      SDATA(selem)->data, true);
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  147  	else
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  148  		copy_map_value(&smap->map, SDATA(copy_selem)->data,
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  149  			       SDATA(selem)->data);
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  150  
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  151  	return copy_selem;
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  152  }
8f51dfc73bf181 Stanislav Fomichev      2019-08-14  153  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki