* Re: [PATCH 1/1] media: atomisp: mt9m114: Graceful teardown atomisp and mt9m114
[not found] <20260418092651.7873-2-rn.mast@zonnet.nl>
@ 2026-04-22 14:37 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-04-22 14:37 UTC (permalink / raw)
To: Robert Mast, hdegoede
Cc: llvm, oe-kbuild-all, mchehab, sakari.ailus, linux-media,
linux-staging, andy, gregkh, linux-kernel, laurent.pinchart,
Robert Mast
Hi Robert,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v7.0]
[cannot apply to staging/staging-testing staging/staging-next staging/staging-linus linuxtv-media-pending/master sailus-media-tree/master linus/master sailus-media-tree/streams next-20260422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Robert-Mast/media-atomisp-mt9m114-Graceful-teardown-atomisp-and-mt9m114/20260421-171953
base: v7.0
patch link: https://lore.kernel.org/r/20260418092651.7873-2-rn.mast%40zonnet.nl
patch subject: [PATCH 1/1] media: atomisp: mt9m114: Graceful teardown atomisp and mt9m114
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260422/202604222246.sNhBwsBf-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260422/202604222246.sNhBwsBf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604222246.sNhBwsBf-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/i2c/mt9m114.c:2554:1: warning: unused label 'read_slew_rate' [-Wunused-label]
2554 | read_slew_rate:
| ^~~~~~~~~~~~~~~
1 warning generated.
vim +/read_slew_rate +2554 drivers/media/i2c/mt9m114.c
2497
2498 static int mt9m114_parse_dt(struct mt9m114 *sensor)
2499 {
2500 struct fwnode_handle *fwnode;
2501 struct fwnode_handle *ep;
2502 int ret;
2503
2504 #if IS_ENABLED(CONFIG_ACPI)
2505 if (has_acpi_companion(&sensor->client->dev)) {
2506 /*
2507 * On some reload sequences a stale software-node graph can be
2508 * observed for this ACPI-enumerated sensor. Use the known safe
2509 * default bus configuration and skip endpoint graph parsing.
2510 */
2511 memset(&sensor->bus_cfg, 0, sizeof(sensor->bus_cfg));
2512 sensor->bus_cfg.bus_type = V4L2_MBUS_CSI2_DPHY;
2513 sensor->bus_cfg.bus.mipi_csi2.num_data_lanes = 1;
2514 goto read_slew_rate;
2515 }
2516 #endif
2517 fwnode = dev_fwnode(&sensor->client->dev);
2518
2519 /*
2520 * On ACPI systems the fwnode graph can be initialized by a bridge
2521 * driver, which may not have probed yet. Wait for this.
2522 *
2523 * TODO: Return an error once bridge driver code will have moved
2524 * to the ACPI core.
2525 */
2526 ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
2527 if (IS_ERR(ep))
2528 return dev_err_probe(&sensor->client->dev, PTR_ERR(ep),
2529 "failed to get fwnode graph endpoint\n");
2530 if (!ep)
2531 return dev_err_probe(&sensor->client->dev, -EPROBE_DEFER,
2532 "waiting for fwnode graph endpoint\n");
2533
2534 sensor->bus_cfg.bus_type = V4L2_MBUS_UNKNOWN;
2535 ret = v4l2_fwnode_endpoint_alloc_parse(ep, &sensor->bus_cfg);
2536 fwnode_handle_put(ep);
2537 if (ret < 0) {
2538 dev_err(&sensor->client->dev, "Failed to parse endpoint\n");
2539 goto error;
2540 }
2541
2542 switch (sensor->bus_cfg.bus_type) {
2543 case V4L2_MBUS_CSI2_DPHY:
2544 case V4L2_MBUS_PARALLEL:
2545 break;
2546
2547 default:
2548 dev_err(&sensor->client->dev, "unsupported bus type %u\n",
2549 sensor->bus_cfg.bus_type);
2550 ret = -EINVAL;
2551 goto error;
2552 }
2553
> 2554 read_slew_rate:
2555 sensor->pad_slew_rate = MT9M114_PAD_SLEW_DEFAULT;
2556 device_property_read_u32(&sensor->client->dev, "slew-rate",
2557 &sensor->pad_slew_rate);
2558
2559 if (sensor->pad_slew_rate < MT9M114_PAD_SLEW_MIN ||
2560 sensor->pad_slew_rate > MT9M114_PAD_SLEW_MAX) {
2561 dev_err(&sensor->client->dev, "Invalid slew-rate %u\n",
2562 sensor->pad_slew_rate);
2563 return -EINVAL;
2564 }
2565
2566 return 0;
2567
2568 error:
2569 v4l2_fwnode_endpoint_free(&sensor->bus_cfg);
2570 return ret;
2571 }
2572
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread