* [dhowells-fs:ceph-iter 98/103] fs/ceph/inode.c:2502:50: warning: variable 'pos' is uninitialized when used here
@ 2026-05-03 17:58 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-05-03 17:58 UTC (permalink / raw)
To: David Howells; +Cc: llvm, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git ceph-iter
head: 62509662bb514752f7ae58e3c60ed040bd2bafaf
commit: 4a435e6fadf480f11ee22349cd7be8357ad0ff21 [98/103] ceph: Use netfslib [INCOMPLETE]
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260504/202605040125.TvvMETPu-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260504/202605040125.TvvMETPu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605040125.TvvMETPu-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/ceph/inode.c:2502:50: warning: variable 'pos' is uninitialized when used here [-Wuninitialized]
2502 | doutc(cl, "hit hole, ppos %lld < size %lld\n", pos, i_size);
| ^~~
include/linux/ceph/ceph_debug.h:27:6: note: expanded from macro 'doutc'
27 | ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:635:26: note: expanded from macro 'pr_debug'
635 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:281:22: note: expanded from macro 'dynamic_pr_debug'
281 | pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:261:59: note: expanded from macro '_dynamic_func_call'
261 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:259:65: note: expanded from macro '_dynamic_func_call_cls'
259 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:231:15: note: expanded from macro '__dynamic_func_call_cls'
231 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/ceph/inode.c:2445:12: note: initialize the variable 'pos' to silence this warning
2445 | loff_t pos, orig_pos = round_down(attr->ia_size,
| ^
| = 0
1 warning generated.
vim +/pos +2502 fs/ceph/inode.c
79f2f6ad878c1f2 Jeff Layton 2020-09-03 2430
5c64737d253683b Xiubo Li 2022-08-25 2431 /*
5c64737d253683b Xiubo Li 2022-08-25 2432 * Transfer the encrypted last block to the MDS and the MDS
5c64737d253683b Xiubo Li 2022-08-25 2433 * will help update it when truncating a smaller size.
5c64737d253683b Xiubo Li 2022-08-25 2434 *
5c64737d253683b Xiubo Li 2022-08-25 2435 * We don't support a PAGE_SIZE that is smaller than the
5c64737d253683b Xiubo Li 2022-08-25 2436 * CEPH_FSCRYPT_BLOCK_SIZE.
5c64737d253683b Xiubo Li 2022-08-25 2437 */
5c64737d253683b Xiubo Li 2022-08-25 2438 static int fill_fscrypt_truncate(struct inode *inode,
5c64737d253683b Xiubo Li 2022-08-25 2439 struct ceph_mds_request *req,
5c64737d253683b Xiubo Li 2022-08-25 2440 struct iattr *attr)
5c64737d253683b Xiubo Li 2022-08-25 2441 {
38d46409c4639a1 Xiubo Li 2023-06-12 2442 struct ceph_client *cl = ceph_inode_to_client(inode);
5c64737d253683b Xiubo Li 2022-08-25 2443 struct ceph_inode_info *ci = ceph_inode(inode);
5c64737d253683b Xiubo Li 2022-08-25 2444 int boff = attr->ia_size % CEPH_FSCRYPT_BLOCK_SIZE;
5c64737d253683b Xiubo Li 2022-08-25 2445 loff_t pos, orig_pos = round_down(attr->ia_size,
5c64737d253683b Xiubo Li 2022-08-25 2446 CEPH_FSCRYPT_BLOCK_SIZE);
5c64737d253683b Xiubo Li 2022-08-25 2447 u64 block = orig_pos >> CEPH_FSCRYPT_BLOCK_SHIFT;
3233a4eba55cbb6 David Howells 2023-08-03 2448 struct bvecq *dbuf = NULL;
5c64737d253683b Xiubo Li 2022-08-25 2449 struct iov_iter iter;
3233a4eba55cbb6 David Howells 2023-08-03 2450 struct ceph_fscrypt_truncate_size_header *header;
3233a4eba55cbb6 David Howells 2023-08-03 2451 void *p;
5c64737d253683b Xiubo Li 2022-08-25 2452 int len = CEPH_FSCRYPT_BLOCK_SIZE;
5c64737d253683b Xiubo Li 2022-08-25 2453 loff_t i_size = i_size_read(inode);
5c64737d253683b Xiubo Li 2022-08-25 2454 int got, ret, issued;
5c64737d253683b Xiubo Li 2022-08-25 2455
5c64737d253683b Xiubo Li 2022-08-25 2456 ret = __ceph_get_caps(inode, NULL, CEPH_CAP_FILE_RD, 0, -1, &got);
5c64737d253683b Xiubo Li 2022-08-25 2457 if (ret < 0)
5c64737d253683b Xiubo Li 2022-08-25 2458 return ret;
5c64737d253683b Xiubo Li 2022-08-25 2459
5c64737d253683b Xiubo Li 2022-08-25 2460 issued = __ceph_caps_issued(ci, NULL);
5c64737d253683b Xiubo Li 2022-08-25 2461
38d46409c4639a1 Xiubo Li 2023-06-12 2462 doutc(cl, "size %lld -> %lld got cap refs on %s, issued %s\n",
5c64737d253683b Xiubo Li 2022-08-25 2463 i_size, attr->ia_size, ceph_cap_string(got),
5c64737d253683b Xiubo Li 2022-08-25 2464 ceph_cap_string(issued));
5c64737d253683b Xiubo Li 2022-08-25 2465
5c64737d253683b Xiubo Li 2022-08-25 2466 ret = -ENOMEM;
3233a4eba55cbb6 David Howells 2023-08-03 2467 dbuf = bvecq_alloc_chain(2, GFP_KERNEL);
3233a4eba55cbb6 David Howells 2023-08-03 2468 if (!dbuf)
5c64737d253683b Xiubo Li 2022-08-25 2469 goto out;
5c64737d253683b Xiubo Li 2022-08-25 2470
3233a4eba55cbb6 David Howells 2023-08-03 2471 if (ceph_bvecq_insert_frag(dbuf, 0, sizeof(*header), GFP_KERNEL) < 0 ||
3233a4eba55cbb6 David Howells 2023-08-03 2472 ceph_bvecq_insert_frag(dbuf, 1, PAGE_SIZE, GFP_KERNEL) < 0)
5c64737d253683b Xiubo Li 2022-08-25 2473 goto out;
5c64737d253683b Xiubo Li 2022-08-25 2474
3233a4eba55cbb6 David Howells 2023-08-03 2475 iov_iter_bvec_queue(&iter, ITER_DEST, dbuf, 1, 0, len);
4a435e6fadf480f David Howells 2024-12-05 2476 ret = netfs_unbuffered_read_from_inode(inode, orig_pos, dbuf, len, true);
4a435e6fadf480f David Howells 2024-12-05 2477 if (ret < 0 && ret != -ENODATA)
5c64737d253683b Xiubo Li 2022-08-25 2478 goto out;
5c64737d253683b Xiubo Li 2022-08-25 2479
3233a4eba55cbb6 David Howells 2023-08-03 2480 header = kmap_local_bvecq(dbuf, 0);
3233a4eba55cbb6 David Howells 2023-08-03 2481
5c64737d253683b Xiubo Li 2022-08-25 2482 /* Insert the header first */
3233a4eba55cbb6 David Howells 2023-08-03 2483 header->ver = 1;
3233a4eba55cbb6 David Howells 2023-08-03 2484 header->compat = 1;
3233a4eba55cbb6 David Howells 2023-08-03 2485 header->change_attr = cpu_to_le64(inode_peek_iversion_raw(inode));
5c64737d253683b Xiubo Li 2022-08-25 2486
5c64737d253683b Xiubo Li 2022-08-25 2487 /*
5c64737d253683b Xiubo Li 2022-08-25 2488 * Always set the block_size to CEPH_FSCRYPT_BLOCK_SIZE,
5c64737d253683b Xiubo Li 2022-08-25 2489 * because in MDS it may need this to do the truncate.
5c64737d253683b Xiubo Li 2022-08-25 2490 */
3233a4eba55cbb6 David Howells 2023-08-03 2491 header->block_size = cpu_to_le32(CEPH_FSCRYPT_BLOCK_SIZE);
5c64737d253683b Xiubo Li 2022-08-25 2492
5c64737d253683b Xiubo Li 2022-08-25 2493 /*
4a435e6fadf480f David Howells 2024-12-05 2494 * If we hit a hole here, we should just skip filling the fscrypt for
4a435e6fadf480f David Howells 2024-12-05 2495 * the request, because once the fscrypt is enabled, the file will be
4a435e6fadf480f David Howells 2024-12-05 2496 * split into many blocks with the size of CEPH_FSCRYPT_BLOCK_SIZE. If
4a435e6fadf480f David Howells 2024-12-05 2497 * there was a hole, the hole size should be multiple of block size.
5c64737d253683b Xiubo Li 2022-08-25 2498 *
5c64737d253683b Xiubo Li 2022-08-25 2499 * If the Rados object doesn't exist, it will be set to 0.
5c64737d253683b Xiubo Li 2022-08-25 2500 */
4a435e6fadf480f David Howells 2024-12-05 2501 if (ret != -ENODATA) {
38d46409c4639a1 Xiubo Li 2023-06-12 @2502 doutc(cl, "hit hole, ppos %lld < size %lld\n", pos, i_size);
5c64737d253683b Xiubo Li 2022-08-25 2503
3233a4eba55cbb6 David Howells 2023-08-03 2504 header->data_len = cpu_to_le32(8 + 8 + 4);
3233a4eba55cbb6 David Howells 2023-08-03 2505 header->file_offset = 0;
5c64737d253683b Xiubo Li 2022-08-25 2506 ret = 0;
5c64737d253683b Xiubo Li 2022-08-25 2507 } else {
3233a4eba55cbb6 David Howells 2023-08-03 2508 header->data_len = cpu_to_le32(8 + 8 + 4 + CEPH_FSCRYPT_BLOCK_SIZE);
3233a4eba55cbb6 David Howells 2023-08-03 2509 header->file_offset = cpu_to_le64(orig_pos);
5c64737d253683b Xiubo Li 2022-08-25 2510
38d46409c4639a1 Xiubo Li 2023-06-12 2511 doutc(cl, "encrypt block boff/bsize %d/%lu\n", boff,
38d46409c4639a1 Xiubo Li 2023-06-12 2512 CEPH_FSCRYPT_BLOCK_SIZE);
295fc4aa7de4b72 Xiubo Li 2023-03-06 2513
5c64737d253683b Xiubo Li 2022-08-25 2514 /* truncate and zero out the extra contents for the last block */
3233a4eba55cbb6 David Howells 2023-08-03 2515 p = kmap_local_bvecq(dbuf, 1);
3233a4eba55cbb6 David Howells 2023-08-03 2516 memset(p + boff, 0, PAGE_SIZE - boff);
3233a4eba55cbb6 David Howells 2023-08-03 2517 kunmap_local(p);
5c64737d253683b Xiubo Li 2022-08-25 2518
5c64737d253683b Xiubo Li 2022-08-25 2519 /* encrypt the last block */
3233a4eba55cbb6 David Howells 2023-08-03 2520 ret = ceph_fscrypt_encrypt_block_inplace(inode, dbuf->bv[0].bv_page,
5c64737d253683b Xiubo Li 2022-08-25 2521 CEPH_FSCRYPT_BLOCK_SIZE,
fa65058063cbaba Eric Biggers 2025-07-09 2522 0, block);
5c64737d253683b Xiubo Li 2022-08-25 2523 if (ret)
5c64737d253683b Xiubo Li 2022-08-25 2524 goto out;
5c64737d253683b Xiubo Li 2022-08-25 2525 }
5c64737d253683b Xiubo Li 2022-08-25 2526
3233a4eba55cbb6 David Howells 2023-08-03 2527 req->r_dbuf = dbuf;
3233a4eba55cbb6 David Howells 2023-08-03 2528 req->r_dbuf_len = sizeof(*header);
3233a4eba55cbb6 David Howells 2023-08-03 2529 if (header->block_size)
3233a4eba55cbb6 David Howells 2023-08-03 2530 req->r_dbuf_len += CEPH_FSCRYPT_BLOCK_SIZE;
5c64737d253683b Xiubo Li 2022-08-25 2531 out:
38d46409c4639a1 Xiubo Li 2023-06-12 2532 doutc(cl, "%p %llx.%llx size dropping cap refs on %s\n", inode,
38d46409c4639a1 Xiubo Li 2023-06-12 2533 ceph_vinop(inode), ceph_cap_string(got));
5c64737d253683b Xiubo Li 2022-08-25 2534 ceph_put_cap_refs(ci, got);
3233a4eba55cbb6 David Howells 2023-08-03 2535 kunmap_local(header);
3233a4eba55cbb6 David Howells 2023-08-03 2536 if (ret)
3233a4eba55cbb6 David Howells 2023-08-03 2537 bvecq_put(dbuf);
5c64737d253683b Xiubo Li 2022-08-25 2538 return ret;
5c64737d253683b Xiubo Li 2022-08-25 2539 }
5c64737d253683b Xiubo Li 2022-08-25 2540
:::::: The code at line 2502 was first introduced by commit
:::::: 38d46409c4639a1d659ebfa70e27a8bed6b8ee1d ceph: print cluster fsid and client global_id in all debug logs
:::::: TO: Xiubo Li <xiubli@redhat.com>
:::::: CC: Ilya Dryomov <idryomov@gmail.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-03 17:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-03 17:58 [dhowells-fs:ceph-iter 98/103] fs/ceph/inode.c:2502:50: warning: variable 'pos' is uninitialized when used here kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox