[mda-next:icssg-dev 1/8] include/linux/if_hsr.h:58:12: error: call to undeclared function 'skb_ext_find'; ISO C99 and later do not support implicit function declarations

[mda-next:icssg-dev 1/8] include/linux/if_hsr.h:58:12: error: call to undeclared function 'skb_ext_find'; ISO C99 and later do not support implicit function declarations

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mda/linux-next.git icssg-dev
head:   a5d36e904451db02a17787219fd06b6d2ba16f1b
commit: 756ed4bc4a527cdddc3f9f09240637ceb3408645 [1/8] hsr: Allow to send a specific port and with HSR header
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260505/202605050742.bDIpymJB-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260505/202605050742.bDIpymJB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605050742.bDIpymJB-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from net/dsa/dsa.c:12:
>> include/linux/if_hsr.h:58:12: error: call to undeclared function 'skb_ext_find'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                     ^
>> include/linux/if_hsr.h:58:30: error: use of undeclared identifier 'SKB_EXT_HSR'
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                                       ^
   include/linux/if_hsr.h:71:12: error: call to undeclared function 'skb_ext_find'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                     ^
   include/linux/if_hsr.h:71:30: error: use of undeclared identifier 'SKB_EXT_HSR'
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                                       ^
   include/linux/if_hsr.h:85:12: error: call to undeclared function 'skb_ext_find'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                     ^
   include/linux/if_hsr.h:85:30: error: use of undeclared identifier 'SKB_EXT_HSR'
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                                       ^
>> include/linux/if_hsr.h:99:12: error: call to undeclared function 'skb_ext_add'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
                     ^
   include/linux/if_hsr.h:99:29: error: use of undeclared identifier 'SKB_EXT_HSR'
           ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
                                      ^
   In file included from net/dsa/dsa.c:15:
   In file included from include/linux/netdevice.h:38:
   In file included from include/net/net_namespace.h:44:
>> include/linux/skbuff.h:5060:7: error: conflicting types for 'skb_ext_add'
   void *skb_ext_add(struct sk_buff *skb, enum skb_ext_id id);
         ^
   include/linux/if_hsr.h:99:12: note: previous implicit declaration is here
           ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
                     ^
   In file included from net/dsa/dsa.c:15:
   In file included from include/linux/netdevice.h:38:
   In file included from include/net/net_namespace.h:44:
>> include/linux/skbuff.h:5105:21: error: conflicting types for 'skb_ext_find'
   static inline void *skb_ext_find(const struct sk_buff *skb, enum skb_ext_id id)
                       ^
   include/linux/if_hsr.h:58:12: note: previous implicit declaration is here
           ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
                     ^
   10 errors generated.


vim +/skb_ext_find +58 include/linux/if_hsr.h

    45	
    46	#if IS_ENABLED(CONFIG_HSR)
    47	extern bool is_hsr_master(struct net_device *dev);
    48	extern int hsr_get_version(struct net_device *dev, enum hsr_version *ver);
    49	struct net_device *hsr_get_port_ndev(struct net_device *ndev,
    50					     enum hsr_port_type pt);
    51	int hsr_get_port_type(struct net_device *hsr_dev, struct net_device *dev,
    52			      enum hsr_port_type *type);
    53	
    54	static inline bool hsr_skb_has_header(struct sk_buff *skb)
    55	{
    56		struct hsr_ptp_ext *ptp_ext;
    57	
  > 58		ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
    59		if (!ptp_ext)
    60			return false;
    61		return ptp_ext->header;
    62	}
    63	
    64	static inline unsigned int hsr_skb_has_port(struct sk_buff *skb)
    65	{
    66		struct hsr_ptp_ext *ptp_ext;
    67	
    68		if (!skb)
    69			return 0;
    70	
    71		ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
    72		if (!ptp_ext)
    73			return 0;
    74		return ptp_ext->port;
    75	}
    76	
    77	static inline bool hsr_skb_get_header_port(struct sk_buff *skb, bool *header,
    78						   enum hsr_port_type *port_type)
    79	{
    80		struct hsr_ptp_ext *ptp_ext;
    81	
    82		*port_type = HSR_PT_NONE;
    83		*header = false;
    84	
    85		ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
    86		if (!ptp_ext)
    87			return false;
    88	
    89		*port_type = ptp_ext->port;
    90		*header = ptp_ext->header;
    91		return true;
    92	}
    93	
    94	static inline bool hsr_skb_add_header_port(struct sk_buff *skb, bool header,
    95						   enum hsr_port_type port)
    96	{
    97		struct hsr_ptp_ext *ptp_ext;
    98	
  > 99		ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
   100		if (!ptp_ext)
   101			return false;
   102		ptp_ext->port = port;
   103		ptp_ext->header = header;
   104		return true;
   105	}
   106	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki