Re: [PATCH net v2] ptp: ocp: fix resource freeing order

Re: [PATCH net v2] ptp: ocp: fix resource freeing order

[kernel test robot]

Hi Vadim,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/ptp-ocp-fix-resource-freeing-order/20260512-061754
base:   net/main
patch link:    https://lore.kernel.org/r/20260511161838.1413499-1-vadim.fedorenko%40linux.dev
patch subject: [PATCH net v2] ptp: ocp: fix resource freeing order
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260512/202605121813.ZVbOZfjr-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260512/202605121813.ZVbOZfjr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605121813.ZVbOZfjr-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/ptp/ptp_ocp.c:4872:39: error: expected ';' after expression
                   ptp_ocp_ts_enable(bp->ts1, 0, false)
                                                       ^
                                                       ;
   drivers/ptp/ptp_ocp.c:4874:39: error: expected ';' after expression
                   ptp_ocp_ts_enable(bp->ts2, 0, false)
                                                       ^
                                                       ;
   drivers/ptp/ptp_ocp.c:4876:39: error: expected ';' after expression
                   ptp_ocp_ts_enable(bp->ts3, 0, false)
                                                       ^
                                                       ;
   drivers/ptp/ptp_ocp.c:4878:39: error: expected ';' after expression
                   ptp_ocp_ts_enable(bp->ts4, 0, false)
                                                       ^
                                                       ;
   4 errors generated.


vim +4872 drivers/ptp/ptp_ocp.c

  4860	
  4861	static void
  4862	ptp_ocp_detach(struct ptp_ocp *bp)
  4863	{
  4864		int i;
  4865	
  4866		ptp_ocp_debugfs_remove_device(bp);
  4867		ptp_ocp_detach_sysfs(bp);
  4868		ptp_ocp_attr_group_del(bp);
  4869		timer_delete_sync(&bp->watchdog);
  4870		/* Disable interrupts on all timestampers */
  4871		if (bp->ts1)
> 4872			ptp_ocp_ts_enable(bp->ts1, 0, false)
  4873		if (bp->ts2)
  4874			ptp_ocp_ts_enable(bp->ts2, 0, false)
  4875		if (bp->ts3)
  4876			ptp_ocp_ts_enable(bp->ts3, 0, false)
  4877		if (bp->ts4)
  4878			ptp_ocp_ts_enable(bp->ts4, 0, false)
  4879		if (bp->ptp)
  4880			ptp_clock_unregister(bp->ptp);
  4881		kfree(bp->ptp_info.pin_config);
  4882		ptp_ocp_unregister_ext(bp->ts0);
  4883		ptp_ocp_unregister_ext(bp->ts1);
  4884		ptp_ocp_unregister_ext(bp->ts2);
  4885		ptp_ocp_unregister_ext(bp->ts3);
  4886		ptp_ocp_unregister_ext(bp->ts4);
  4887		ptp_ocp_unregister_ext(bp->pps);
  4888		for (i = 0; i < 4; i++)
  4889			ptp_ocp_unregister_ext(bp->signal_out[i]);
  4890		for (i = 0; i < __PORT_COUNT; i++)
  4891			if (bp->port[i].line != -1)
  4892				serial8250_unregister_port(bp->port[i].line);
  4893		platform_device_unregister(bp->spi_flash);
  4894		platform_device_unregister(bp->i2c_ctrl);
  4895		if (bp->i2c_clk)
  4896			clk_hw_unregister_fixed_rate(bp->i2c_clk);
  4897		if (bp->n_irqs)
  4898			pci_free_irq_vectors(bp->pdev);
  4899		device_unregister(&bp->dev);
  4900	}
  4901	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki