Re: [PATCH v3] drm/gem: Make the GEM LRU lock part of drm_device

Re: [PATCH v3] drm/gem: Make the GEM LRU lock part of drm_device

[kernel test robot]

Hi Boris,

kernel test robot noticed the following build warnings:

[auto build test WARNING on b2ed01e7ad3de80333e9b962a44024b094bc0b2b]

url:    https://github.com/intel-lab-lkp/linux/commits/Boris-Brezillon/drm-gem-Make-the-GEM-LRU-lock-part-of-drm_device/20260514-051749
base:   b2ed01e7ad3de80333e9b962a44024b094bc0b2b
patch link:    https://lore.kernel.org/r/20260512-panthor-shrinker-fixes-v3-1-3bf066259471%40collabora.com
patch subject: [PATCH v3] drm/gem: Make the GEM LRU lock part of drm_device
config: arm-randconfig-002-20260514 (https://download.01.org/0day-ci/archive/20260514/202605141138.kI3vechU-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260514/202605141138.kI3vechU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605141138.kI3vechU-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/msm/msm_gem.c:827:26: warning: unused variable 'priv' [-Wunused-variable]
     827 |         struct msm_drm_private *priv = obj->dev->dev_private;
         |                                 ^~~~
   1 warning generated.


vim +/priv +827 drivers/gpu/drm/msm/msm_gem.c

4cd33c48ea25ba1 Rob Clark             2016-05-17  823  
599089c6af68300 Rob Clark             2020-10-23  824  void msm_gem_purge(struct drm_gem_object *obj)
68209390f116034 Rob Clark             2016-05-17  825  {
68209390f116034 Rob Clark             2016-05-17  826  	struct drm_device *dev = obj->dev;
6c7c8fb863f7c31 Rob Clark             2023-03-20 @827  	struct msm_drm_private *priv = obj->dev->dev_private;
68209390f116034 Rob Clark             2016-05-17  828  	struct msm_gem_object *msm_obj = to_msm_bo(obj);
68209390f116034 Rob Clark             2016-05-17  829  
d4d7d3630d703ff Rob Clark             2022-08-02  830  	msm_gem_assert_locked(obj);
90643a24a7bfbe9 Rob Clark             2021-04-05  831  	GEM_WARN_ON(!is_purgeable(msm_obj));
68209390f116034 Rob Clark             2016-05-17  832  
20d0ae2f8c72e36 Rob Clark             2021-04-05  833  	/* Get rid of any iommu mapping(s): */
0b4339c55ef59ff Rob Clark             2025-06-29  834  	put_iova_spaces(obj, NULL, false, "purge");
0e08270a1f01bce Sushmita Susheelendra 2017-06-13  835  
599089c6af68300 Rob Clark             2020-10-23  836  	msm_gem_vunmap(obj);
68209390f116034 Rob Clark             2016-05-17  837  
81d4d597d4faadb Rob Clark             2021-04-05  838  	drm_vma_node_unmap(&obj->vma_node, dev->anon_inode->i_mapping);
81d4d597d4faadb Rob Clark             2021-04-05  839  
68209390f116034 Rob Clark             2016-05-17  840  	put_pages(obj);
68209390f116034 Rob Clark             2016-05-17  841  
c20ad1ee88c074c Boris Brezillon       2026-05-12  842  	mutex_lock(&dev->gem_lru_mutex);
6c7c8fb863f7c31 Rob Clark             2023-03-20  843  	/* A one-way transition: */
68209390f116034 Rob Clark             2016-05-17  844  	msm_obj->madv = __MSM_MADV_PURGED;
c20ad1ee88c074c Boris Brezillon       2026-05-12  845  	mutex_unlock(&dev->gem_lru_mutex);
68209390f116034 Rob Clark             2016-05-17  846  
68209390f116034 Rob Clark             2016-05-17  847  	drm_gem_free_mmap_offset(obj);
68209390f116034 Rob Clark             2016-05-17  848  
68209390f116034 Rob Clark             2016-05-17  849  	/* Our goal here is to return as much of the memory as
68209390f116034 Rob Clark             2016-05-17  850  	 * is possible back to the system as we are called from OOM.
68209390f116034 Rob Clark             2016-05-17  851  	 * To do this we must instruct the shmfs to drop all of its
68209390f116034 Rob Clark             2016-05-17  852  	 * backing pages, *now*.
68209390f116034 Rob Clark             2016-05-17  853  	 */
68209390f116034 Rob Clark             2016-05-17  854  	shmem_truncate_range(file_inode(obj->filp), 0, (loff_t)-1);
68209390f116034 Rob Clark             2016-05-17  855  
68209390f116034 Rob Clark             2016-05-17  856  	invalidate_mapping_pages(file_inode(obj->filp)->i_mapping,
68209390f116034 Rob Clark             2016-05-17  857  			0, (loff_t)-1);
68209390f116034 Rob Clark             2016-05-17  858  }
68209390f116034 Rob Clark             2016-05-17  859  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki