* Re: [PATCH] gpib: cb7210: Fix region leak when request_irq fails
[not found] <20260515073952.54359-1-zenghongling@kylinos.cn>
@ 2026-05-15 22:23 ` kernel test robot
2026-05-18 2:24 ` Hongling Zeng
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-05-15 22:23 UTC (permalink / raw)
To: Hongling Zeng, dpenkler, gregkh, dominik.karol.piatkowski,
adam.quandour, kees
Cc: llvm, oe-kbuild-all, linux-kernel, zhongling0719, Hongling Zeng
Hi Hongling,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v7.1-rc3 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hongling-Zeng/gpib-cb7210-Fix-region-leak-when-request_irq-fails/20260515-222229
base: linus/master
patch link: https://lore.kernel.org/r/20260515073952.54359-1-zenghongling%40kylinos.cn
patch subject: [PATCH] gpib: cb7210: Fix region leak when request_irq fails
config: x86_64-randconfig-076-20260516 (https://download.01.org/0day-ci/archive/20260516/202605160620.ReBOadPX-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260516/202605160620.ReBOadPX-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605160620.ReBOadPX-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/gpib/cb7210/cb7210.c:1066:3: error: use of undeclared identifier 'ret'
1066 | ret = -EBUSY;
| ^
1 error generated.
vim +/ret +1066 drivers/gpib/cb7210/cb7210.c
1035
1036 static int cb_isa_attach(struct gpib_board *board, const struct gpib_board_config *config)
1037 {
1038 int isr_flags = 0;
1039 struct cb7210_priv *cb_priv;
1040 struct nec7210_priv *nec_priv;
1041 unsigned int bits;
1042 int retval;
1043
1044 retval = cb7210_generic_attach(board);
1045 if (retval)
1046 return retval;
1047 cb_priv = board->private_data;
1048 nec_priv = &cb_priv->nec7210_priv;
1049 if (!request_region(config->ibbase, cb7210_iosize, DRV_NAME)) {
1050 dev_err(board->gpib_dev, "ioports starting at 0x%x are already in use\n",
1051 config->ibbase);
1052 retval = -EBUSY;
1053 goto err_release_region;
1054 }
1055 nec_priv->iobase = config->ibbase;
1056 cb_priv->fifo_iobase = nec7210_iobase(cb_priv);
1057
1058 bits = irq_bits(config->ibirq);
1059 if (bits == 0)
1060 dev_err(board->gpib_dev, "board incapable of using irq %i, try 2-5, 7, 10, or 11\n",
1061 config->ibirq);
1062
1063 // install interrupt handler
1064 if (request_irq(config->ibirq, cb7210_interrupt, isr_flags, DRV_NAME, board)) {
1065 dev_err(board->gpib_dev, "failed to obtain IRQ %d\n", config->ibirq);
> 1066 ret = -EBUSY;
1067 goto err_release_region;
1068 }
1069 cb_priv->irq = config->ibirq;
1070
1071 return cb7210_init(cb_priv, board);
1072
1073 err_release_region:
1074 release_region(nec7210_iobase(cb_priv), cb7210_iosize);
1075 return retval;
1076 }
1077
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpib: cb7210: Fix region leak when request_irq fails
2026-05-15 22:23 ` [PATCH] gpib: cb7210: Fix region leak when request_irq fails kernel test robot
@ 2026-05-18 2:24 ` Hongling Zeng
0 siblings, 0 replies; 2+ messages in thread
From: Hongling Zeng @ 2026-05-18 2:24 UTC (permalink / raw)
To: kernel test robot, Hongling Zeng, dpenkler, gregkh,
dominik.karol.piatkowski, adam.quandour, kees
Cc: llvm, oe-kbuild-all, linux-kernel
Hi,
Thanks for the report. The issue is a typo where I used 'ret' instead of
'retval'. I'll fix this in v2 and add the appropriate tags.
Best regards,
Hongling
在 2026年05月16日 06:23, kernel test robot 写道:
> Hi Hongling,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v7.1-rc3 next-20260508]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Hongling-Zeng/gpib-cb7210-Fix-region-leak-when-request_irq-fails/20260515-222229
> base: linus/master
> patch link: https://lore.kernel.org/r/20260515073952.54359-1-zenghongling%40kylinos.cn
> patch subject: [PATCH] gpib: cb7210: Fix region leak when request_irq fails
> config: x86_64-randconfig-076-20260516 (https://download.01.org/0day-ci/archive/20260516/202605160620.ReBOadPX-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260516/202605160620.ReBOadPX-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202605160620.ReBOadPX-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> drivers/gpib/cb7210/cb7210.c:1066:3: error: use of undeclared identifier 'ret'
> 1066 | ret = -EBUSY;
> | ^
> 1 error generated.
>
>
> vim +/ret +1066 drivers/gpib/cb7210/cb7210.c
>
> 1035
> 1036 static int cb_isa_attach(struct gpib_board *board, const struct gpib_board_config *config)
> 1037 {
> 1038 int isr_flags = 0;
> 1039 struct cb7210_priv *cb_priv;
> 1040 struct nec7210_priv *nec_priv;
> 1041 unsigned int bits;
> 1042 int retval;
> 1043
> 1044 retval = cb7210_generic_attach(board);
> 1045 if (retval)
> 1046 return retval;
> 1047 cb_priv = board->private_data;
> 1048 nec_priv = &cb_priv->nec7210_priv;
> 1049 if (!request_region(config->ibbase, cb7210_iosize, DRV_NAME)) {
> 1050 dev_err(board->gpib_dev, "ioports starting at 0x%x are already in use\n",
> 1051 config->ibbase);
> 1052 retval = -EBUSY;
> 1053 goto err_release_region;
> 1054 }
> 1055 nec_priv->iobase = config->ibbase;
> 1056 cb_priv->fifo_iobase = nec7210_iobase(cb_priv);
> 1057
> 1058 bits = irq_bits(config->ibirq);
> 1059 if (bits == 0)
> 1060 dev_err(board->gpib_dev, "board incapable of using irq %i, try 2-5, 7, 10, or 11\n",
> 1061 config->ibirq);
> 1062
> 1063 // install interrupt handler
> 1064 if (request_irq(config->ibirq, cb7210_interrupt, isr_flags, DRV_NAME, board)) {
> 1065 dev_err(board->gpib_dev, "failed to obtain IRQ %d\n", config->ibirq);
>> 1066 ret = -EBUSY;
> 1067 goto err_release_region;
> 1068 }
> 1069 cb_priv->irq = config->ibirq;
> 1070
> 1071 return cb7210_init(cb_priv, board);
> 1072
> 1073 err_release_region:
> 1074 release_region(nec7210_iobase(cb_priv), cb7210_iosize);
> 1075 return retval;
> 1076 }
> 1077
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-18 2:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260515073952.54359-1-zenghongling@kylinos.cn>
2026-05-15 22:23 ` [PATCH] gpib: cb7210: Fix region leak when request_irq fails kernel test robot
2026-05-18 2:24 ` Hongling Zeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox