Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl

Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl

[kernel test robot]

Hi shayderrr,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on staging/staging-next staging/staging-linus linus/master v7.1-rc3 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/shayderrr/net-octeon-fix-carrier-state-null-guard-and-modernize-phy-ioctl/20260517-222121
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260517141955.79666-1-darknessshayder%40gmail.com
patch subject: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260518/202605180508.53ptUezJ-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260518/202605180508.53ptUezJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605180508.53ptUezJ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/octeon/ethernet-mdio.c:91:6: error: conflicting types for 'cvm_oct_common_stop'
      91 | void cvm_oct_common_stop(struct net_device *dev)
         |      ^
   drivers/staging/octeon/octeon-ethernet.h:90:5: note: previous declaration is here
      90 | int cvm_oct_common_stop(struct net_device *dev);
         |     ^
   1 error generated.


vim +/cvm_oct_common_stop +91 drivers/staging/octeon/ethernet-mdio.c

    90	
  > 91	void cvm_oct_common_stop(struct net_device *dev)
    92	{
    93		struct octeon_ethernet *priv = netdev_priv(dev);
    94		int interface = INTERFACE(priv->port);
    95		int index = INDEX(priv->port);
    96		union cvmx_helper_link_info link_info;
    97		union cvmx_gmxx_prtx_cfg gmx_cfg;
    98	
    99		gmx_cfg.u64 = cvmx_read_csr(CVMX_GMXX_PRTX_CFG(index, interface));
   100		gmx_cfg.s.en = 0;
   101		cvmx_write_csr(CVMX_GMXX_PRTX_CFG(index, interface), gmx_cfg.u64);
   102	
   103		priv->poll = NULL;
   104	
   105		netif_carrier_off(dev);
   106	
   107		if (dev->phydev)
   108			phy_disconnect(dev->phydev);
   109	
   110		if (priv->last_link) {
   111			link_info.u64	= 0;
   112			priv->link_info	= 0;
   113			priv->last_link	= 0;
   114	
   115			cvmx_helper_link_set(priv->port, link_info);
   116			cvm_oct_note_carrier(priv, link_info);
   117		}
   118	}
   119	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki