Re: [PATCH nf] netfilter: flowtable: tear down HW offloaded flows on FIB route changes

Re: [PATCH nf] netfilter: flowtable: tear down HW offloaded flows on FIB route changes

[kernel test robot]

Hi Ahmed,

kernel test robot noticed the following build warnings:

[auto build test WARNING on netfilter-nf/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Ahmed-Zaki/netfilter-flowtable-tear-down-HW-offloaded-flows-on-FIB-route-changes/20260709-050000
base:   https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main
patch link:    https://lore.kernel.org/r/20260708205404.911832-1-anzaki%40gmail.com
patch subject: [PATCH nf] netfilter: flowtable: tear down HW offloaded flows on FIB route changes
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260709/202607091427.MRtlNy5G-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project b3e6e6dabdc02153552a64fc74ff5c7532447eed)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260709/202607091427.MRtlNy5G-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607091427.MRtlNy5G-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_flow_table_core.c:833:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     833 |                 struct fib_entry_notifier_info *fen;
         |                 ^
   net/netfilter/nf_flow_table_core.c:843:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     843 |                 struct fib6_entry_notifier_info *fen6;
         |                 ^
   2 warnings generated.


vim +833 net/netfilter/nf_flow_table_core.c

   804	
   805	/* Called with rcu_read_lock() */
   806	static int nf_flow_table_fib_event(struct notifier_block *nb,
   807					   unsigned long event, void *ptr)
   808	{
   809		struct nf_flowtable *flow_table =
   810			container_of(nb, struct nf_flowtable, fib_nb);
   811		struct fib_notifier_info *info = ptr;
   812		struct nf_flow_fib_event *ev;
   813	
   814		switch (event) {
   815		case FIB_EVENT_ENTRY_REPLACE:
   816		case FIB_EVENT_ENTRY_APPEND:
   817		case FIB_EVENT_ENTRY_DEL:
   818			break;
   819		default:
   820			return NOTIFY_DONE;
   821		}
   822	
   823		/* Skip events for an address family this table cannot hold. */
   824		if (!nf_flowtable_fib_family_match(flow_table, info->family))
   825			return NOTIFY_DONE;
   826	
   827		ev = kzalloc(sizeof(*ev), GFP_ATOMIC);
   828		if (!ev)
   829			return NOTIFY_DONE;
   830	
   831		switch (info->family) {
   832		case NFPROTO_IPV4:
 > 833			struct fib_entry_notifier_info *fen;
   834	
   835			fen = container_of(info, struct fib_entry_notifier_info, info);
   836			ev->family     = NFPROTO_IPV4;
   837			ev->addr.ip4   = htonl(fen->dst);
   838			ev->prefix_len = fen->dst_len;
   839			break;
   840	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki