* Re: [PATCH] mailbox: sun6i: modernize probe and convert to fully managed
[not found] <20260727194208.10082-1-rosenp@gmail.com>
@ 2026-08-07 19:44 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-08-07 19:44 UTC (permalink / raw)
To: Rosen Penev, linux-sunxi
Cc: llvm, oe-kbuild-all, Jassi Brar, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, linux-kernel, linux-arm-kernel
Hi Rosen,
kernel test robot noticed the following build errors:
[auto build test ERROR on sunxi/sunxi/for-next]
[also build test ERROR on linus/master v7.2-rc6 next-20260806]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/mailbox-sun6i-modernize-probe-and-convert-to-fully-managed/20260807-054041
base: https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next
patch link: https://lore.kernel.org/r/20260727194208.10082-1-rosenp%40gmail.com
patch subject: [PATCH] mailbox: sun6i: modernize probe and convert to fully managed
config: arm64-randconfig-001-20260807 (https://download.01.org/0day-ci/archive/20260808/202608080303.ryiYJhRA-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 12df34b8469b8095359de8c249cb1b2753fadeea)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260808/202608080303.ryiYJhRA-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608080303.ryiYJhRA-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/mailbox/sun6i-msgbox.c:271:56: error: too few arguments to function call, expected 2, have 1
271 | return devm_mbox_controller_register(&mbox->controller);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
include/linux/mailbox_controller.h:149:5: note: 'devm_mbox_controller_register' declared here
149 | int devm_mbox_controller_register(struct device *dev,
| ^ ~~~~~~~~~~~~~~~~~~~
150 | struct mbox_controller *mbox);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
vim +271 drivers/mailbox/sun6i-msgbox.c
194
195 static int sun6i_msgbox_probe(struct platform_device *pdev)
196 {
197 struct device *dev = &pdev->dev;
198 struct mbox_chan *chans;
199 struct reset_control *reset;
200 struct sun6i_msgbox *mbox;
201 void __iomem *regs;
202 int i, ret;
203 int irq;
204
205 irq = platform_get_irq(pdev, 0);
206 if (irq < 0)
207 return irq;
208
209 regs = devm_platform_ioremap_resource(pdev, 0);
210 if (IS_ERR(regs))
211 return PTR_ERR(regs);
212
213 mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
214 if (!mbox)
215 return -ENOMEM;
216
217 chans = devm_kcalloc(dev, NUM_CHANS, sizeof(*chans), GFP_KERNEL);
218 if (!chans)
219 return -ENOMEM;
220
221 for (i = 0; i < NUM_CHANS; ++i)
222 chans[i].con_priv = mbox;
223
224 mbox->clk = devm_clk_get_enabled(dev, NULL);
225 if (IS_ERR(mbox->clk)) {
226 ret = PTR_ERR(mbox->clk);
227 dev_err(dev, "Failed to get clock: %d\n", ret);
228 return ret;
229 }
230
231 reset = devm_reset_control_get_exclusive(dev, NULL);
232 if (IS_ERR(reset)) {
233 ret = PTR_ERR(reset);
234 dev_err(dev, "Failed to get reset control: %d\n", ret);
235 return ret;
236 }
237
238 /*
239 * NOTE: We rely on platform firmware to preconfigure the channel
240 * directions, and we share this hardware block with other firmware
241 * that runs concurrently with Linux (e.g. a trusted monitor).
242 *
243 * Therefore, we do *not* assert the reset line if probing fails or
244 * when removing the device.
245 */
246 ret = reset_control_deassert(reset);
247 if (ret) {
248 dev_err(dev, "Failed to deassert reset: %d\n", ret);
249 return ret;
250 }
251
252 mbox->regs = regs;
253
254 /* Disable all IRQs for this end of the msgbox. */
255 writel(0, mbox->regs + LOCAL_IRQ_EN_REG);
256
257 ret = devm_request_irq(dev, irq, sun6i_msgbox_irq, 0, dev_name(dev), mbox);
258 if (ret)
259 return ret;
260
261 mbox->controller.dev = dev;
262 mbox->controller.ops = &sun6i_msgbox_chan_ops;
263 mbox->controller.chans = chans;
264 mbox->controller.num_chans = NUM_CHANS;
265 mbox->controller.txdone_irq = false;
266 mbox->controller.txdone_poll = true;
267 mbox->controller.txpoll_period = 5;
268
269 spin_lock_init(&mbox->lock);
270
> 271 return devm_mbox_controller_register(&mbox->controller);
272 }
273
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread