Re: [PATCH v3] dmaengine: dw-axi-dmac: convert to clk bulk APIs

Re: [PATCH v3] dmaengine: dw-axi-dmac: convert to clk bulk APIs

[kernel test robot]

Hi Li,

kernel test robot noticed the following build warnings:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on linus/master v7.3-rc1 next-20260902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Youhong/dmaengine-dw-axi-dmac-convert-to-clk-bulk-APIs/20260902-093016
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link:    https://lore.kernel.org/r/20260902013016.3381788-1-dayou5941%40163.com
patch subject: [PATCH v3] dmaengine: dw-axi-dmac: convert to clk bulk APIs
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260903/202609030325.ALAaghFW-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project ed1626b9d0eaf7c406f44da5fb595ad94559f54b)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260903/202609030325.ALAaghFW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609030325.ALAaghFW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1638:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
    1638 |         clk_bulk_prepare_enable(DW_AXI_DMA_MAX_CLKS, chip->clks);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +/warn_unused_result +1638 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

  1629	
  1630	static void dw_remove(struct platform_device *pdev)
  1631	{
  1632		struct axi_dma_chip *chip = platform_get_drvdata(pdev);
  1633		struct dw_axi_dma *dw = chip->dw;
  1634		struct axi_dma_chan *chan, *_chan;
  1635		u32 i;
  1636	
  1637		/* Enable clk before accessing to registers */
> 1638		clk_bulk_prepare_enable(DW_AXI_DMA_MAX_CLKS, chip->clks);
  1639		axi_dma_irq_disable(chip);
  1640		for (i = 0; i < dw->hdata->nr_channels; i++) {
  1641			axi_chan_disable(&chip->dw->chan[i]);
  1642			axi_chan_irq_disable(&chip->dw->chan[i], DWAXIDMAC_IRQ_ALL);
  1643		}
  1644		axi_dma_disable(chip);
  1645	
  1646		pm_runtime_disable(chip->dev);
  1647		axi_dma_suspend(chip);
  1648	
  1649		for (i = 0; i < DMAC_MAX_CHANNELS; i++)
  1650			if (chip->irq[i] > 0)
  1651				devm_free_irq(chip->dev, chip->irq[i], chip);
  1652	
  1653		of_dma_controller_free(chip->dev->of_node);
  1654	
  1655		list_for_each_entry_safe(chan, _chan, &dw->dma.channels,
  1656					 vc.chan.device_node) {
  1657			list_del(&chan->vc.chan.device_node);
  1658			tasklet_kill(&chan->vc.task);
  1659		}
  1660	}
  1661	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki