* Re: [PATCH rtw-next] wifi: rtw88: usb: Download the reserved page synchronously
[not found] <fd7bbc79-03f9-4932-ada8-f555392d4485@gmail.com>
@ 2026-09-04 22:09 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-09-04 22:09 UTC (permalink / raw)
To: Bitterblue Smith, linux-wireless@vger.kernel.org
Cc: llvm, oe-kbuild-all, Ping-Ke Shih, i.mafifi17
Hi Bitterblue,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master v7.3-rc1 next-20260903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bitterblue-Smith/wifi-rtw88-usb-Download-the-reserved-page-synchronously/20260904-002447
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/fd7bbc79-03f9-4932-ada8-f555392d4485%40gmail.com
patch subject: [PATCH rtw-next] wifi: rtw88: usb: Download the reserved page synchronously
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260905/202609050523.VXiKq456-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 0edd1b088cc36b4faee80358c925a91e16006258)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260905/202609050523.VXiKq456-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609050523.VXiKq456-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw88/usb.c:623:41: error: incompatible pointer types passing 'struct rtw_tx_desc *' to parameter of type 'struct sk_buff *' [-Wincompatible-pointer-types]
623 | rtw_tx_fill_tx_desc(rtwdev, &pkt_info, pkt_desc);
| ^~~~~~~~
drivers/net/wireless/realtek/rtw88/tx.h:99:55: note: passing argument to parameter 'skb' here
99 | struct rtw_tx_pkt_info *pkt_info, struct sk_buff *skb);
| ^
>> drivers/net/wireless/realtek/rtw88/usb.c:624:49: error: incompatible pointer types passing 'struct rtw_tx_desc *' to parameter of type 'u8 *' (aka 'unsigned char *') [-Wincompatible-pointer-types]
624 | rtw_tx_fill_txdesc_checksum(rtwdev, &pkt_info, pkt_desc);
| ^~~~~~~~
drivers/net/wireless/realtek/rtw88/tx.h:136:17: note: passing argument to parameter 'txdesc' here
136 | u8 *txdesc)
| ^
2 errors generated.
vim +623 drivers/net/wireless/realtek/rtw88/usb.c
600
601 static int rtw_usb_write_data_rsvd_page(struct rtw_dev *rtwdev, u8 *buf,
602 u32 size)
603 {
604 const struct rtw_chip_info *chip = rtwdev->chip;
605 struct rtw_tx_pkt_info pkt_info = {0};
606 struct rtw_tx_desc *pkt_desc;
607 struct sk_buff *skb;
608 int ret;
609
610 pkt_info.tx_pkt_size = size;
611 pkt_info.qsel = TX_DESC_QSEL_BEACON;
612 pkt_info.offset = chip->tx_pkt_desc_sz;
613 pkt_info.ls = true;
614
615 skb = dev_alloc_skb(chip->tx_pkt_desc_sz + size);
616 if (!skb)
617 return -ENOMEM;
618
619 skb_reserve(skb, chip->tx_pkt_desc_sz);
620 skb_put_data(skb, buf, size);
621 pkt_desc = skb_push(skb, chip->tx_pkt_desc_sz);
622 memset(pkt_desc, 0, chip->tx_pkt_desc_sz);
> 623 rtw_tx_fill_tx_desc(rtwdev, &pkt_info, pkt_desc);
> 624 rtw_tx_fill_txdesc_checksum(rtwdev, &pkt_info, pkt_desc);
625
626 /* Download the beacon/reserved page synchronously so that the caller's
627 * subsequent BCN_VALID poll observes the completed transfer instead of
628 * racing the async TX path.
629 */
630 ret = rtw_usb_write_port_sync(rtwdev, pkt_info.qsel, skb);
631 if (ret)
632 rtw_err(rtwdev, "failed to download rsvd page over USB, ret=%d\n",
633 ret);
634
635 dev_kfree_skb_any(skb);
636
637 return ret;
638 }
639
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread