[broonie-ci:for-7.4 5/19] sound/soc/codecs/es9356.c:1125:3: warning: add explicit braces to avoid dangling else

[broonie-ci:for-7.4 5/19] sound/soc/codecs/es9356.c:1125:3: warning: add explicit braces to avoid dangling else

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git for-7.4
head:   50a0a41c67978e9d89646038eb08c587635cb9be
commit: 31a7178425356d459bf7397941a3fbeff1782122 [5/19] ASoC: es9356: Publish IRQ readiness after cache replay
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260917/202609172335.MVp6jjO5-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
rustc: rustc 1.96.0 (ac68faa20 2026-05-25)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260917/202609172335.MVp6jjO5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609172335.MVp6jjO5-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/es9356.c:1125:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
    1125 |                 scoped_guard(mutex, &es9356->disable_irq_lock)
         |                 ^
   include/linux/cleanup.h:451:2: note: expanded from macro 'scoped_guard'
     451 |         __scoped_guard(_name, __UNIQUE_ID(label), args)
         |         ^
   include/linux/cleanup.h:448:5: note: expanded from macro '__scoped_guard'
     448 |                 } else
         |                   ^
   1 warning generated.


vim +1125 sound/soc/codecs/es9356.c

  1103	
  1104	static int es9356_sdca_dev_resume(struct device *dev)
  1105	{
  1106		struct sdw_slave *slave = dev_to_sdw_dev(dev);
  1107		struct es9356_sdw_priv *es9356 = dev_get_drvdata(dev);
  1108		int ret;
  1109	
  1110		ret = sdw_slave_wait_for_init(slave, es9356_PROBE_TIMEOUT);
  1111		if (ret) {
  1112			sdw_show_ping_status(slave->bus, true);
  1113			return ret;
  1114		}
  1115	
  1116		regcache_cache_only(es9356->regmap, false);
  1117		ret = regcache_sync(es9356->regmap);
  1118		if (ret) {
  1119			regcache_cache_only(es9356->regmap, true);
  1120			regcache_mark_dirty(es9356->regmap);
  1121			return ret;
  1122		}
  1123	
  1124		if (!slave->unattach_request)
> 1125			scoped_guard(mutex, &es9356->disable_irq_lock)
  1126				es9356->disable_irq = false;
  1127		return 0;
  1128	}
  1129	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki