* Re: [PATCH 1/1] x86/tboot: Add support for parsing DTPR table and disabling TPRs
[not found] <20260917094133.765149-1-michal.camacho.romero@linux.intel.com>
@ 2026-09-18 6:45 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-09-18 6:45 UTC (permalink / raw)
To: Michal Camacho Romero, Ning Sun
Cc: llvm, oe-kbuild-all, Baolu Lu, Thomas Gleixner,
Michal Camacho Romero, x86, iommu, tboot-devel, linux-kernel,
Mateusz Mowka, Adam Pawlicki, Pawel Randzio
Hi Michal,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on tip/master linus/master v7.3-rc3 next-20260916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Camacho-Romero/x86-tboot-Add-support-for-parsing-DTPR-table-and-disabling-TPRs/20260917-114133
base: tip/x86/core
patch link: https://lore.kernel.org/r/20260917094133.765149-1-michal.camacho.romero%40linux.intel.com
patch subject: [PATCH 1/1] x86/tboot: Add support for parsing DTPR table and disabling TPRs
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260918/202609181428.YizH4EcD-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
rustc: rustc 1.96.0 (ac68faa20 2026-05-25)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260918/202609181428.YizH4EcD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609181428.YizH4EcD-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
arch/x86/kernel/tboot.c:255:9: warning: unused variable 'j' [-Wunused-variable]
255 | u32 i, j, ref_tpr_cnt;
| ^
>> arch/x86/kernel/tboot.c:583:8: error: redefinition of 'heap_ext_data_elt'
583 | struct heap_ext_data_elt {
| ^
include/linux/tboot.h:68:8: note: previous definition is here
68 | struct heap_ext_data_elt {
| ^
>> arch/x86/kernel/tboot.c:758:15: warning: comparison of distinct pointer types ('struct heap_ext_data_elt *' and 'void *') [-Wcompare-distinct-pointer-types]
758 | } while (elt <= sinit_mle_end);
| ~~~ ^ ~~~~~~~~~~~~~
arch/x86/kernel/tboot.c:760:10: warning: comparison of distinct pointer types ('struct heap_ext_data_elt *' and 'void *') [-Wcompare-distinct-pointer-types]
760 | if (elt >= sinit_mle_end){
| ~~~ ^ ~~~~~~~~~~~~~
>> arch/x86/kernel/tboot.c:778:60: error: no member named 'data' in 'struct heap_ext_data_elt'
778 | if (!tboot_check_dtpr_size((struct acpi_table_dtpr *)elt->data,
| ~~~ ^
arch/x86/kernel/tboot.c:784:40: error: no member named 'data' in 'struct heap_ext_data_elt'
784 | return (struct acpi_table_dtpr *)elt->data;
| ~~~ ^
arch/x86/kernel/tboot.c:800:6: warning: variable 'ref_tpr_cnt' set but not used [-Wunused-but-set-variable]
800 | u32 ref_tpr_cnt;
| ^
4 warnings and 3 errors generated.
vim +/heap_ext_data_elt +583 arch/x86/kernel/tboot.c
582
> 583 struct heap_ext_data_elt {
584 u32 type;
585 u32 size;
586 u8 data[];
587 } __packed;
588
589 struct sinit_mle_data {
590 u32 version; /* currently 9 */
591 struct sha1_hash bios_acm_id;
592 u32 edx_senter_flags;
593 u64 mseg_valid;
594 struct sha1_hash sinit_hash;
595 struct sha1_hash mle_hash;
596 struct sha1_hash stm_hash;
597 struct sha1_hash lcp_policy_hash;
598 u32 lcp_policy_control;
599 u32 rlp_wakeup_addr;
600 u32 reserved;
601 u32 num_mdrs;
602 u32 mdrs_off;
603 u32 num_vtd_dmars;
604 u32 vtd_dmars_off;
605 u32 proc_scrtm_status; /* version 8 or later only*/
606 struct heap_ext_data_elt ext_data_elts[];
607 } __packed;
608
609 struct acpi_table_header *tboot_get_dmar_table(struct acpi_table_header *dmar_tbl)
610 {
611 void *heap_base, *heap_ptr, *config;
612
613 if (!tboot_enabled())
614 return dmar_tbl;
615
616 /*
617 * ACPI tables may not be DMA protected by tboot, so use DMAR copy
618 * SINIT saved in SinitMleData in TXT heap (which is DMA protected)
619 */
620
621 /* map config space in order to get heap addr */
622 config = ioremap(TXT_PUB_CONFIG_REGS_BASE, NR_TXT_CONFIG_PAGES *
623 PAGE_SIZE);
624 if (!config)
625 return NULL;
626
627 /* now map TXT heap */
628 heap_base = ioremap(*(u64 *)(config + TXTCR_HEAP_BASE),
629 *(u64 *)(config + TXTCR_HEAP_SIZE));
630 iounmap(config);
631 if (!heap_base)
632 return NULL;
633
634 /* walk heap to SinitMleData */
635 /* skip BiosData */
636 heap_ptr = heap_base + *(u64 *)heap_base;
637 /* skip OsMleData */
638 heap_ptr += *(u64 *)heap_ptr;
639 /* skip OsSinitData */
640 heap_ptr += *(u64 *)heap_ptr;
641 /* now points to SinitMleDataSize; set to SinitMleData */
642 heap_ptr += sizeof(u64);
643 /* get addr of DMAR table */
644 dmar_tbl = (struct acpi_table_header *)(heap_ptr +
645 ((struct sinit_mle_data *)heap_ptr)->vtd_dmars_off -
646 sizeof(u64));
647
648 /* don't unmap heap because dmar.c needs access to this */
649
650 return dmar_tbl;
651 }
652
653 struct acpi_table_dtpr *tboot_get_dtpr_table(void **heap_base)
654 {
655 void *heap_ptr, *config, *sinit_mle_end;
656 struct sinit_mle_data *sinit_mle;
657 struct heap_ext_data_elt *elt;
658 u64 heap_end, heap_size, sinit_mle_size, heap_section_size;
659
660 if (!heap_base)
661 return NULL;
662
663 if (!tboot_enabled())
664 return NULL;
665 /*
666 * ACPI tables may not be DMA protected by tboot, so use DMAR copy
667 * SINIT saved in SinitMleData in TXT heap (which is DMA protected)
668 */
669
670 /* map config space in order to get heap addr */
671 config = ioremap(TXT_PUB_CONFIG_REGS_BASE, NR_TXT_CONFIG_PAGES *
672 PAGE_SIZE);
673 if (!config)
674 return NULL;
675
676 /* now map TXT heap */
677 *heap_base = ioremap(*(u64 *)(config + TXTCR_HEAP_BASE),
678 *(u64 *)(config + TXTCR_HEAP_SIZE));
679 heap_size = *(u64 *)(config + TXTCR_HEAP_SIZE);
680 heap_end = (u64)*heap_base + heap_size;
681 iounmap(config);
682
683 if (!(*heap_base))
684 return NULL;
685
686 /* walk heap to SinitMleData */
687 /* skip BiosData */
688 /* get BiosData section size */
689 heap_section_size = *(u64 *) (*heap_base);
690 if (!tboot_check_txt_heap_section_bounds(heap_end, heap_base, *heap_base,
691 heap_section_size, "BiosData")) {
692 return NULL;
693 }
694
695 /* skip OsMleData */
696 heap_ptr = *heap_base + heap_section_size;
697 /* get OsMleData section size */
698 heap_section_size = *(u64 *)heap_ptr;
699 if (!tboot_check_txt_heap_section_bounds(heap_end, heap_base, heap_ptr,
700 heap_section_size, "OsMleData")) {
701 return NULL;
702 }
703
704 /* skip OsSinitData */
705 heap_ptr += heap_section_size;
706 /* get OsSinitData section size */
707 heap_section_size = *(u64 *)heap_ptr;
708 if (!tboot_check_txt_heap_section_bounds(heap_end, heap_base, heap_ptr,
709 heap_section_size, "OsSinitData")) {
710 return NULL;
711 }
712
713 /* jump to the SinitMleData */
714 heap_ptr += heap_section_size;
715 /* now points to SinitMleDataSize; set to SinitMleData */
716 sinit_mle_size = *(u64 *)heap_ptr;
717 if(!tboot_check_txt_heap_section_bounds(heap_end, heap_base, heap_ptr,
718 sinit_mle_size, "SinitMleData")) {
719 return NULL;
720 }
721
722 heap_ptr += sizeof(u64);
723 sinit_mle = (struct sinit_mle_data *)heap_ptr;
724 sinit_mle_end = (void *)sinit_mle + sinit_mle_size;
725 if (sizeof(struct sinit_mle_data) > sinit_mle_size) {
726 pr_err("SinitMleData size is smaller than expected.\n");
727 goto err;
728 }
729
730 if (sinit_mle->version < 9) {
731 pr_err("Unsupported SinitMleData version: %u\n", sinit_mle->version);
732 goto err;
733 }
734
735 heap_ptr += sizeof(struct sinit_mle_data);
736 if (heap_ptr > sinit_mle_end) {
737 pr_err("SinitMleData header out of bounds.\n");
738 goto err;
739 }
740
741 elt = sinit_mle->ext_data_elts;
742 do {
743 if ((u8 *)elt + sizeof(*elt) > (u8 *)sinit_mle_end) {
744 pr_err("SinitMleData element header out of bounds.\n");
745 goto err;
746 }
747
748 if (elt->size < sizeof(*elt)) {
749 pr_err("Invalid SinitMleData element size: %u\n", elt->size);
750 goto err;
751 }
752
753 if (elt->type == HEAP_EXTDATA_TYPE_END || elt->type == HEAP_EXTDATA_TYPE_DTPR) {
754 break;
755 }
756
757 elt = (void *)elt + elt->size;
> 758 } while (elt <= sinit_mle_end);
759
760 if (elt >= sinit_mle_end){
761 pr_err("Reached the end of SinitMleData without finding DTPR nor END"
762 " element.\n");
763 goto err;
764 }
765
766 if (elt->type == HEAP_EXTDATA_TYPE_END) {
767 pr_err("DTPR element not found in SinitMleData\n");
768 iounmap(*heap_base);
769 *heap_base = NULL;
770 return NULL;
771 }
772
773 if ((u8 *)elt + elt->size > (u8 *)sinit_mle_end) {
774 pr_err("DTPR Table exceeds SinitMleData bounds.\n");
775 goto err;
776 }
777
> 778 if (!tboot_check_dtpr_size((struct acpi_table_dtpr *)elt->data,
779 elt->size - sizeof(*elt))) {
780 pr_err("Invalid DTPR Table size.\n");
781 goto err;
782 }
783
784 return (struct acpi_table_dtpr *)elt->data;
785
786 err:
787 iounmap(*heap_base);
788 *heap_base = NULL;
789 return NULL;
790 }
791
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-18 6:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260917094133.765149-1-michal.camacho.romero@linux.intel.com>
2026-09-18 6:45 ` [PATCH 1/1] x86/tboot: Add support for parsing DTPR table and disabling TPRs kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox