Re: net/sched: cap the accounted backlog before it can wrap

Re: net/sched: cap the accounted backlog before it can wrap

[kernel test robot]

Hi Jamal,

kernel test robot noticed the following build warnings:



url:    https://github.com/intel-lab-lkp/linux/commits/Jamal-Hadi-Salim/net-sched-cap-the-accounted-backlog-before-it-can-wrap/20261002-034431
base:   
patch link:    https://lore.kernel.org/r/202610030129.hEQ6QJF9-lkp%40intel.com
config: hexagon-randconfig-1001-20261002 (https://download.01.org/0day-ci/archive/20261003/202610030129.hEQ6QJF9-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261003/202610030129.hEQ6QJF9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610030129.hEQ6QJF9-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/sched/sch_cake.c:1742:66: warning: '/*' within block comment [-Wcomment]
    1742 |  * consumed by a terminal TC action (reason in *qerr); else *flow/*host
         |                                                                  ^
   1 warning generated.


vim +1742 net/sched/sch_cake.c

  1740	
  1741	/* Run the optional external classifier. Returns true when the packet was
> 1742	 * consumed by a terminal TC action (reason in *qerr); else *flow/*host
  1743	 * hold the filter's overrides (0 if none).
  1744	 */
  1745	static bool cake_tcf_classify(struct Qdisc *sch, struct sk_buff *skb,
  1746				      u16 *flow, u16 *host, int *qerr)
  1747	{
  1748		struct cake_sched_data *q = qdisc_priv(sch);
  1749		struct tcf_proto *filter;
  1750		struct tcf_result res;
  1751		int result;
  1752	
  1753		*flow = 0;
  1754		*host = 0;
  1755	
  1756		filter = rcu_dereference_bh(q->filter_list);
  1757		if (!filter)
  1758			return false;
  1759	
  1760		*qerr = NET_XMIT_SUCCESS | __NET_XMIT_BYPASS;
  1761		result = tcf_classify_qdisc(skb, filter, &res, false);
  1762	
  1763		if (result >= 0) {
  1764	#ifdef CONFIG_NET_CLS_ACT
  1765			switch (result) {
  1766			case TC_ACT_STOLEN:
  1767			case TC_ACT_QUEUED:
  1768			case TC_ACT_TRAP:
  1769				*qerr = NET_XMIT_SUCCESS | __NET_XMIT_STOLEN;
  1770				fallthrough;
  1771			case TC_ACT_SHOT:
  1772				return true;
  1773			}
  1774	#endif
  1775			if (TC_H_MIN(res.classid) <= CAKE_QUEUES)
  1776				*flow = TC_H_MIN(res.classid);
  1777			if (TC_H_MAJ(res.classid) <= (CAKE_QUEUES << 16))
  1778				*host = TC_H_MAJ(res.classid) >> 16;
  1779		}
  1780		return false;
  1781	}
  1782	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki