Re: [PATCH v2 2/2] x86/apic: Replace deprecated simple_strtol() with sscanf() in x86_fwspec_is_hpet()

Re: [PATCH v2 2/2] x86/apic: Replace deprecated simple_strtol() with sscanf() in x86_fwspec_is_hpet()

[kernel test robot]

Hi Habil,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/x86/core]
[also build test WARNING on linus/master v7.3-rc6 next-20261005]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Habil-Eren-T-rker/x86-apic-Replace-deprecated-simple_strtol-with-sscanf-for-robust-parsing/20261005-163219
base:   tip/x86/core
patch link:    https://lore.kernel.org/r/20261005163213.6515-3-habilerenturker%40hotmail.com
patch subject: [PATCH v2 2/2] x86/apic: Replace deprecated simple_strtol() with sscanf() in x86_fwspec_is_hpet()
config: x86_64-buildonly-randconfig-1003-20261006 (https://download.01.org/0day-ci/archive/20261006/202610061356.8VHVO1CY-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261006/202610061356.8VHVO1CY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610061356.8VHVO1CY-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/x86/kernel/apic/vector.c:700:10: warning: comparison between pointer and integer ('unsigned int' and 'u32 *' (aka 'unsigned int *')) [-Wpointer-integer-compare]
     700 |             val == fwspec->param)
         |             ~~~ ^  ~~~~~~~~~~~~~
   1 warning generated.


vim +700 arch/x86/kernel/apic/vector.c

   685	
   686	int x86_fwspec_is_hpet(struct irq_fwspec *fwspec)
   687	{
   688		const char *fwname;
   689		unsigned int val;
   690	
   691		if (fwspec->param_count != 1)
   692			return 0;
   693	
   694		if (!is_fwnode_irqchip(fwspec->fwnode))
   695			return 0;
   696	
   697		fwname = fwnode_get_name(fwspec->fwnode);
   698	
   699		if (fwname && sscanf(fwname, "HPET-MSI-%u", &val) == 1 &&
 > 700		    val == fwspec->param)
   701			return 1;
   702	
   703		return 0;
   704	}
   705	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki