Re: [PATCH net-next v3 5/6] net: phy: mediatek: add calibration logic for AN7581

Re: [PATCH net-next v3 5/6] net: phy: mediatek: add calibration logic for AN7581

[kernel test robot]

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/net-phy-mediatek-export-__mtk_tr_write/20261014-091732
base:   net-next/main
patch link:    https://lore.kernel.org/r/20261014071739.216345-6-ansuelsmth%40gmail.com
patch subject: [PATCH net-next v3 5/6] net: phy: mediatek: add calibration logic for AN7581
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20261015/202610151259.WmaEeHMH-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 6719b9e31d6a93099612c474eec76d9f41d0275a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261015/202610151259.WmaEeHMH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610151259.WmaEeHMH-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/phy/mediatek/airoha-ge-soc.c:1522:3: warning: variable 'shared' is uninitialized when used here [-Wuninitialized]
    1522 |                 shared->phydev_p0 = phydev;
         |                 ^~~~~~
   drivers/net/phy/mediatek/airoha-ge-soc.c:1501:37: note: initialize the variable 'shared' to silence this warning
    1501 |         struct airoha_socphy_shared *shared;
         |                                            ^
         |                                             = NULL
   1 warning generated.


vim +/shared +1522 drivers/net/phy/mediatek/airoha-ge-soc.c

  1498	
  1499	static int an7581_phy_probe(struct phy_device *phydev)
  1500	{
  1501		struct airoha_socphy_shared *shared;
  1502		struct mtk_socphy_priv *priv;
  1503		struct pinctrl *pinctrl;
  1504		int ret;
  1505	
  1506		/* Toggle pinctrl to enable PHY LED */
  1507		pinctrl = devm_pinctrl_get_select(&phydev->mdio.dev, "gbe-led");
  1508		if (IS_ERR(pinctrl))
  1509			dev_err(&phydev->mdio.bus->dev,
  1510				"Failed to setup PHY LED pinctrl\n");
  1511	
  1512		ret = devm_phy_package_join(&phydev->mdio.dev, phydev, 0,
  1513					    sizeof(struct airoha_socphy_shared));
  1514		if (ret)
  1515			return ret;
  1516	
  1517		priv = devm_kzalloc(&phydev->mdio.dev, sizeof(*priv), GFP_KERNEL);
  1518		if (!priv)
  1519			return -ENOMEM;
  1520	
  1521		if (phydev->mdio.addr == AIROHA_DEFAULT_PORT0_ADDR)
> 1522			shared->phydev_p0 = phydev;
  1523	
  1524		phydev->priv = priv;
  1525	
  1526		return 0;
  1527	}
  1528	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki