Re: [PATCH 5/6] sched/numa: do not feed tiering promotions into task placement stats

Re: [PATCH 5/6] sched/numa: do not feed tiering promotions into task placement stats

[kernel test robot]

Hi Li,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on akpm-mm/mm-everything peterz-queue/sched/core linus/master v7.3-rc7 next-20261012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Zhe/sched-numa-clear-fault-locality-state-on-execve/20261014-174342
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20261014094347.99157-6-lizhe.67%40bytedance.com
patch subject: [PATCH 5/6] sched/numa: do not feed tiering promotions into task placement stats
config: hexagon-allnoconfig (https://download.01.org/0day-ci/archive/20261015/202610151319.1QoCU2Pd-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 6719b9e31d6a93099612c474eec76d9f41d0275a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261015/202610151319.1QoCU2Pd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610151319.1QoCU2Pd-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/memory.c:6176:18: error: use of undeclared identifier 'LAST_CPUPID_ACCESS_TIME'
    6176 |                 *last_cpupid = LAST_CPUPID_ACCESS_TIME;
         |                                ^~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +/LAST_CPUPID_ACCESS_TIME +6176 mm/memory.c

  6147	
  6148	int numa_migrate_check(struct folio *folio, struct vm_fault *vmf,
  6149			      unsigned long addr, int *flags,
  6150			      bool writable, int *last_cpupid)
  6151	{
  6152		struct vm_area_struct *vma = vmf->vma;
  6153	
  6154		/*
  6155		 * Avoid grouping on RO pages in general. RO pages shouldn't hurt as
  6156		 * much anyway since they can be in shared cache state. This misses
  6157		 * the case where a mapping is writable but the process never writes
  6158		 * to it but pte_write gets cleared during protection updates and
  6159		 * pte_dirty has unpredictable behaviour between PTE scan updates,
  6160		 * background writeback, dirty balancing and application behaviour.
  6161		 */
  6162		if (!writable)
  6163			*flags |= TNF_NO_GROUP;
  6164	
  6165		/*
  6166		 * Flag if the folio is shared between multiple address spaces. This
  6167		 * is later used when determining whether to group tasks together
  6168		 */
  6169		if (folio_maybe_mapped_shared(folio) && (vma->vm_flags & VM_SHARED))
  6170			*flags |= TNF_SHARED;
  6171		/*
  6172		 * For memory tiering mode, cpupid of slow memory page is used
  6173		 * to record page access time.  So use default value.
  6174		 */
  6175		if (folio_use_access_time(folio))
> 6176			*last_cpupid = LAST_CPUPID_ACCESS_TIME;
  6177		else
  6178			*last_cpupid = folio_last_cpupid(folio);
  6179	
  6180		/* Record the current PID accessing VMA */
  6181		vma_set_access_pid_bit(vma);
  6182	
  6183		count_vm_numa_event(NUMA_HINT_FAULTS);
  6184	#ifdef CONFIG_NUMA_BALANCING
  6185		count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1);
  6186	#endif
  6187		if (folio_nid(folio) == numa_node_id()) {
  6188			count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);
  6189			*flags |= TNF_FAULT_LOCAL;
  6190		}
  6191	
  6192		return mpol_misplaced(folio, vmf, addr);
  6193	}
  6194	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki