Re: [PATCH bpf 07/81] bpf: One time slice of may_goto for a run of a prog

Re: [PATCH bpf 07/81] bpf: One time slice of may_goto for a run of a prog

[kernel test robot]

Hi Alexei,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexei-Starovoitov/selftests-bpf-Remove-tests-for-global-data-in-arena/20261026-025822
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
patch link:    https://lore.kernel.org/r/20261026025943.404450-8-alexei.starovoitov%40gmail.com
patch subject: [PATCH bpf 07/81] bpf: One time slice of may_goto for a run of a prog
config: um-defconfig (https://download.01.org/0day-ci/archive/20261026/202610262241.4DF09B1A-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 186e70f4e6a1521991d2340d3d49b23b1beff11f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261026/202610262241.4DF09B1A-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610262241.4DF09B1A-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/bpf/core.c:3633:6: warning: no previous prototype for function 'bpf_prog_begin_run' [-Wmissing-prototypes]
    3633 | void bpf_prog_begin_run(const struct bpf_prog *prog)
         |      ^
   kernel/bpf/core.c:3633:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    3633 | void bpf_prog_begin_run(const struct bpf_prog *prog)
         | ^
         | static 
   1 warning generated.


vim +/bpf_prog_begin_run +3633 kernel/bpf/core.c

  3628	
  3629	/*
  3630	 * The kernel is about to call an async callback of @prog on this cpu: a run begins.
  3631	 * The main prog does the same in its first insns.
  3632	 */
> 3633	void bpf_prog_begin_run(const struct bpf_prog *prog)
  3634	{
  3635		struct bpf_prog_aux *aux;
  3636	
  3637		if (!prog)
  3638			return;
  3639		aux = prog->aux->main_prog_aux;
  3640		if (aux->may_goto_budget) {
  3641			this_cpu_write(aux->may_goto_budget->start, 0);
  3642			this_cpu_write(aux->may_goto_budget->count, BPF_MAX_TIMED_LOOPS);
  3643		}
  3644	}
  3645	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki