From: kernel test robot <lkp@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Johannes Berg <johannes.berg@intel.com>,
Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Subject: Re: [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link()
Date: Wed, 4 Nov 2026 03:08:06 +0800 [thread overview]
Message-ID: <202611040250.cGDVGGwA-lkp@intel.com> (raw)
In-Reply-To: <20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba@changeid>
Hi Johannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/wifi-mac80211-clarify-station-link-handling/20261102-224238
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba%40changeid
patch subject: [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link()
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20261104/202611040250.cGDVGGwA-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261104/202611040250.cGDVGGwA-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611040250.cGDVGGwA-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/wireless/intel/iwlwifi/mld/sta.c:913:7: error: use of undeclared identifier 'vif'; did you mean 'if'?
913 | if (vif->type == NL80211_IFTYPE_STATION && !sta->tdls)
| ^~~
| if
>> drivers/net/wireless/intel/iwlwifi/mld/sta.c:913:7: error: expected expression
drivers/net/wireless/intel/iwlwifi/mld/sta.c:914:32: error: use of undeclared identifier 'vif'; did you mean 'if'?
914 | iwl_mld_remove_ap_keys(mld, vif, sta, link_id);
| ^~~
| if
drivers/net/wireless/intel/iwlwifi/mld/sta.c:914:32: error: expected expression
4 errors generated.
vim +913 drivers/net/wireless/intel/iwlwifi/mld/sta.c
d1e879ec600f9b Miri Korenblit 2025-02-16 890
d1e879ec600f9b Miri Korenblit 2025-02-16 891 void iwl_mld_remove_sta(struct iwl_mld *mld, struct ieee80211_sta *sta)
d1e879ec600f9b Miri Korenblit 2025-02-16 892 {
d1e879ec600f9b Miri Korenblit 2025-02-16 893 struct ieee80211_link_sta *link_sta;
d1e879ec600f9b Miri Korenblit 2025-02-16 894 u8 link_id;
d1e879ec600f9b Miri Korenblit 2025-02-16 895
d1e879ec600f9b Miri Korenblit 2025-02-16 896 lockdep_assert_wiphy(mld->wiphy);
d1e879ec600f9b Miri Korenblit 2025-02-16 897
d1e879ec600f9b Miri Korenblit 2025-02-16 898 /* Tell the HW to flush the queues */
d1e879ec600f9b Miri Korenblit 2025-02-16 899 iwl_mld_flush_sta_txqs(mld, sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 900
d1e879ec600f9b Miri Korenblit 2025-02-16 901 /* Wait for trans to empty its queues */
d1e879ec600f9b Miri Korenblit 2025-02-16 902 iwl_mld_wait_sta_txqs_empty(mld, sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 903
d1e879ec600f9b Miri Korenblit 2025-02-16 904 /* Now we can remove the queues */
d1e879ec600f9b Miri Korenblit 2025-02-16 905 for (int i = 0; i < ARRAY_SIZE(sta->txq); i++)
d1e879ec600f9b Miri Korenblit 2025-02-16 906 iwl_mld_remove_txq(mld, sta->txq[i]);
d1e879ec600f9b Miri Korenblit 2025-02-16 907
83b0c8b2692d39 Johannes Berg 2026-11-02 908 for_each_sta_active_link(sta, link_sta, link_id) {
d1e879ec600f9b Miri Korenblit 2025-02-16 909 /* Mac8011 will remove the groupwise keys after the sta is
d1e879ec600f9b Miri Korenblit 2025-02-16 910 * removed, but FW expects all the keys to be removed before
d1e879ec600f9b Miri Korenblit 2025-02-16 911 * the STA is, so remove them all here.
d1e879ec600f9b Miri Korenblit 2025-02-16 912 */
67128af05c6419 Johannes Berg 2025-03-09 @913 if (vif->type == NL80211_IFTYPE_STATION && !sta->tdls)
d1e879ec600f9b Miri Korenblit 2025-02-16 914 iwl_mld_remove_ap_keys(mld, vif, sta, link_id);
d1e879ec600f9b Miri Korenblit 2025-02-16 915
d1e879ec600f9b Miri Korenblit 2025-02-16 916 /* Remove the link_sta */
d1e879ec600f9b Miri Korenblit 2025-02-16 917 iwl_mld_remove_link_sta(mld, link_sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 918 }
d1e879ec600f9b Miri Korenblit 2025-02-16 919
d1e879ec600f9b Miri Korenblit 2025-02-16 920 iwl_mld_destroy_sta(sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 921 }
d1e879ec600f9b Miri Korenblit 2025-02-16 922
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2026-11-03 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba@changeid>
2026-11-03 19:08 ` kernel test robot [this message]
2026-11-05 4:39 ` [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link() kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202611040250.cGDVGGwA-lkp@intel.com \
--to=lkp@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=miriam.rachel.korenblit@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox