* Re: [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link()
[not found] <20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba@changeid>
@ 2026-11-03 19:08 ` kernel test robot
2026-11-05 4:39 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-11-03 19:08 UTC (permalink / raw)
To: Johannes Berg, linux-wireless
Cc: llvm, oe-kbuild-all, Johannes Berg, Miriam Rachel Korenblit
Hi Johannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/wifi-mac80211-clarify-station-link-handling/20261102-224238
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba%40changeid
patch subject: [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link()
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20261104/202611040250.cGDVGGwA-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261104/202611040250.cGDVGGwA-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611040250.cGDVGGwA-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/wireless/intel/iwlwifi/mld/sta.c:913:7: error: use of undeclared identifier 'vif'; did you mean 'if'?
913 | if (vif->type == NL80211_IFTYPE_STATION && !sta->tdls)
| ^~~
| if
>> drivers/net/wireless/intel/iwlwifi/mld/sta.c:913:7: error: expected expression
drivers/net/wireless/intel/iwlwifi/mld/sta.c:914:32: error: use of undeclared identifier 'vif'; did you mean 'if'?
914 | iwl_mld_remove_ap_keys(mld, vif, sta, link_id);
| ^~~
| if
drivers/net/wireless/intel/iwlwifi/mld/sta.c:914:32: error: expected expression
4 errors generated.
vim +913 drivers/net/wireless/intel/iwlwifi/mld/sta.c
d1e879ec600f9b Miri Korenblit 2025-02-16 890
d1e879ec600f9b Miri Korenblit 2025-02-16 891 void iwl_mld_remove_sta(struct iwl_mld *mld, struct ieee80211_sta *sta)
d1e879ec600f9b Miri Korenblit 2025-02-16 892 {
d1e879ec600f9b Miri Korenblit 2025-02-16 893 struct ieee80211_link_sta *link_sta;
d1e879ec600f9b Miri Korenblit 2025-02-16 894 u8 link_id;
d1e879ec600f9b Miri Korenblit 2025-02-16 895
d1e879ec600f9b Miri Korenblit 2025-02-16 896 lockdep_assert_wiphy(mld->wiphy);
d1e879ec600f9b Miri Korenblit 2025-02-16 897
d1e879ec600f9b Miri Korenblit 2025-02-16 898 /* Tell the HW to flush the queues */
d1e879ec600f9b Miri Korenblit 2025-02-16 899 iwl_mld_flush_sta_txqs(mld, sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 900
d1e879ec600f9b Miri Korenblit 2025-02-16 901 /* Wait for trans to empty its queues */
d1e879ec600f9b Miri Korenblit 2025-02-16 902 iwl_mld_wait_sta_txqs_empty(mld, sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 903
d1e879ec600f9b Miri Korenblit 2025-02-16 904 /* Now we can remove the queues */
d1e879ec600f9b Miri Korenblit 2025-02-16 905 for (int i = 0; i < ARRAY_SIZE(sta->txq); i++)
d1e879ec600f9b Miri Korenblit 2025-02-16 906 iwl_mld_remove_txq(mld, sta->txq[i]);
d1e879ec600f9b Miri Korenblit 2025-02-16 907
83b0c8b2692d39 Johannes Berg 2026-11-02 908 for_each_sta_active_link(sta, link_sta, link_id) {
d1e879ec600f9b Miri Korenblit 2025-02-16 909 /* Mac8011 will remove the groupwise keys after the sta is
d1e879ec600f9b Miri Korenblit 2025-02-16 910 * removed, but FW expects all the keys to be removed before
d1e879ec600f9b Miri Korenblit 2025-02-16 911 * the STA is, so remove them all here.
d1e879ec600f9b Miri Korenblit 2025-02-16 912 */
67128af05c6419 Johannes Berg 2025-03-09 @913 if (vif->type == NL80211_IFTYPE_STATION && !sta->tdls)
d1e879ec600f9b Miri Korenblit 2025-02-16 914 iwl_mld_remove_ap_keys(mld, vif, sta, link_id);
d1e879ec600f9b Miri Korenblit 2025-02-16 915
d1e879ec600f9b Miri Korenblit 2025-02-16 916 /* Remove the link_sta */
d1e879ec600f9b Miri Korenblit 2025-02-16 917 iwl_mld_remove_link_sta(mld, link_sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 918 }
d1e879ec600f9b Miri Korenblit 2025-02-16 919
d1e879ec600f9b Miri Korenblit 2025-02-16 920 iwl_mld_destroy_sta(sta);
d1e879ec600f9b Miri Korenblit 2025-02-16 921 }
d1e879ec600f9b Miri Korenblit 2025-02-16 922
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link()
[not found] <20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba@changeid>
2026-11-03 19:08 ` [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link() kernel test robot
@ 2026-11-05 4:39 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-11-05 4:39 UTC (permalink / raw)
To: Johannes Berg, linux-wireless
Cc: llvm, oe-kbuild-all, Johannes Berg, Miriam Rachel Korenblit
Hi Johannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/wifi-mac80211-rename-ieee80211_sta_activate_link/20261102-224237
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20261102224349.e1d1ed2eef37.I0f5c26e0f6a05feaf5c578fa048ca5586530f0ba%40changeid
patch subject: [PATCH wireless-next 7/7] wifi: mac80211: use sta->active_links in for_each_sta_active_link()
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20261105/202611051257.yN72uAKg-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
rustc: rustc 1.96.0 (ac68faa20 2026-05-25)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261105/202611051257.yN72uAKg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611051257.yN72uAKg-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/net/wireless/intel/iwlwifi/mld/sta.c:6:
In file included from include/linux/ieee80211.h:19:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:24:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:12:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:1209:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
1209 | return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
| ~~~~~~~~~~ ^
>> drivers/net/wireless/intel/iwlwifi/mld/sta.c:913:7: error: use of undeclared identifier 'vif'; did you mean 'if'?
913 | if (vif->type == NL80211_IFTYPE_STATION && !sta->tdls)
| ^~~
| if
>> drivers/net/wireless/intel/iwlwifi/mld/sta.c:913:7: error: expected expression
drivers/net/wireless/intel/iwlwifi/mld/sta.c:914:32: error: use of undeclared identifier 'vif'; did you mean 'if'?
914 | iwl_mld_remove_ap_keys(mld, vif, sta, link_id);
| ^~~
| if
drivers/net/wireless/intel/iwlwifi/mld/sta.c:914:32: error: expected expression
1 warning and 4 errors generated.
vim +913 drivers/net/wireless/intel/iwlwifi/mld/sta.c
d1e879ec600f9b3 Miri Korenblit 2025-02-16 890
d1e879ec600f9b3 Miri Korenblit 2025-02-16 891 void iwl_mld_remove_sta(struct iwl_mld *mld, struct ieee80211_sta *sta)
d1e879ec600f9b3 Miri Korenblit 2025-02-16 892 {
d1e879ec600f9b3 Miri Korenblit 2025-02-16 893 struct ieee80211_link_sta *link_sta;
d1e879ec600f9b3 Miri Korenblit 2025-02-16 894 u8 link_id;
d1e879ec600f9b3 Miri Korenblit 2025-02-16 895
d1e879ec600f9b3 Miri Korenblit 2025-02-16 896 lockdep_assert_wiphy(mld->wiphy);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 897
d1e879ec600f9b3 Miri Korenblit 2025-02-16 898 /* Tell the HW to flush the queues */
d1e879ec600f9b3 Miri Korenblit 2025-02-16 899 iwl_mld_flush_sta_txqs(mld, sta);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 900
d1e879ec600f9b3 Miri Korenblit 2025-02-16 901 /* Wait for trans to empty its queues */
d1e879ec600f9b3 Miri Korenblit 2025-02-16 902 iwl_mld_wait_sta_txqs_empty(mld, sta);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 903
d1e879ec600f9b3 Miri Korenblit 2025-02-16 904 /* Now we can remove the queues */
d1e879ec600f9b3 Miri Korenblit 2025-02-16 905 for (int i = 0; i < ARRAY_SIZE(sta->txq); i++)
d1e879ec600f9b3 Miri Korenblit 2025-02-16 906 iwl_mld_remove_txq(mld, sta->txq[i]);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 907
4fa80ba223dd728 Johannes Berg 2026-11-02 908 for_each_sta_active_link(sta, link_sta, link_id) {
d1e879ec600f9b3 Miri Korenblit 2025-02-16 909 /* Mac8011 will remove the groupwise keys after the sta is
d1e879ec600f9b3 Miri Korenblit 2025-02-16 910 * removed, but FW expects all the keys to be removed before
d1e879ec600f9b3 Miri Korenblit 2025-02-16 911 * the STA is, so remove them all here.
d1e879ec600f9b3 Miri Korenblit 2025-02-16 912 */
67128af05c6419e Johannes Berg 2025-03-09 @913 if (vif->type == NL80211_IFTYPE_STATION && !sta->tdls)
d1e879ec600f9b3 Miri Korenblit 2025-02-16 914 iwl_mld_remove_ap_keys(mld, vif, sta, link_id);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 915
d1e879ec600f9b3 Miri Korenblit 2025-02-16 916 /* Remove the link_sta */
d1e879ec600f9b3 Miri Korenblit 2025-02-16 917 iwl_mld_remove_link_sta(mld, link_sta);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 918 }
d1e879ec600f9b3 Miri Korenblit 2025-02-16 919
d1e879ec600f9b3 Miri Korenblit 2025-02-16 920 iwl_mld_destroy_sta(sta);
d1e879ec600f9b3 Miri Korenblit 2025-02-16 921 }
d1e879ec600f9b3 Miri Korenblit 2025-02-16 922
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread