* Re: [PATCH wireless-next v3 15/21] wifi: mac80211: filter uplink and downlink frames based on SMD states
[not found] <20261106-smd-v3-15-1723950e3cf8@oss.qualcomm.com>
@ 2026-11-06 3:01 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-11-06 3:01 UTC (permalink / raw)
To: Pooventhiran G, Johannes Berg
Cc: llvm, oe-kbuild-all, linux-wireless, linux-kernel, pooventhiran.g
Hi Pooventhiran,
kernel test robot noticed the following build warnings:
[auto build test WARNING on b8e5b0ae8ff47240366d38e5d12c65f878724316]
url: https://github.com/intel-lab-lkp/linux/commits/Pooventhiran-G/wifi-nl80211-define-Seamless-Mobility-Domain-SMD-device-capability/20261106-010836
base: b8e5b0ae8ff47240366d38e5d12c65f878724316
patch link: https://lore.kernel.org/r/20261106-smd-v3-15-1723950e3cf8%40oss.qualcomm.com
patch subject: [PATCH wireless-next v3 15/21] wifi: mac80211: filter uplink and downlink frames based on SMD states
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20261106/202611061037.MK46LPkJ-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261106/202611061037.MK46LPkJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611061037.MK46LPkJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/mac80211/tx.c:318:48: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
318 | (tx->sdata->vif.type != NL80211_IFTYPE_AP ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
319 | tx->sdata->vif.type != NL80211_IFTYPE_AP_VLAN) ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +318 net/mac80211/tx.c
310
311 static ieee80211_tx_result debug_noinline
312 ieee80211_tx_h_smd_state(struct ieee80211_tx_data *tx)
313 {
314 struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)tx->skb->data;
315 __le16 fc = hdr->frame_control;
316
317 if (!tx->sta ||
> 318 (tx->sdata->vif.type != NL80211_IFTYPE_AP ||
319 tx->sdata->vif.type != NL80211_IFTYPE_AP_VLAN) ||
320 !test_sta_flag(tx->sta, WLAN_STA_ASSOC) ||
321 !(tx->flags & IEEE80211_TX_UNICAST))
322 return TX_CONTINUE;
323
324 switch (tx->sta->smd_state) {
325 case IEEE80211_STA_SMD_NONE:
326 break;
327 case IEEE80211_STA_SMD_PREP:
328 /* 4a: Class 3 disallowed except ST Execution Response */
329 if (ieee80211_is_st_exec_resp(tx->skb))
330 break;
331 if (ieee80211_is_class3(tx->skb))
332 return TX_DROP;
333 break;
334 case IEEE80211_STA_SMD_EXEC:
335 /* 4b: no restriction */
336 break;
337 case IEEE80211_STA_SMD_DRAIN:
338 /* 4c: Class 3 disallowed except Data, Control,
339 * UHR Reconfiguration Notify
340 */
341 if (ieee80211_is_ctl(fc) || ieee80211_is_data(fc) ||
342 ieee80211_is_uhr_link_reconf_notify(tx->skb))
343 break;
344 if (ieee80211_is_class3(tx->skb))
345 return TX_DROP;
346 break;
347 }
348
349 return TX_CONTINUE;
350 }
351
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread