Re: [PATCH v2 14/28] drm/panthor: Add AM_PARTITION_CONTROL support

Re: [PATCH v2 14/28] drm/panthor: Add AM_PARTITION_CONTROL support

[kernel test robot]

Hi Karunika,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next drm-tip/drm-tip next-20261110]
[cannot apply to linux-review/Karunika-Choo/drm-panthor-Ignore-EOPNOTSUPP-for-shader-present-nvmem-lookup/20260922-214455 daeinki-drm-exynos/exynos-drm-next drm-i915/for-linux-next drm-i915/for-linux-next-fixes linus/master v7.4-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Karunika-Choo/drm-panthor-Ignore-EOPNOTSUPP-for-shader-present-nvmem-lookup/20261110-153822
base:   https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next
patch link:    https://lore.kernel.org/r/20261110153907.3241978-15-karunika.choo%40arm.com
patch subject: [PATCH v2 14/28] drm/panthor: Add AM_PARTITION_CONTROL support
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20261111/202611111301.KUTVMgUg-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project e73e336290028f26553b46c9fba844c13da38c9c)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261111/202611111301.KUTVMgUg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611111301.KUTVMgUg-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c:328:12: error: call to undeclared function 'irq_get_irq_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     328 |         irqdata = irq_get_irq_data(irq);
         |                   ^
   drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c:328:12: note: did you mean 'irq_set_irq_wake'?
   include/linux/interrupt.h:486:12: note: 'irq_set_irq_wake' declared here
     486 | extern int irq_set_irq_wake(unsigned int irq, unsigned int on);
         |            ^
>> drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c:328:10: error: incompatible integer to pointer conversion assigning to 'struct irq_data *' from 'int' [-Wint-conversion]
     328 |         irqdata = irq_get_irq_data(irq);
         |                 ^ ~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c:330:15: error: call to undeclared function 'irqd_get_trigger_type'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     330 |                 irq_flags = irqd_get_trigger_type(irqdata);
         |                             ^
   3 errors generated.


vim +/irq_get_irq_data +328 drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c

   278	
   279	static int partition_control_init(struct panthor_arbitration *adev, int i)
   280	{
   281		struct panthor_partition_control *pc;
   282		struct device *dev = adev->dev;
   283		struct irq_data *irqdata;
   284		struct resource *res;
   285		void __iomem *iomem;
   286		u32 irq_flags = 0;
   287		char *name;
   288		int irq;
   289		int ret;
   290	
   291		if (adev->pc[i])
   292			return dev_warn_probe(dev, -ENODEV,
   293					      "partition %u already present", i);
   294	
   295		pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL);
   296		if (!pc)
   297			return -ENOMEM;
   298	
   299		name = devm_kasprintf(dev, GFP_KERNEL, "pc%d", i);
   300		if (!name)
   301			return -ENOMEM;
   302	
   303		res = platform_get_resource_byname(to_platform_device(dev),
   304						   IORESOURCE_MEM, name);
   305		if (!res)
   306			return -ENODEV;
   307	
   308		iomem = devm_ioremap_resource(dev, res);
   309		if (IS_ERR(iomem))
   310			return dev_err_probe(dev, PTR_ERR(iomem), "%s: Failed to ioremap", name);
   311	
   312		pc->name = name;
   313		pc->dev = dev;
   314		pc->iomem = iomem;
   315	
   316		spin_lock_init(&pc->irq_lock);
   317		pc->irq_suspended = true;
   318	
   319		spin_lock_init(&pc->lock);
   320		pc->current_aw = AW_UNASSIGNED;
   321	
   322		irq = platform_get_irq_byname(to_platform_device(dev), name);
   323		if (irq < 0)
   324			return irq;
   325	
   326		pc->irq = irq;
   327	
 > 328		irqdata = irq_get_irq_data(irq);
   329		if (irqdata)
 > 330			irq_flags = irqd_get_trigger_type(irqdata);
   331	
   332		ret = devm_request_irq(
   333			dev, irq, partition_irq_raw_handler, irq_flags | IRQF_SHARED,
   334			devm_kasprintf(dev, GFP_KERNEL, "panthor-%s-irq", name), pc);
   335		if (ret)
   336			return ret;
   337	
   338		adev->pc[i] = pc;
   339	
   340		partition_irq_resume(pc);
   341	
   342		return 0;
   343	}
   344	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki