Re: [PATCH v2 2/2] drm: Remove drm_crtc_init()

Re: [PATCH v2 2/2] drm: Remove drm_crtc_init()

[kernel test robot]

Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v7.4-rc2 next-20261111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-radeon-Inline-drm_crtc_init/20261112-134508
base:   https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next
patch link:    https://lore.kernel.org/r/20261112125039.66082-3-tzimmermann%40suse.de
patch subject: [PATCH v2 2/2] drm: Remove drm_crtc_init()
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20261113/202611130312.g6BELEWG-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project c628d639fc66f8e6d8ab1f0cc6b1df38f974e020)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611130312.g6BELEWG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611130312.g6BELEWG-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:2603:2: error: call to undeclared function 'drm_crtc_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2603 |         drm_crtc_init(adev_to_drm(adev), &amdgpu_crtc->base, &dce_v8_0_crtc_funcs);
         |         ^
   1 error generated.
--
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:2645:2: error: call to undeclared function 'drm_crtc_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2645 |         drm_crtc_init(adev_to_drm(adev), &amdgpu_crtc->base, &dce_v6_0_crtc_funcs);
         |         ^
   1 error generated.
--
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:2677:2: error: call to undeclared function 'drm_crtc_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2677 |         drm_crtc_init(adev_to_drm(adev), &amdgpu_crtc->base, &dce_v10_0_crtc_funcs);
         |         ^
   1 error generated.


vim +/drm_crtc_init +2603 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c

7e50642d41050c Alex Deucher 2024-10-31  2593  
a2e73f56fa6282 Alex Deucher 2015-04-20  2594  static int dce_v8_0_crtc_init(struct amdgpu_device *adev, int index)
a2e73f56fa6282 Alex Deucher 2015-04-20  2595  {
a2e73f56fa6282 Alex Deucher 2015-04-20  2596  	struct amdgpu_crtc *amdgpu_crtc;
a2e73f56fa6282 Alex Deucher 2015-04-20  2597  
a2e73f56fa6282 Alex Deucher 2015-04-20  2598  	amdgpu_crtc = kzalloc(sizeof(struct amdgpu_crtc) +
a2e73f56fa6282 Alex Deucher 2015-04-20  2599  			      (AMDGPUFB_CONN_LIMIT * sizeof(struct drm_connector *)), GFP_KERNEL);
a2e73f56fa6282 Alex Deucher 2015-04-20  2600  	if (amdgpu_crtc == NULL)
a2e73f56fa6282 Alex Deucher 2015-04-20  2601  		return -ENOMEM;
a2e73f56fa6282 Alex Deucher 2015-04-20  2602  
4a580877bdcb83 Luben Tuikov 2020-08-24 @2603  	drm_crtc_init(adev_to_drm(adev), &amdgpu_crtc->base, &dce_v8_0_crtc_funcs);
a2e73f56fa6282 Alex Deucher 2015-04-20  2604  
a2e73f56fa6282 Alex Deucher 2015-04-20  2605  	drm_mode_crtc_set_gamma_size(&amdgpu_crtc->base, 256);
a2e73f56fa6282 Alex Deucher 2015-04-20  2606  	amdgpu_crtc->crtc_id = index;
a2e73f56fa6282 Alex Deucher 2015-04-20  2607  	adev->mode_info.crtcs[index] = amdgpu_crtc;
a2e73f56fa6282 Alex Deucher 2015-04-20  2608  
a2e73f56fa6282 Alex Deucher 2015-04-20  2609  	amdgpu_crtc->max_cursor_width = CIK_CURSOR_WIDTH;
a2e73f56fa6282 Alex Deucher 2015-04-20  2610  	amdgpu_crtc->max_cursor_height = CIK_CURSOR_HEIGHT;
4a580877bdcb83 Luben Tuikov 2020-08-24  2611  	adev_to_drm(adev)->mode_config.cursor_width = amdgpu_crtc->max_cursor_width;
4a580877bdcb83 Luben Tuikov 2020-08-24  2612  	adev_to_drm(adev)->mode_config.cursor_height = amdgpu_crtc->max_cursor_height;
a2e73f56fa6282 Alex Deucher 2015-04-20  2613  
a2e73f56fa6282 Alex Deucher 2015-04-20  2614  	amdgpu_crtc->crtc_offset = crtc_offsets[amdgpu_crtc->crtc_id];
a2e73f56fa6282 Alex Deucher 2015-04-20  2615  
a2e73f56fa6282 Alex Deucher 2015-04-20  2616  	amdgpu_crtc->pll_id = ATOM_PPLL_INVALID;
a2e73f56fa6282 Alex Deucher 2015-04-20  2617  	amdgpu_crtc->adjusted_clock = 0;
a2e73f56fa6282 Alex Deucher 2015-04-20  2618  	amdgpu_crtc->encoder = NULL;
a2e73f56fa6282 Alex Deucher 2015-04-20  2619  	amdgpu_crtc->connector = NULL;
a2e73f56fa6282 Alex Deucher 2015-04-20  2620  	drm_crtc_helper_add(&amdgpu_crtc->base, &dce_v8_0_crtc_helper_funcs);
7e50642d41050c Alex Deucher 2024-10-31  2621  	drm_plane_helper_add(amdgpu_crtc->base.primary, &dce_v8_0_drm_primary_plane_helper_funcs);
a2e73f56fa6282 Alex Deucher 2015-04-20  2622  
a2e73f56fa6282 Alex Deucher 2015-04-20  2623  	return 0;
a2e73f56fa6282 Alex Deucher 2015-04-20  2624  }
a2e73f56fa6282 Alex Deucher 2015-04-20  2625  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki