* [rw-ubifs:next 19/33] fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb'
@ 2024-02-26 7:16 kernel test robot
2024-02-26 8:19 ` Zhihao Cheng
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-02-26 7:16 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: llvm, oe-kbuild-all, Richard Weinberger, Zhihao Cheng
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next
head: 3ce485803da1b79b2692b6d0c2792829292ad838
commit: ec724e534dfdd592abc5ac066be77ef15c455ccc [19/33] ubifs: fix function pointer cast warnings
config: i386-buildonly-randconfig-001-20240226 (https://download.01.org/0day-ci/archive/20240226/202402261559.cYtMOkIn-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240226/202402261559.cYtMOkIn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402261559.cYtMOkIn-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb'
>> fs/ubifs/find.c:86: warning: Excess function parameter 'data' description in 'scan_for_dirty_cb'
>> fs/ubifs/find.c:353: warning: Function parameter or struct member 'arg' not described in 'scan_for_free_cb'
>> fs/ubifs/find.c:353: warning: Excess function parameter 'data' description in 'scan_for_free_cb'
>> fs/ubifs/find.c:594: warning: Function parameter or struct member 'arg' not described in 'scan_for_idx_cb'
>> fs/ubifs/find.c:594: warning: Excess function parameter 'data' description in 'scan_for_idx_cb'
>> fs/ubifs/find.c:786: warning: Function parameter or struct member 'arg' not described in 'scan_dirty_idx_cb'
>> fs/ubifs/find.c:786: warning: Excess function parameter 'data' description in 'scan_dirty_idx_cb'
--
>> fs/ubifs/lprops.c:1018: warning: Function parameter or struct member 'arg' not described in 'scan_check_cb'
fs/ubifs/lprops.c:1018: warning: Excess function parameter 'lst' description in 'scan_check_cb'
vim +86 fs/ubifs/find.c
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 70
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 71 /**
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 72 * scan_for_dirty_cb - dirty space scan callback.
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 73 * @c: the UBIFS file-system description object
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 74 * @lprops: LEB properties to scan
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 75 * @in_tree: whether the LEB properties are in main memory
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 76 * @data: information passed to and from the caller of the scan
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 77 *
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 78 * This function returns a code that indicates whether the scan should continue
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 79 * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 80 * in main memory (%LPT_SCAN_ADD), or whether the scan should stop
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 81 * (%LPT_SCAN_STOP).
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 82 */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 83 static int scan_for_dirty_cb(struct ubifs_info *c,
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 84 const struct ubifs_lprops *lprops, int in_tree,
ec724e534dfdd5 Arnd Bergmann 2024-02-13 85 void *arg)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 @86 {
ec724e534dfdd5 Arnd Bergmann 2024-02-13 87 struct scan_data *data = arg;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 88 int ret = LPT_SCAN_CONTINUE;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 89
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 90 /* Exclude LEBs that are currently in use */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 91 if (lprops->flags & LPROPS_TAKEN)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 92 return LPT_SCAN_CONTINUE;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 93 /* Determine whether to add these LEB properties to the tree */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 94 if (!in_tree && valuable(c, lprops))
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 95 ret |= LPT_SCAN_ADD;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 96 /* Exclude LEBs with too little space */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 97 if (lprops->free + lprops->dirty < data->min_space)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 98 return ret;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 99 /* If specified, exclude index LEBs */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 100 if (data->exclude_index && lprops->flags & LPROPS_INDEX)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 101 return ret;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 102 /* If specified, exclude empty or freeable LEBs */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 103 if (lprops->free + lprops->dirty == c->leb_size) {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 104 if (!data->pick_free)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 105 return ret;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 106 /* Exclude LEBs with too little dirty space (unless it is empty) */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 107 } else if (lprops->dirty < c->dead_wm)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 108 return ret;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 109 /* Finally we found space */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 110 data->lnum = lprops->lnum;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 111 return LPT_SCAN_ADD | LPT_SCAN_STOP;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 112 }
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 113
:::::: The code at line 86 was first introduced by commit
:::::: 1e51764a3c2ac05a23a22b2a95ddee4d9bffb16d UBIFS: add new flash file system
:::::: TO: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
:::::: CC: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [rw-ubifs:next 19/33] fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb'
2024-02-26 7:16 [rw-ubifs:next 19/33] fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb' kernel test robot
@ 2024-02-26 8:19 ` Zhihao Cheng
2024-02-26 12:16 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Zhihao Cheng @ 2024-02-26 8:19 UTC (permalink / raw)
To: kernel test robot, Arnd Bergmann; +Cc: llvm, oe-kbuild-all, Richard Weinberger
在 2024/2/26 15:16, kernel test robot 写道:
Hi Arnd,
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next
> head: 3ce485803da1b79b2692b6d0c2792829292ad838
> commit: ec724e534dfdd592abc5ac066be77ef15c455ccc [19/33] ubifs: fix function pointer cast warnings
> config: i386-buildonly-randconfig-001-20240226 (https://download.01.org/0day-ci/archive/20240226/202402261559.cYtMOkIn-lkp@intel.com/config)
> compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240226/202402261559.cYtMOkIn-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402261559.cYtMOkIn-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb'
>>> fs/ubifs/find.c:86: warning: Excess function parameter 'data' description in 'scan_for_dirty_cb'
>>> fs/ubifs/find.c:353: warning: Function parameter or struct member 'arg' not described in 'scan_for_free_cb'
>>> fs/ubifs/find.c:353: warning: Excess function parameter 'data' description in 'scan_for_free_cb'
>>> fs/ubifs/find.c:594: warning: Function parameter or struct member 'arg' not described in 'scan_for_idx_cb'
>>> fs/ubifs/find.c:594: warning: Excess function parameter 'data' description in 'scan_for_idx_cb'
>>> fs/ubifs/find.c:786: warning: Function parameter or struct member 'arg' not described in 'scan_dirty_idx_cb'
>>> fs/ubifs/find.c:786: warning: Excess function parameter 'data' description in 'scan_dirty_idx_cb'
> --
>>> fs/ubifs/lprops.c:1018: warning: Function parameter or struct member 'arg' not described in 'scan_check_cb'
> fs/ubifs/lprops.c:1018: warning: Excess function parameter 'lst' description in 'scan_check_cb'
Looks like [1] imported a compiling warning, because the functions'
comments(on parameters) are missed to update. Do you have time to send a
patch to fix it? Thanks.
[1]
https://patchwork.ozlabs.org/project/linux-mtd/patch/20240213095412.453787-2-arnd@kernel.org/
>
>
> vim +86 fs/ubifs/find.c
>
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 70
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 71 /**
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 72 * scan_for_dirty_cb - dirty space scan callback.
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 73 * @c: the UBIFS file-system description object
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 74 * @lprops: LEB properties to scan
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 75 * @in_tree: whether the LEB properties are in main memory
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 76 * @data: information passed to and from the caller of the scan
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 77 *
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 78 * This function returns a code that indicates whether the scan should continue
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 79 * (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 80 * in main memory (%LPT_SCAN_ADD), or whether the scan should stop
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 81 * (%LPT_SCAN_STOP).
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 82 */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 83 static int scan_for_dirty_cb(struct ubifs_info *c,
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 84 const struct ubifs_lprops *lprops, int in_tree,
> ec724e534dfdd5 Arnd Bergmann 2024-02-13 85 void *arg)
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 @86 {
> ec724e534dfdd5 Arnd Bergmann 2024-02-13 87 struct scan_data *data = arg;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 88 int ret = LPT_SCAN_CONTINUE;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 89
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 90 /* Exclude LEBs that are currently in use */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 91 if (lprops->flags & LPROPS_TAKEN)
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 92 return LPT_SCAN_CONTINUE;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 93 /* Determine whether to add these LEB properties to the tree */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 94 if (!in_tree && valuable(c, lprops))
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 95 ret |= LPT_SCAN_ADD;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 96 /* Exclude LEBs with too little space */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 97 if (lprops->free + lprops->dirty < data->min_space)
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 98 return ret;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 99 /* If specified, exclude index LEBs */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 100 if (data->exclude_index && lprops->flags & LPROPS_INDEX)
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 101 return ret;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 102 /* If specified, exclude empty or freeable LEBs */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 103 if (lprops->free + lprops->dirty == c->leb_size) {
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 104 if (!data->pick_free)
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 105 return ret;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 106 /* Exclude LEBs with too little dirty space (unless it is empty) */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 107 } else if (lprops->dirty < c->dead_wm)
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 108 return ret;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 109 /* Finally we found space */
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 110 data->lnum = lprops->lnum;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 111 return LPT_SCAN_ADD | LPT_SCAN_STOP;
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 112 }
> 1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 113
>
> :::::: The code at line 86 was first introduced by commit
> :::::: 1e51764a3c2ac05a23a22b2a95ddee4d9bffb16d UBIFS: add new flash file system
>
> :::::: TO: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> :::::: CC: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [rw-ubifs:next 19/33] fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb'
2024-02-26 8:19 ` Zhihao Cheng
@ 2024-02-26 12:16 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-02-26 12:16 UTC (permalink / raw)
To: Zhihao Cheng, kernel test robot; +Cc: llvm, oe-kbuild-all, Richard Weinberger
On Mon, Feb 26, 2024, at 09:19, Zhihao Cheng wrote:
> 在 2024/2/26 15:16, kernel test robot 写道:
> Looks like [1] imported a compiling warning, because the functions'
> comments(on parameters) are missed to update. Do you have time to send a
> patch to fix it? Thanks.
>
> [1]
> https://patchwork.ozlabs.org/project/linux-mtd/patch/20240213095412.453787-2-arnd@kernel.org/
>>
Thanks for letting me know, sent a fix to go on top now.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-26 12:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-26 7:16 [rw-ubifs:next 19/33] fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb' kernel test robot
2024-02-26 8:19 ` Zhihao Cheng
2024-02-26 12:16 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox