Re: [PATCH] spi: amd: Fix -Wuninitialized in amd_spi_exec_mem_op()

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Mark,

On 13/01/2025 at 16:45:09 GMT, Mark Brown <broonie@kernel.org> wrote:

> On Sat, 11 Jan 2025 12:08:38 -0700, Nathan Chancellor wrote:
>> After commit e6204f39fe3a ("spi: amd: Drop redundant check"), clang warns (or
>> errors with CONFIG_WERROR=y):
>> 
>>   drivers/spi/spi-amd.c:695:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>>     695 |         return ret;
>>         |                ^~~
>>   drivers/spi/spi-amd.c:673:9: note: initialize the variable 'ret' to silence this warning
>>     673 |         int ret;
>>         |                ^
>>         |                 = 0
>>   1 error generated.
>> 
>> [...]
>
> Applied to
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!

I'm wondering whether it's relevant to pull the branch you shared
as-is. Do you plan on pushing this patch of top of it? Or shall I wait
-rc1 for the SPI NAND part?

Thanks,
Miquèl