* [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init
@ 2025-03-12 1:51 kernel test robot
2025-03-12 5:54 ` Jarkko Sakkinen
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2025-03-12 1:51 UTC (permalink / raw)
To: Stuart Yoder; +Cc: llvm, oe-kbuild-all, Jarkko Sakkinen
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: eea255893718268e1ab852fb52f70c613d109b99
commit: 9b2015ee9b5bba20097ea1e1f4188067624f4fa3 [9090/10334] tpm_crb: add support for the Arm FF-A start method
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503120916.TnY8Xobl-lkp@intel.com/
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: tpm_crb_ffa_init
>>> referenced by tpm_crb.c
>>> drivers/char/tpm/tpm_crb.o:(crb_acpi_add) in archive vmlinux.a
--
>> ld.lld: error: undefined symbol: tpm_crb_ffa_start
>>> referenced by tpm_crb.c
>>> drivers/char/tpm/tpm_crb.o:(__crb_request_locality) in archive vmlinux.a
>>> referenced by tpm_crb.c
>>> drivers/char/tpm/tpm_crb.o:(__crb_relinquish_locality) in archive vmlinux.a
>>> referenced by tpm_crb.c
>>> drivers/char/tpm/tpm_crb.o:(crb_send) in archive vmlinux.a
>>> referenced 1 more times
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init
2025-03-12 1:51 [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init kernel test robot
@ 2025-03-12 5:54 ` Jarkko Sakkinen
2025-03-12 5:57 ` Jarkko Sakkinen
2025-03-12 14:57 ` Stuart Yoder
0 siblings, 2 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2025-03-12 5:54 UTC (permalink / raw)
To: kernel test robot; +Cc: Stuart Yoder, llvm, oe-kbuild-all
On Wed, Mar 12, 2025 at 09:51:04AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: eea255893718268e1ab852fb52f70c613d109b99
> commit: 9b2015ee9b5bba20097ea1e1f4188067624f4fa3 [9090/10334] tpm_crb: add support for the Arm FF-A start method
> config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503120916.TnY8Xobl-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> ld.lld: error: undefined symbol: tpm_crb_ffa_init
> >>> referenced by tpm_crb.c
> >>> drivers/char/tpm/tpm_crb.o:(crb_acpi_add) in archive vmlinux.a
> --
> >> ld.lld: error: undefined symbol: tpm_crb_ffa_start
> >>> referenced by tpm_crb.c
> >>> drivers/char/tpm/tpm_crb.o:(__crb_request_locality) in archive vmlinux.a
> >>> referenced by tpm_crb.c
> >>> drivers/char/tpm/tpm_crb.o:(__crb_relinquish_locality) in archive vmlinux.a
> >>> referenced by tpm_crb.c
> >>> drivers/char/tpm/tpm_crb.o:(crb_send) in archive vmlinux.a
> >>> referenced 1 more times
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Stuart, I did not go through this but this does not look correct even with
a quick peak:
config TCG_ARM_CRB_FFA
~~~~~~~~~~~~~~~
TCG_FTPM_FFA (and Kconfig put before TCG_FTPM_TEE)
tristate "TPM CRB over Arm FF-A Transport"
depends on ARM_FFA_TRANSPORT
default y if (TCG_CRB && ARM_FFA_TRANSPORT)
~~~~~~~~~~~~~~~~~
redundant given "depends on"
help
If the Arm FF-A transport is used to access the TPM say Yes.
To compile this driver as a module, choose M here; the module
will be called tpm_crb_ffa.
So I'll drop the whole series from my tree for the moment and you'll
have to respin.
BR, Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init
2025-03-12 5:54 ` Jarkko Sakkinen
@ 2025-03-12 5:57 ` Jarkko Sakkinen
2025-03-12 15:00 ` Stuart Yoder
2025-03-12 14:57 ` Stuart Yoder
1 sibling, 1 reply; 5+ messages in thread
From: Jarkko Sakkinen @ 2025-03-12 5:57 UTC (permalink / raw)
To: kernel test robot; +Cc: Stuart Yoder, llvm, oe-kbuild-all
On Wed, Mar 12, 2025 at 07:54:52AM +0200, Jarkko Sakkinen wrote:
> On Wed, Mar 12, 2025 at 09:51:04AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: eea255893718268e1ab852fb52f70c613d109b99
> > commit: 9b2015ee9b5bba20097ea1e1f4188067624f4fa3 [9090/10334] tpm_crb: add support for the Arm FF-A start method
> > config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/config)
> > compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202503120916.TnY8Xobl-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > >> ld.lld: error: undefined symbol: tpm_crb_ffa_init
> > >>> referenced by tpm_crb.c
> > >>> drivers/char/tpm/tpm_crb.o:(crb_acpi_add) in archive vmlinux.a
> > --
> > >> ld.lld: error: undefined symbol: tpm_crb_ffa_start
> > >>> referenced by tpm_crb.c
> > >>> drivers/char/tpm/tpm_crb.o:(__crb_request_locality) in archive vmlinux.a
> > >>> referenced by tpm_crb.c
> > >>> drivers/char/tpm/tpm_crb.o:(__crb_relinquish_locality) in archive vmlinux.a
> > >>> referenced by tpm_crb.c
> > >>> drivers/char/tpm/tpm_crb.o:(crb_send) in archive vmlinux.a
> > >>> referenced 1 more times
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>
> Stuart, I did not go through this but this does not look correct even with
> a quick peak:
>
> config TCG_ARM_CRB_FFA
> ~~~~~~~~~~~~~~~
> TCG_FTPM_FFA (and Kconfig put before TCG_FTPM_TEE)
>
>
> tristate "TPM CRB over Arm FF-A Transport"
> depends on ARM_FFA_TRANSPORT
> default y if (TCG_CRB && ARM_FFA_TRANSPORT)
> ~~~~~~~~~~~~~~~~~
> redundant given "depends on"
>
> help
> If the Arm FF-A transport is used to access the TPM say Yes.
> To compile this driver as a module, choose M here; the module
> will be called tpm_crb_ffa.
>
> So I'll drop the whole series from my tree for the moment and you'll
> have to respin.
Commit could use short summary in along the lines of:
"tpm: ftpm_ffa: <summary>"
BR, Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init
2025-03-12 5:57 ` Jarkko Sakkinen
@ 2025-03-12 15:00 ` Stuart Yoder
0 siblings, 0 replies; 5+ messages in thread
From: Stuart Yoder @ 2025-03-12 15:00 UTC (permalink / raw)
To: Jarkko Sakkinen, kernel test robot; +Cc: llvm, oe-kbuild-all
>> config TCG_ARM_CRB_FFA
>> ~~~~~~~~~~~~~~~
>> TCG_FTPM_FFA (and Kconfig put before TCG_FTPM_TEE)
>>
>>
>> tristate "TPM CRB over Arm FF-A Transport"
>> depends on ARM_FFA_TRANSPORT
>> default y if (TCG_CRB && ARM_FFA_TRANSPORT)
>> ~~~~~~~~~~~~~~~~~
>> redundant given "depends on"
>>
>> help
>> If the Arm FF-A transport is used to access the TPM say Yes.
>> To compile this driver as a module, choose M here; the module
>> will be called tpm_crb_ffa.
>>
>> So I'll drop the whole series from my tree for the moment and you'll
>> have to respin.
>
> Commit could use short summary in along the lines of:
>
> "tpm: ftpm_ffa: <summary>"
It really isn't fTPM specific, the FF-A based TPM service could act as a
proxy to a discrete TPM chip. But, perhaps: ffa_tpm ?
Thanks,
Stuart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init
2025-03-12 5:54 ` Jarkko Sakkinen
2025-03-12 5:57 ` Jarkko Sakkinen
@ 2025-03-12 14:57 ` Stuart Yoder
1 sibling, 0 replies; 5+ messages in thread
From: Stuart Yoder @ 2025-03-12 14:57 UTC (permalink / raw)
To: Jarkko Sakkinen, kernel test robot; +Cc: llvm, oe-kbuild-all
On 3/12/25 12:54 AM, Jarkko Sakkinen wrote:
> On Wed, Mar 12, 2025 at 09:51:04AM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head: eea255893718268e1ab852fb52f70c613d109b99
>> commit: 9b2015ee9b5bba20097ea1e1f4188067624f4fa3 [9090/10334] tpm_crb: add support for the Arm FF-A start method
>> config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/config)
>> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503120916.TnY8Xobl-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202503120916.TnY8Xobl-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>>> ld.lld: error: undefined symbol: tpm_crb_ffa_init
>> >>> referenced by tpm_crb.c
>> >>> drivers/char/tpm/tpm_crb.o:(crb_acpi_add) in archive vmlinux.a
>> --
>>>> ld.lld: error: undefined symbol: tpm_crb_ffa_start
>> >>> referenced by tpm_crb.c
>> >>> drivers/char/tpm/tpm_crb.o:(__crb_request_locality) in archive vmlinux.a
>> >>> referenced by tpm_crb.c
>> >>> drivers/char/tpm/tpm_crb.o:(__crb_relinquish_locality) in archive vmlinux.a
>> >>> referenced by tpm_crb.c
>> >>> drivers/char/tpm/tpm_crb.o:(crb_send) in archive vmlinux.a
>> >>> referenced 1 more times
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
>
> Stuart, I did not go through this but this does not look correct even with
> a quick peak:
>
> config TCG_ARM_CRB_FFA
> ~~~~~~~~~~~~~~~
> TCG_FTPM_FFA (and Kconfig put before TCG_FTPM_TEE)
>
>
> tristate "TPM CRB over Arm FF-A Transport"
> depends on ARM_FFA_TRANSPORT
> default y if (TCG_CRB && ARM_FFA_TRANSPORT)
> ~~~~~~~~~~~~~~~~~
> redundant given "depends on"
>
> help
> If the Arm FF-A transport is used to access the TPM say Yes.
> To compile this driver as a module, choose M here; the module
> will be called tpm_crb_ffa.
>
> So I'll drop the whole series from my tree for the moment and you'll
> have to respin.
Will do. The intent was that if both TCG_CRB and ARM_FFA_TRANSPORT were
enabled that TCG_ARM_CRB_FFA would default to on. But, something is
wrong here that needs to be fixed and I will respin.
Thanks,
Stuart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-12 15:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-12 1:51 [linux-next:master 9090/10334] ld.lld: error: undefined symbol: tpm_crb_ffa_init kernel test robot
2025-03-12 5:54 ` Jarkko Sakkinen
2025-03-12 5:57 ` Jarkko Sakkinen
2025-03-12 15:00 ` Stuart Yoder
2025-03-12 14:57 ` Stuart Yoder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox