* Re: [PATCH v3] RISC-V: Enable dead code elimination
[not found] <20230517082936.37563-1-falcon@tinylab.org>
@ 2023-06-20 20:13 ` Nick Desaulniers
2023-06-20 20:17 ` Palmer Dabbelt
0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2023-06-20 20:13 UTC (permalink / raw)
To: Zhangjin Wu
Cc: palmer, conor, guoren, linux-riscv, npiggin, paul.walmsley,
paulburton, vincent.chen, tim.bird, llvm
On Wed, May 17, 2023 at 04:29:36PM +0800, Zhangjin Wu wrote:
> Select CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION for RISC-V, allowing
> the user to enable dead code elimination. In order for this to work,
> ensure that we keep the alternative table by annotating them with KEEP.
>
Just cross referencing the report from Palmer against v2; I see orphan
section warnings from the linker related to the EFI stub when building
allmodconfig with this patch applied.
v2: thread for reference.
https://lore.kernel.org/linux-riscv/CAKwvOdmsgMN5oQpDLh12D0X-CfQDtHC-EtxHcBnADkhnyitMKQ@mail.gmail.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] RISC-V: Enable dead code elimination
2023-06-20 20:13 ` [PATCH v3] RISC-V: Enable dead code elimination Nick Desaulniers
@ 2023-06-20 20:17 ` Palmer Dabbelt
2023-06-20 20:22 ` Conor Dooley
2023-06-20 20:26 ` Nick Desaulniers
0 siblings, 2 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2023-06-20 20:17 UTC (permalink / raw)
To: ndesaulniers
Cc: falcon, Conor Dooley, guoren, linux-riscv, npiggin, Paul Walmsley,
paulburton, vincent.chen, tim.bird, llvm
On Tue, 20 Jun 2023 13:13:06 PDT (-0700), ndesaulniers@google.com wrote:
> On Wed, May 17, 2023 at 04:29:36PM +0800, Zhangjin Wu wrote:
>> Select CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION for RISC-V, allowing
>> the user to enable dead code elimination. In order for this to work,
>> ensure that we keep the alternative table by annotating them with KEEP.
>>
>
> Just cross referencing the report from Palmer against v2; I see orphan
> section warnings from the linker related to the EFI stub when building
> allmodconfig with this patch applied.
>
> v2: thread for reference.
> https://lore.kernel.org/linux-riscv/CAKwvOdmsgMN5oQpDLh12D0X-CfQDtHC-EtxHcBnADkhnyitMKQ@mail.gmail.com/
Sorry for replying to the v2, I'm marking that as superseeded in
patchwork. IIUC it is a real issue on your end too? I'm also not 100%
sure about the hang, I just let LLD cook for about 10 minutes before I
noticed it was still running and posted.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] RISC-V: Enable dead code elimination
2023-06-20 20:17 ` Palmer Dabbelt
@ 2023-06-20 20:22 ` Conor Dooley
2023-06-20 20:26 ` Nick Desaulniers
1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-06-20 20:22 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: ndesaulniers, falcon, guoren, linux-riscv, npiggin, Paul Walmsley,
paulburton, vincent.chen, tim.bird, llvm
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
On Tue, Jun 20, 2023 at 01:17:26PM -0700, Palmer Dabbelt wrote:
> On Tue, 20 Jun 2023 13:13:06 PDT (-0700), ndesaulniers@google.com wrote:
> > On Wed, May 17, 2023 at 04:29:36PM +0800, Zhangjin Wu wrote:
> > > Select CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION for RISC-V, allowing
> > > the user to enable dead code elimination. In order for this to work,
> > > ensure that we keep the alternative table by annotating them with KEEP.
> > >
> >
> > Just cross referencing the report from Palmer against v2; I see orphan
> > section warnings from the linker related to the EFI stub when building
> > allmodconfig with this patch applied.
> >
> > v2: thread for reference.
> > https://lore.kernel.org/linux-riscv/CAKwvOdmsgMN5oQpDLh12D0X-CfQDtHC-EtxHcBnADkhnyitMKQ@mail.gmail.com/
>
> Sorry for replying to the v2, I'm marking that as superseeded in patchwork.
> IIUC it is a real issue on your end too? I'm also not 100% sure about the
> hang, I just let LLD cook for about 10 minutes before I noticed it was still
> running and posted.
Repeating myself for the sake of the archives or w/e, two different
submitters with differing version numbers. The v2 from Jisheng is more
recent than the v3 here from Zhangjin, they agreed in this mail thread
to merge their work.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] RISC-V: Enable dead code elimination
2023-06-20 20:17 ` Palmer Dabbelt
2023-06-20 20:22 ` Conor Dooley
@ 2023-06-20 20:26 ` Nick Desaulniers
2023-06-20 20:41 ` Palmer Dabbelt
1 sibling, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2023-06-20 20:26 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: falcon, Conor Dooley, guoren, linux-riscv, npiggin, Paul Walmsley,
paulburton, vincent.chen, tim.bird, llvm
On Tue, Jun 20, 2023 at 4:17 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> On Tue, 20 Jun 2023 13:13:06 PDT (-0700), ndesaulniers@google.com wrote:
> > On Wed, May 17, 2023 at 04:29:36PM +0800, Zhangjin Wu wrote:
> >> Select CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION for RISC-V, allowing
> >> the user to enable dead code elimination. In order for this to work,
> >> ensure that we keep the alternative table by annotating them with KEEP.
> >>
> >
> > Just cross referencing the report from Palmer against v2; I see orphan
> > section warnings from the linker related to the EFI stub when building
> > allmodconfig with this patch applied.
> >
> > v2: thread for reference.
> > https://lore.kernel.org/linux-riscv/CAKwvOdmsgMN5oQpDLh12D0X-CfQDtHC-EtxHcBnADkhnyitMKQ@mail.gmail.com/
>
> Sorry for replying to the v2, I'm marking that as superseeded in
> patchwork. IIUC it is a real issue on your end too? I'm also not 100%
> sure about the hang, I just let LLD cook for about 10 minutes before I
> noticed it was still running and posted.
Yes; if this is merged, our CI builds of ARCH=riscv allmodconfig will go red.
I assume a linker script somewhere needs to be updated, but I haven't
found if/where the efi stub's is.
drivers/firmware/efi/libstub/zboot.lds perhaps?
On Tue, Jun 20, 2023 at 4:22 PM Conor Dooley <conor@kernel.org> wrote:
>
> Repeating myself for the sake of the archives or w/e, two different
> submitters with differing version numbers. The v2 from Jisheng is more
> recent than the v3 here from Zhangjin, they agreed in this mail thread
> to merge their work.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] RISC-V: Enable dead code elimination
2023-06-20 20:26 ` Nick Desaulniers
@ 2023-06-20 20:41 ` Palmer Dabbelt
0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2023-06-20 20:41 UTC (permalink / raw)
To: ndesaulniers
Cc: falcon, Conor Dooley, guoren, linux-riscv, npiggin, Paul Walmsley,
paulburton, vincent.chen, tim.bird, llvm
On Tue, 20 Jun 2023 13:26:53 PDT (-0700), ndesaulniers@google.com wrote:
> On Tue, Jun 20, 2023 at 4:17 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> On Tue, 20 Jun 2023 13:13:06 PDT (-0700), ndesaulniers@google.com wrote:
>> > On Wed, May 17, 2023 at 04:29:36PM +0800, Zhangjin Wu wrote:
>> >> Select CONFIG_HAVE_LD_DEAD_CODE_DATA_ELIMINATION for RISC-V, allowing
>> >> the user to enable dead code elimination. In order for this to work,
>> >> ensure that we keep the alternative table by annotating them with KEEP.
>> >>
>> >
>> > Just cross referencing the report from Palmer against v2; I see orphan
>> > section warnings from the linker related to the EFI stub when building
>> > allmodconfig with this patch applied.
>> >
>> > v2: thread for reference.
>> > https://lore.kernel.org/linux-riscv/CAKwvOdmsgMN5oQpDLh12D0X-CfQDtHC-EtxHcBnADkhnyitMKQ@mail.gmail.com/
>>
>> Sorry for replying to the v2, I'm marking that as superseeded in
>> patchwork. IIUC it is a real issue on your end too? I'm also not 100%
>> sure about the hang, I just let LLD cook for about 10 minutes before I
>> noticed it was still running and posted.
>
> Yes; if this is merged, our CI builds of ARCH=riscv allmodconfig will go red.
>
> I assume a linker script somewhere needs to be updated, but I haven't
> found if/where the efi stub's is.
>
> drivers/firmware/efi/libstub/zboot.lds perhaps?
>
> On Tue, Jun 20, 2023 at 4:22 PM Conor Dooley <conor@kernel.org> wrote:
>>
>> Repeating myself for the sake of the archives or w/e, two different
>> submitters with differing version numbers. The v2 from Jisheng is more
>> recent than the v3 here from Zhangjin, they agreed in this mail thread
>> to merge their work.
Thanks, so we're going to jump over there.
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-20 20:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230517082936.37563-1-falcon@tinylab.org>
2023-06-20 20:13 ` [PATCH v3] RISC-V: Enable dead code elimination Nick Desaulniers
2023-06-20 20:17 ` Palmer Dabbelt
2023-06-20 20:22 ` Conor Dooley
2023-06-20 20:26 ` Nick Desaulniers
2023-06-20 20:41 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox