Re: stable-rc 5.15: clang-17: drivers/firmware/arm_scmi/smc.c:39:6: error: duplicate member 'irq'

[Cristian Marussi <cristian.marussi@arm.com>]

On Tue, Aug 08, 2023 at 11:59:22AM +0530, Naresh Kamboju wrote:
> LKFT build plans upgraded to clang-17 and found this failure,
> 
> While building stable-rc 5.15 arm with clang-17 failed with below
> warnings and errors.
> 
> Build log:
> ----------
> 
> drivers/firmware/arm_scmi/smc.c:39:6: error: duplicate member 'irq'
>    39 |         int irq;
>       |             ^
> drivers/firmware/arm_scmi/smc.c:34:6: note: previous declaration is here
>    34 |         int irq;
>       |             ^
> drivers/firmware/arm_scmi/smc.c:118:20: error: use of undeclared
> identifier 'irq'
>   118 |                 scmi_info->irq = irq;
>       |                                  ^
> 2 errors generated.
> 
>   Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Links:
>  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.124-80-g6a5dd0772845/testrun/18864721/suite/build/test/clang-lkftconfig/log
>  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.124-80-g6a5dd0772845/testrun/18864721/suite/build/test/clang-lkftconfig/details/
> 

Hi Naresh and Sasha,

so this fix (unluckily) applies cleanly to v5.15 but fails to build since the
logic and code around it was different in v5.15.

While looking at backporting it properly, though, I realized that the fix is
NOT needed really in v5.15 due to the different context and logic, so I ask you
to DROP this fix in v5.15.

I suppose the patch has been automatically applied because the Fixes referred
a commit that was on v5.15 too since some of those lines were indeed impacted
and were present also in later versions, but the logic around it has
changed afterwards, so the original code (up to v5.17) was not really affected
by the bug addressed by this fix...only later versions from v5.18 (included)
onwards needs it.

Moreover note that the whole SMC ISR logic was introduced in v5.12 (and was
good up to v5.17 as said) so v5.15 is really the only stable release that needs
to drop this fix.

Thanks and sorry for the noise,
Cristian

> 
> Steps to reproduce:
>  tuxmake --runtime podman --target-arch arm --toolchain clang-17
> --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2TeTE3iE8aq4t1kv169LcMmd9jo/config
> LLVM=1 LLVM_IAS=1
> 
>   Links:
>     - https://storage.tuxsuite.com/public/linaro/lkft/builds/2TeTE3iE8aq4t1kv169LcMmd9jo/tuxmake_reproducer.sh
> 
> --
> Linaro LKFT
> https://lkft.linaro.org