Re: stable-rc 5.15: clang-17: drivers/firmware/arm_scmi/smc.c:39:6: error: duplicate member 'irq'

[Cristian Marussi <cristian.marussi@arm.com>]

On Tue, Aug 08, 2023 at 04:44:32PM +0100, Sudeep Holla wrote:
> On Tue, Aug 08, 2023 at 08:30:30AM -0700, Nick Desaulniers wrote:
> > On Tue, Aug 8, 2023 at 3:49 AM Cristian Marussi
> > <cristian.marussi@arm.com> wrote:
> > >
> > > On Tue, Aug 08, 2023 at 11:59:22AM +0530, Naresh Kamboju wrote:
> > > > LKFT build plans upgraded to clang-17 and found this failure,
> > > >
> > > > While building stable-rc 5.15 arm with clang-17 failed with below
> > > > warnings and errors.
> > > >
> > > > Build log:
> > > > ----------
> > > >
> > > > drivers/firmware/arm_scmi/smc.c:39:6: error: duplicate member 'irq'
> > > >    39 |         int irq;
> > > >       |             ^
> > > > drivers/firmware/arm_scmi/smc.c:34:6: note: previous declaration is here
> > > >    34 |         int irq;
> > > >       |             ^
> > > > drivers/firmware/arm_scmi/smc.c:118:20: error: use of undeclared
> > > > identifier 'irq'
> > > >   118 |                 scmi_info->irq = irq;
> > > >       |                                  ^
> > > > 2 errors generated.
> > > >
> > > >   Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > Links:
> > > >  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.124-80-g6a5dd0772845/testrun/18864721/suite/build/test/clang-lkftconfig/log
> > > >  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.124-80-g6a5dd0772845/testrun/18864721/suite/build/test/clang-lkftconfig/details/
> > > >
> > >
> > > Hi Naresh and Sasha,
> > >
> > > so this fix (unluckily) applies cleanly to v5.15 but fails to build since the
> > > logic and code around it was different in v5.15.
> > >
> > > While looking at backporting it properly, though, I realized that the fix is
> > > NOT needed really in v5.15 due to the different context and logic, so I ask you
> > > to DROP this fix in v5.15.
> > 
> > What's the SHA of the patch that you are referring to (in
> > linux-5.15.y) that you're suggesting the stable maintainers revert?
> >
> 
> 8482711670fdfc8f89d437284a6ad159ee88615f
> Commit 8482711670fd ("firmware: arm_scmi: Fix chan_free cleanup on SMC")
> 
> For reference upstream commit 
> d1ff11d7ad87 ("firmware: arm_scmi: Fix chan_free cleanup on SMC")
> 
> Note this is only in
> git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> 
> And not in
> 
> git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git linux-5.15.y

Yes, this is a patch that was recently added to the stable queue for 5.15 and
it is still pending AFAIU (I suppose since it failed to build once applied).

There is another previous failed build report from yesterday:

https://lore.kernel.org/all/202308070912.4UYUVJVJ-lkp@intel.com/

Thanks,
Cristian