Re: [PATCH v3] genirq: Add kunit tests for depth counts

Re: [PATCH v3] genirq: Add kunit tests for depth counts

[kernel test robot]

Hi Brian,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on next-20250516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Norris/genirq-Add-kunit-tests-for-depth-counts/20250517-023519
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20250516183213.848182-1-briannorris%40chromium.org
patch subject: [PATCH v3] genirq: Add kunit tests for depth counts
config: arm64-randconfig-001-20250517 (https://download.01.org/0day-ci/archive/20250517/202505172307.yTjulMhx-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250517/202505172307.yTjulMhx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505172307.yTjulMhx-lkp@intel.com/

All errors (new ones prefixed by >>):

>> ld.lld: error: undefined symbol: kunit_binary_ptr_assert_format
   >>> referenced by irq_test.c:54 (kernel/irq/irq_test.c:54)
   >>>               kernel/irq/irq_test.o:(irq_disable_depth_test) in archive vmlinux.a
   >>> referenced by irq_test.c:54 (kernel/irq/irq_test.c:54)
   >>>               kernel/irq/irq_test.o:(irq_disable_depth_test) in archive vmlinux.a
   >>> referenced by irq_test.c:81 (kernel/irq/irq_test.c:81)
   >>>               kernel/irq/irq_test.o:(irq_free_disabled_test) in archive vmlinux.a
   >>> referenced 5 more times
--
>> ld.lld: error: undefined symbol: kunit_try_catch_throw
   >>> referenced by irq_test.c:0 (kernel/irq/irq_test.c:0)
   >>>               kernel/irq/irq_test.o:(irq_cpuhotplug_test) in archive vmlinux.a

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH v3] genirq: Add kunit tests for depth counts

[Brian Norris]

On Sun, May 18, 2025 at 12:13:47AM +0800, kernel test robot wrote:
> config: arm64-randconfig-001-20250517 (https://download.01.org/0day-ci/archive/20250517/202505172307.yTjulMhx-lkp@intel.com/config)

Ugh, that config manages to have this combination:

CONFIG_IRQ_KUNIT_TEST=y
CONFIG_KUNIT=m

I assumed that "IRQ_KUNIT_TEST depends on KUNIT" would rule out that
combination, but I see that's not true. I feel like I relearn Kconfig's
language every time I step outside the simplest of dependencies.

> >> ld.lld: error: undefined symbol: kunit_binary_ptr_assert_format
>    >>> referenced by irq_test.c:54 (kernel/irq/irq_test.c:54)
>    >>>               kernel/irq/irq_test.o:(irq_disable_depth_test) in archive vmlinux.a
>    >>> referenced by irq_test.c:54 (kernel/irq/irq_test.c:54)
>    >>>               kernel/irq/irq_test.o:(irq_disable_depth_test) in archive vmlinux.a
>    >>> referenced by irq_test.c:81 (kernel/irq/irq_test.c:81)
>    >>>               kernel/irq/irq_test.o:(irq_free_disabled_test) in archive vmlinux.a
>    >>> referenced 5 more times
> --
> >> ld.lld: error: undefined symbol: kunit_try_catch_throw
>    >>> referenced by irq_test.c:0 (kernel/irq/irq_test.c:0)
>    >>>               kernel/irq/irq_test.o:(irq_cpuhotplug_test) in archive vmlinux.a

I guess I'll need to squash this in:

--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -146,7 +146,7 @@ config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
 
 config IRQ_KUNIT_TEST
 	bool "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS
-	depends on KUNIT
+	depends on KUNIT=y
 	default KUNIT_ALL_TESTS
 	imply SMP
 	help

I'll sit on it and send v4 eventually.

Brian