* Re: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
[not found] <20251029031035.258766-3-ming.lei@redhat.com>
@ 2025-10-30 8:00 ` kernel test robot
2025-10-30 14:07 ` Caleb Sander Mateos
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2025-10-30 8:00 UTC (permalink / raw)
To: Ming Lei, Jens Axboe, linux-block
Cc: llvm, oe-kbuild-all, Uday Shankar, Caleb Sander Mateos, Ming Lei
Hi Ming,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on shuah-kselftest/next shuah-kselftest/fixes linus/master v6.18-rc3 next-20251029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ming-Lei/ublk-reorder-tag_set-initialization-before-queue-allocation/20251029-111323
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20251029031035.258766-3-ming.lei%40redhat.com
patch subject: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
config: x86_64-randconfig-074-20251030 (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510301522.i47z9R95-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/block/ublk_drv.c:240:49: error: 'counted_by' argument must be a simple declaration reference
240 | struct ublk_queue *queues[] __counted_by(dev_info.nr_hw_queues);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:346:62: note: expanded from macro '__counted_by'
346 | # define __counted_by(member) __attribute__((__counted_by__(member)))
| ^~~~~~
1 error generated.
vim +/counted_by +240 drivers/block/ublk_drv.c
208
209 struct ublk_device {
210 struct gendisk *ub_disk;
211
212 struct ublksrv_ctrl_dev_info dev_info;
213
214 struct blk_mq_tag_set tag_set;
215
216 struct cdev cdev;
217 struct device cdev_dev;
218
219 #define UB_STATE_OPEN 0
220 #define UB_STATE_USED 1
221 #define UB_STATE_DELETED 2
222 unsigned long state;
223 int ub_number;
224
225 struct mutex mutex;
226
227 spinlock_t lock;
228 struct mm_struct *mm;
229
230 struct ublk_params params;
231
232 struct completion completion;
233 u32 nr_io_ready;
234 bool unprivileged_daemons;
235 struct mutex cancel_mutex;
236 bool canceling;
237 pid_t ublksrv_tgid;
238 struct delayed_work exit_work;
239
> 240 struct ublk_queue *queues[] __counted_by(dev_info.nr_hw_queues);
241 };
242
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
2025-10-30 8:00 ` [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation kernel test robot
@ 2025-10-30 14:07 ` Caleb Sander Mateos
2025-10-30 17:56 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: Caleb Sander Mateos @ 2025-10-30 14:07 UTC (permalink / raw)
To: kernel test robot
Cc: Ming Lei, Jens Axboe, linux-block, llvm, oe-kbuild-all,
Uday Shankar
On Thu, Oct 30, 2025 at 1:01 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Ming,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on axboe-block/for-next]
> [also build test ERROR on shuah-kselftest/next shuah-kselftest/fixes linus/master v6.18-rc3 next-20251029]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Ming-Lei/ublk-reorder-tag_set-initialization-before-queue-allocation/20251029-111323
> base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
> patch link: https://lore.kernel.org/r/20251029031035.258766-3-ming.lei%40redhat.com
> patch subject: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
> config: x86_64-randconfig-074-20251030 (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202510301522.i47z9R95-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/block/ublk_drv.c:240:49: error: 'counted_by' argument must be a simple declaration reference
> 240 | struct ublk_queue *queues[] __counted_by(dev_info.nr_hw_queues);
> | ^~~~~~~~~~~~~~~~~~~~~
Hmm, guess it doesn't support nested fields?
> include/linux/compiler_types.h:346:62: note: expanded from macro '__counted_by'
> 346 | # define __counted_by(member) __attribute__((__counted_by__(member)))
> | ^~~~~~
> 1 error generated.
>
>
> vim +/counted_by +240 drivers/block/ublk_drv.c
>
> 208
> 209 struct ublk_device {
> 210 struct gendisk *ub_disk;
> 211
> 212 struct ublksrv_ctrl_dev_info dev_info;
> 213
> 214 struct blk_mq_tag_set tag_set;
> 215
> 216 struct cdev cdev;
> 217 struct device cdev_dev;
> 218
> 219 #define UB_STATE_OPEN 0
> 220 #define UB_STATE_USED 1
> 221 #define UB_STATE_DELETED 2
> 222 unsigned long state;
> 223 int ub_number;
> 224
> 225 struct mutex mutex;
> 226
> 227 spinlock_t lock;
> 228 struct mm_struct *mm;
> 229
> 230 struct ublk_params params;
> 231
> 232 struct completion completion;
> 233 u32 nr_io_ready;
> 234 bool unprivileged_daemons;
> 235 struct mutex cancel_mutex;
> 236 bool canceling;
> 237 pid_t ublksrv_tgid;
> 238 struct delayed_work exit_work;
> 239
> > 240 struct ublk_queue *queues[] __counted_by(dev_info.nr_hw_queues);
> 241 };
> 242
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
2025-10-30 14:07 ` Caleb Sander Mateos
@ 2025-10-30 17:56 ` Nathan Chancellor
2025-10-31 3:28 ` Ming Lei
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2025-10-30 17:56 UTC (permalink / raw)
To: Caleb Sander Mateos
Cc: kernel test robot, Ming Lei, Jens Axboe, linux-block, llvm,
oe-kbuild-all, Uday Shankar, Kees Cook
On Thu, Oct 30, 2025 at 07:07:25AM -0700, Caleb Sander Mateos wrote:
> On Thu, Oct 30, 2025 at 1:01 AM kernel test robot <lkp@intel.com> wrote:
...
> > patch link: https://lore.kernel.org/r/20251029031035.258766-3-ming.lei%40redhat.com
> > patch subject: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
> > config: x86_64-randconfig-074-20251030 (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/config)
> > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202510301522.i47z9R95-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/block/ublk_drv.c:240:49: error: 'counted_by' argument must be a simple declaration reference
> > 240 | struct ublk_queue *queues[] __counted_by(dev_info.nr_hw_queues);
> > | ^~~~~~~~~~~~~~~~~~~~~
>
> Hmm, guess it doesn't support nested fields?
Correct. I think this is something that we want to support at some point
if I remember correctly but I think there was a lot of discussion
between GCC and clang on how to actually do it but Kees is free to
correct me if that is wrong.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
2025-10-30 17:56 ` Nathan Chancellor
@ 2025-10-31 3:28 ` Ming Lei
0 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2025-10-31 3:28 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Caleb Sander Mateos, kernel test robot, Jens Axboe, linux-block,
llvm, oe-kbuild-all, Uday Shankar, Kees Cook
On Thu, Oct 30, 2025 at 10:56:31AM -0700, Nathan Chancellor wrote:
> On Thu, Oct 30, 2025 at 07:07:25AM -0700, Caleb Sander Mateos wrote:
> > On Thu, Oct 30, 2025 at 1:01 AM kernel test robot <lkp@intel.com> wrote:
> ...
> > > patch link: https://lore.kernel.org/r/20251029031035.258766-3-ming.lei%40redhat.com
> > > patch subject: [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation
> > > config: x86_64-randconfig-074-20251030 (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/config)
> > > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251030/202510301522.i47z9R95-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202510301522.i47z9R95-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/block/ublk_drv.c:240:49: error: 'counted_by' argument must be a simple declaration reference
> > > 240 | struct ublk_queue *queues[] __counted_by(dev_info.nr_hw_queues);
> > > | ^~~~~~~~~~~~~~~~~~~~~
> >
> > Hmm, guess it doesn't support nested fields?
>
> Correct. I think this is something that we want to support at some point
> if I remember correctly but I think there was a lot of discussion
> between GCC and clang on how to actually do it but Kees is free to
> correct me if that is wrong.
Thanks for the confirmation.
Will remove this __counted_by() in next version.
Thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-31 3:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251029031035.258766-3-ming.lei@redhat.com>
2025-10-30 8:00 ` [PATCH V3 2/5] ublk: implement NUMA-aware memory allocation kernel test robot
2025-10-30 14:07 ` Caleb Sander Mateos
2025-10-30 17:56 ` Nathan Chancellor
2025-10-31 3:28 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox