From: Frank Li <Frank.li@oss.nxp.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b"
<llvm@lists.linux.dev>
Subject: Re: [PATCH] dmaengine: bestcomm: ata: drop unused inc local
Date: Mon, 17 Aug 2026 08:58:42 -0500 [thread overview]
Message-ID: <aoMTkukPXAD03CD1@SMW015318> (raw)
In-Reply-To: <20260817015747.136689-1-rosenp@gmail.com>
On Sun, Aug 16, 2026 at 06:57:47PM -0700, Rosen Penev wrote:
> bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
> was never read, tripping clang -Wunused-but-set-variable:
>
> drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
> used [-Werror,-Wunused-but-set-variable]
> 58 | struct bcom_ata_inc *inc;
> | ^
>
> Drop the declaration and the bcom_task_inc() call that fed it.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/bestcomm/ata.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/ata.c b/drivers/dma/bestcomm/ata.c
> index 502a45d76adc..40126f3f189e 100644
> --- a/drivers/dma/bestcomm/ata.c
> +++ b/drivers/dma/bestcomm/ata.c
> @@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
> {
> struct bcom_task *tsk;
> struct bcom_ata_var *var;
> - struct bcom_ata_inc *inc;
>
> /* Prefetch breaks ATA DMA. Turn it off for ATA DMA */
> bcom_disable_prefetch();
> @@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
> bcom_ata_reset_bd(tsk);
>
> var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
> - inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
>
> if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
> bcom_task_free(tsk);
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-08-17 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 1:57 [PATCH] dmaengine: bestcomm: ata: drop unused inc local Rosen Penev
2026-08-17 13:58 ` Frank Li [this message]
2026-08-17 14:00 ` Frank Li
-- strict thread matches above, loose matches on Subject: below --
2026-05-24 2:43 Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoMTkukPXAD03CD1@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rosenp@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox