* [PATCH] dmaengine: bestcomm: ata: drop unused inc local
@ 2026-05-24 2:43 Rosen Penev
0 siblings, 0 replies; 4+ messages in thread
From: Rosen Penev @ 2026-05-24 2:43 UTC (permalink / raw)
To: dmaengine
Cc: Vinod Koul, linusw, Frank Li, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, open list,
open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b
bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
was never read, tripping clang -Wunused-but-set-variable:
drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
used [-Werror,-Wunused-but-set-variable]
58 | struct bcom_ata_inc *inc;
| ^
Drop the declaration and the bcom_task_inc() call that fed it.
Assisted-by: Claude:Opus-4.7
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/bestcomm/ata.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/bestcomm/ata.c b/drivers/dma/bestcomm/ata.c
index 502a45d76adc..40126f3f189e 100644
--- a/drivers/dma/bestcomm/ata.c
+++ b/drivers/dma/bestcomm/ata.c
@@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
{
struct bcom_task *tsk;
struct bcom_ata_var *var;
- struct bcom_ata_inc *inc;
/* Prefetch breaks ATA DMA. Turn it off for ATA DMA */
bcom_disable_prefetch();
@@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
bcom_ata_reset_bd(tsk);
var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
- inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
bcom_task_free(tsk);
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: bestcomm: ata: drop unused inc local
@ 2026-08-17 1:57 Rosen Penev
2026-08-17 13:58 ` Frank Li
2026-08-17 14:00 ` Frank Li
0 siblings, 2 replies; 4+ messages in thread
From: Rosen Penev @ 2026-08-17 1:57 UTC (permalink / raw)
To: dmaengine
Cc: Vinod Koul, Frank Li, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, open list,
open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b
bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
was never read, tripping clang -Wunused-but-set-variable:
drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
used [-Werror,-Wunused-but-set-variable]
58 | struct bcom_ata_inc *inc;
| ^
Drop the declaration and the bcom_task_inc() call that fed it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/bestcomm/ata.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/bestcomm/ata.c b/drivers/dma/bestcomm/ata.c
index 502a45d76adc..40126f3f189e 100644
--- a/drivers/dma/bestcomm/ata.c
+++ b/drivers/dma/bestcomm/ata.c
@@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
{
struct bcom_task *tsk;
struct bcom_ata_var *var;
- struct bcom_ata_inc *inc;
/* Prefetch breaks ATA DMA. Turn it off for ATA DMA */
bcom_disable_prefetch();
@@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
bcom_ata_reset_bd(tsk);
var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
- inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
bcom_task_free(tsk);
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: bestcomm: ata: drop unused inc local
2026-08-17 1:57 [PATCH] dmaengine: bestcomm: ata: drop unused inc local Rosen Penev
@ 2026-08-17 13:58 ` Frank Li
2026-08-17 14:00 ` Frank Li
1 sibling, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-08-17 13:58 UTC (permalink / raw)
To: Rosen Penev
Cc: dmaengine, Vinod Koul, Frank Li, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, open list,
open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b
On Sun, Aug 16, 2026 at 06:57:47PM -0700, Rosen Penev wrote:
> bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
> was never read, tripping clang -Wunused-but-set-variable:
>
> drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
> used [-Werror,-Wunused-but-set-variable]
> 58 | struct bcom_ata_inc *inc;
> | ^
>
> Drop the declaration and the bcom_task_inc() call that fed it.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/bestcomm/ata.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/ata.c b/drivers/dma/bestcomm/ata.c
> index 502a45d76adc..40126f3f189e 100644
> --- a/drivers/dma/bestcomm/ata.c
> +++ b/drivers/dma/bestcomm/ata.c
> @@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
> {
> struct bcom_task *tsk;
> struct bcom_ata_var *var;
> - struct bcom_ata_inc *inc;
>
> /* Prefetch breaks ATA DMA. Turn it off for ATA DMA */
> bcom_disable_prefetch();
> @@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
> bcom_ata_reset_bd(tsk);
>
> var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
> - inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
>
> if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
> bcom_task_free(tsk);
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: bestcomm: ata: drop unused inc local
2026-08-17 1:57 [PATCH] dmaengine: bestcomm: ata: drop unused inc local Rosen Penev
2026-08-17 13:58 ` Frank Li
@ 2026-08-17 14:00 ` Frank Li
1 sibling, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-08-17 14:00 UTC (permalink / raw)
To: Rosen Penev
Cc: dmaengine, Vinod Koul, Frank Li, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, open list,
open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b
Subject please use whole sentense.
dmaengine: bestcomm: ata: drop unused local variable 'inc'
Frank
On Sun, Aug 16, 2026 at 06:57:47PM -0700, Rosen Penev wrote:
> bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
> was never read, tripping clang -Wunused-but-set-variable:
>
> drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
> used [-Werror,-Wunused-but-set-variable]
> 58 | struct bcom_ata_inc *inc;
> | ^
>
> Drop the declaration and the bcom_task_inc() call that fed it.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/dma/bestcomm/ata.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/bestcomm/ata.c b/drivers/dma/bestcomm/ata.c
> index 502a45d76adc..40126f3f189e 100644
> --- a/drivers/dma/bestcomm/ata.c
> +++ b/drivers/dma/bestcomm/ata.c
> @@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
> {
> struct bcom_task *tsk;
> struct bcom_ata_var *var;
> - struct bcom_ata_inc *inc;
>
> /* Prefetch breaks ATA DMA. Turn it off for ATA DMA */
> bcom_disable_prefetch();
> @@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
> bcom_ata_reset_bd(tsk);
>
> var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
> - inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
>
> if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
> bcom_task_free(tsk);
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-17 14:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-17 1:57 [PATCH] dmaengine: bestcomm: ata: drop unused inc local Rosen Penev
2026-08-17 13:58 ` Frank Li
2026-08-17 14:00 ` Frank Li
-- strict thread matches above, loose matches on Subject: below --
2026-05-24 2:43 Rosen Penev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox