Re: [pdx86-platform-drivers-x86:review-ilpo-next 109/109] drivers/platform/x86/ideapad-laptop.c:2044:3: error: field designator 'charge_types' does not refer to any field in type 'const struct power_supply_ext'

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 22-May-25 4:39 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-ilpo-next
> head:   b2012b38080e2f92d43eca59e8249c174a27527c
> commit: b2012b38080e2f92d43eca59e8249c174a27527c [109/109] platform/x86: ideapad: Expose charge_types
> config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250522/202505221051.khDhUKJ0-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> rustc: rustc 1.78.0 (9b00956e5 2024-04-29)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505221051.khDhUKJ0-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505221051.khDhUKJ0-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/platform/x86/ideapad-laptop.c:2044:3: error: field designator 'charge_types' does not refer to any field in type 'const struct power_supply_ext'
>     2044 |         .charge_types           = (BIT(POWER_SUPPLY_CHARGE_TYPE_STANDARD) |
>          |         ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     2045 |                                    BIT(POWER_SUPPLY_CHARGE_TYPE_LONGLIFE)),
>          |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    1 error generated.
> 
> 
> vim +2044 drivers/platform/x86/ideapad-laptop.c

Hmm, this patch depends on:

https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next&id=c1f7375a246e5f810191a6c3031d2fa2b80e9f5e

I guess that that patch is not in review-ilpo-next,
maybe Sebastian can take this patch instead of taking
it through pdx86-next ?  Or it can be merged after
6.16-rc1 ?

Regards,

Hans






> 
>   2039	
>   2040	static const struct power_supply_ext ideapad_battery_ext = {
>   2041		.name			= "ideapad_laptop",
>   2042		.properties		= ideapad_power_supply_props,
>   2043		.num_properties		= ARRAY_SIZE(ideapad_power_supply_props),
>> 2044		.charge_types		= (BIT(POWER_SUPPLY_CHARGE_TYPE_STANDARD) |
>   2045					   BIT(POWER_SUPPLY_CHARGE_TYPE_LONGLIFE)),
>   2046		.get_property		= ideapad_psy_ext_get_prop,
>   2047		.set_property		= ideapad_psy_ext_set_prop,
>   2048		.property_is_writeable	= ideapad_psy_prop_is_writeable,
>   2049	};
>   2050	
>