From: Takashi Iwai <tiwai@suse.de>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: perex@perex.cz, tiwai@suse.com, nathan@kernel.org,
ndesaulniers@google.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] sound: ppc: beep: fix clang -Wimplicit-fallthrough
Date: Tue, 07 Dec 2021 15:37:20 +0100 [thread overview]
Message-ID: <s5htufkmqfz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20211207110053.695712-1-anders.roxell@linaro.org>
On Tue, 07 Dec 2021 12:00:53 +0100,
Anders Roxell wrote:
>
> Clang warns:
>
> sound/ppc/beep.c:103:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> case SND_TONE: break;
> ^
> sound/ppc/beep.c:103:2: note: insert 'break;' to avoid fall-through
> case SND_TONE: break;
> ^
> break;
> 1 warning generated.
>
> Clang is more pedantic than GCC, which does not warn when failing
> through to a case that is just break or return. Clang's version
> is more in line with the kernel's own stance in deprecated.rst.
> Add athe missing break to silence the warning.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Thanks, applied.
Takashi
prev parent reply other threads:[~2021-12-07 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 11:00 [PATCH] sound: ppc: beep: fix clang -Wimplicit-fallthrough Anders Roxell
2021-12-07 14:37 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htufkmqfz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox