From: Andrew Lunn <andrew@lunn.ch>
To: Yanteng Si <siyanteng@loongson.cn>
Cc: hkallweit1@gmail.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
fancer.lancer@gmail.com, Jose.Abreu@synopsys.com,
chenhuacai@loongson.cn, linux@armlinux.org.uk,
guyinggang@loongson.cn, netdev@vger.kernel.org,
loongarch@lists.linux.dev, chris.chenfeiyang@gmail.com
Subject: Re: [PATCH v6 1/9] net: stmmac: Pass stmmac_priv and chan in some callbacks
Date: Sat, 16 Dec 2023 14:01:17 +0100 [thread overview]
Message-ID: <759f33f0-e75a-406b-9318-272e50f2ec3b@lunn.ch> (raw)
In-Reply-To: <361389e731d14e3e2094f6ff5501597e9f762f34.1702458672.git.siyanteng@loongson.cn>
> -static void sun8i_dwmac_enable_dma_transmission(void __iomem *ioaddr)
> +static void sun8i_dwmac_enable_dma_transmission(void __iomem *ioaddr, u32 chan)
>
> - stmmac_enable_dma_transmission(priv, priv->ioaddr);
> + stmmac_enable_dma_transmission(priv, priv->ioaddr, queue);
As i've said a few times, i don't know this driver.
Is it a queue or is it a chan? Is this change consistent with the
reset of the code base?
Andrew
next prev parent reply other threads:[~2023-12-16 13:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 10:12 [PATCH v6 0/9] stmmac: Add Loongson platform support Yanteng Si
2023-12-13 10:12 ` [PATCH v6 1/9] net: stmmac: Pass stmmac_priv and chan in some callbacks Yanteng Si
2023-12-16 13:01 ` Andrew Lunn [this message]
2023-12-18 10:09 ` Yanteng Si
2023-12-13 10:12 ` [PATCH v6 2/9] net: stmmac: dwmac-loongson: Refactor code for loongson_dwmac_probe() Yanteng Si
2023-12-13 10:12 ` [PATCH v6 3/9] net: stmmac: dwmac-loongson: Add full PCI support Yanteng Si
2023-12-13 10:14 ` [PATCH v6 4/9] net: stmmac: Add multi-channel supports Yanteng Si
2023-12-13 10:14 ` [PATCH v6 5/9] net: stmmac: Add Loongson-specific register definitions Yanteng Si
2023-12-16 15:47 ` Andrew Lunn
2023-12-18 10:22 ` Yanteng Si
2023-12-18 15:28 ` Andrew Lunn
2023-12-19 12:30 ` Yanteng Si
2023-12-13 10:14 ` [PATCH v6 6/9] net: stmmac: dwmac-loongson: Add MSI support Yanteng Si
2023-12-13 10:15 ` [PATCH v6 7/9] net: stmmac: dwmac-loongson: Add GNET support Yanteng Si
2023-12-13 10:15 ` [PATCH v6 8/9] net: stmmac: dwmac-loongson: Disable flow control for GMAC Yanteng Si
2023-12-13 10:15 ` [PATCH v6 9/9] net: stmmac: Disable coe for some Loongson GNET Yanteng Si
2023-12-14 15:15 ` [PATCH v6 0/9] stmmac: Add Loongson platform support Serge Semin
2023-12-19 12:35 ` Yanteng Si
2023-12-19 12:55 ` Serge Semin
2023-12-14 19:09 ` Jakub Kicinski
2023-12-14 19:09 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759f33f0-e75a-406b-9318-272e50f2ec3b@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=guyinggang@loongson.cn \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox