* [PATCH RESEND v3 1/5] perf tools: Declare syscalltbl_*[] as const for all archs
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
@ 2023-05-30 10:09 ` Tiezhu Yang
2023-05-30 10:09 ` [PATCH RESEND v3 2/5] perf arm64: Rename create_table_from_c() to create_sc_table() Tiezhu Yang
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Tiezhu Yang @ 2023-05-30 10:09 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-perf-users, loongarch
syscalltbl_*[] should never be changing, let us declare it as const.
Suggested-by: Ian Rogers <irogers@google.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl | 2 +-
tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 2 +-
tools/perf/arch/powerpc/entry/syscalls/mksyscalltbl | 2 +-
tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 2 +-
tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 2 +-
tools/perf/util/syscalltbl.c | 14 +++++++-------
7 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 22cdf91..4edcdf6 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -34,7 +34,7 @@ create_table_from_c()
create_table()
{
echo "#include \"$input\""
- echo "static const char *syscalltbl_arm64[] = {"
+ echo "static const char *const syscalltbl_arm64[] = {"
create_table_from_c
echo "};"
}
diff --git a/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl b/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
index c52156f..5fb83bd 100755
--- a/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
@@ -50,7 +50,7 @@ create_table_from_c()
create_table()
{
- echo "static const char *syscalltbl_loongarch[] = {"
+ echo "static const char *const syscalltbl_loongarch[] = {"
create_table_from_c
echo "};"
}
diff --git a/tools/perf/arch/mips/entry/syscalls/mksyscalltbl b/tools/perf/arch/mips/entry/syscalls/mksyscalltbl
index fb1f494..c0d93f9 100644
--- a/tools/perf/arch/mips/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/mips/entry/syscalls/mksyscalltbl
@@ -18,7 +18,7 @@ create_table()
{
local max_nr nr abi sc discard
- echo 'static const char *syscalltbl_mips_n64[] = {'
+ echo 'static const char *const syscalltbl_mips_n64[] = {'
while read nr abi sc discard; do
printf '\t[%d] = "%s",\n' $nr $sc
max_nr=$nr
diff --git a/tools/perf/arch/powerpc/entry/syscalls/mksyscalltbl b/tools/perf/arch/powerpc/entry/syscalls/mksyscalltbl
index 6c58060..0eb316f 100755
--- a/tools/perf/arch/powerpc/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/powerpc/entry/syscalls/mksyscalltbl
@@ -23,7 +23,7 @@ create_table()
max_nr=-1
nr=0
- echo "static const char *syscalltbl_powerpc_${wordsize}[] = {"
+ echo "static const char *const syscalltbl_powerpc_${wordsize}[] = {"
while read nr abi sc discard; do
if [ "$max_nr" -lt "$nr" ]; then
printf '\t[%d] = "%s",\n' $nr $sc
diff --git a/tools/perf/arch/s390/entry/syscalls/mksyscalltbl b/tools/perf/arch/s390/entry/syscalls/mksyscalltbl
index 72ecbb6..52eb88a 100755
--- a/tools/perf/arch/s390/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/s390/entry/syscalls/mksyscalltbl
@@ -18,7 +18,7 @@ create_table()
{
local max_nr nr abi sc discard
- echo 'static const char *syscalltbl_s390_64[] = {'
+ echo 'static const char *const syscalltbl_s390_64[] = {'
while read nr abi sc discard; do
printf '\t[%d] = "%s",\n' $nr $sc
max_nr=$nr
diff --git a/tools/perf/arch/x86/entry/syscalls/syscalltbl.sh b/tools/perf/arch/x86/entry/syscalls/syscalltbl.sh
index 029a72c..fa526a9 100755
--- a/tools/perf/arch/x86/entry/syscalls/syscalltbl.sh
+++ b/tools/perf/arch/x86/entry/syscalls/syscalltbl.sh
@@ -18,7 +18,7 @@ emit() {
syscall_macro "$nr" "$entry"
}
-echo "static const char *syscalltbl_${arch}[] = {"
+echo "static const char *const syscalltbl_${arch}[] = {"
sorted_table=$(mktemp /tmp/syscalltbl.XXXXXX)
grep '^[0-9]' "$in" | sort -n > $sorted_table
diff --git a/tools/perf/util/syscalltbl.c b/tools/perf/util/syscalltbl.c
index 313ecce..63be7b5 100644
--- a/tools/perf/util/syscalltbl.c
+++ b/tools/perf/util/syscalltbl.c
@@ -17,31 +17,31 @@
#if defined(__x86_64__)
#include <asm/syscalls_64.c>
const int syscalltbl_native_max_id = SYSCALLTBL_x86_64_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_x86_64;
+static const char *const *syscalltbl_native = syscalltbl_x86_64;
#elif defined(__s390x__)
#include <asm/syscalls_64.c>
const int syscalltbl_native_max_id = SYSCALLTBL_S390_64_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_s390_64;
+static const char *const *syscalltbl_native = syscalltbl_s390_64;
#elif defined(__powerpc64__)
#include <asm/syscalls_64.c>
const int syscalltbl_native_max_id = SYSCALLTBL_POWERPC_64_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_powerpc_64;
+static const char *const *syscalltbl_native = syscalltbl_powerpc_64;
#elif defined(__powerpc__)
#include <asm/syscalls_32.c>
const int syscalltbl_native_max_id = SYSCALLTBL_POWERPC_32_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_powerpc_32;
+static const char *const *syscalltbl_native = syscalltbl_powerpc_32;
#elif defined(__aarch64__)
#include <asm/syscalls.c>
const int syscalltbl_native_max_id = SYSCALLTBL_ARM64_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_arm64;
+static const char *const *syscalltbl_native = syscalltbl_arm64;
#elif defined(__mips__)
#include <asm/syscalls_n64.c>
const int syscalltbl_native_max_id = SYSCALLTBL_MIPS_N64_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_mips_n64;
+static const char *const *syscalltbl_native = syscalltbl_mips_n64;
#elif defined(__loongarch__)
#include <asm/syscalls.c>
const int syscalltbl_native_max_id = SYSCALLTBL_LOONGARCH_MAX_ID;
-static const char **syscalltbl_native = syscalltbl_loongarch;
+static const char *const *syscalltbl_native = syscalltbl_loongarch;
#endif
struct syscall {
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH RESEND v3 2/5] perf arm64: Rename create_table_from_c() to create_sc_table()
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
2023-05-30 10:09 ` [PATCH RESEND v3 1/5] perf tools: Declare syscalltbl_*[] as const for all archs Tiezhu Yang
@ 2023-05-30 10:09 ` Tiezhu Yang
2023-05-30 10:09 ` [PATCH RESEND v3 3/5] perf arm64: Handle __NR3264_ prefixed syscall number Tiezhu Yang
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Tiezhu Yang @ 2023-05-30 10:09 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-perf-users, loongarch
After commit 9854e7ad35fe ("perf arm64: Simplify mksyscalltbl"),
it has been removed the temporary C program and used shell to
generate syscall table, so let us rename create_table_from_c()
to create_sc_table() to avoid confusion.
Suggested-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 4edcdf6..84976dc 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -19,7 +19,7 @@ if ! test -r $input; then
exit 1
fi
-create_table_from_c()
+create_sc_table()
{
local sc nr last_sc
@@ -35,7 +35,7 @@ create_table()
{
echo "#include \"$input\""
echo "static const char *const syscalltbl_arm64[] = {"
- create_table_from_c
+ create_sc_table
echo "};"
}
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH RESEND v3 3/5] perf arm64: Handle __NR3264_ prefixed syscall number
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
2023-05-30 10:09 ` [PATCH RESEND v3 1/5] perf tools: Declare syscalltbl_*[] as const for all archs Tiezhu Yang
2023-05-30 10:09 ` [PATCH RESEND v3 2/5] perf arm64: Rename create_table_from_c() to create_sc_table() Tiezhu Yang
@ 2023-05-30 10:09 ` Tiezhu Yang
2023-05-30 10:10 ` [PATCH RESEND v3 4/5] perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID Tiezhu Yang
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Tiezhu Yang @ 2023-05-30 10:09 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-perf-users, loongarch
After commit 9854e7ad35fe ("perf arm64: Simplify mksyscalltbl"),
in the generated syscall table file syscalls.c, there exist some
__NR3264_ prefixed syscall numbers such as [__NR3264_ftruncate],
it looks like not so good, just do some small filter operations
to handle __NR3264_ prefixed syscall number as a digital number.
Without this patch:
[__NR3264_ftruncate] = "ftruncate",
With this patch:
[46] = "ftruncate",
Suggested-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
---
tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 84976dc..0bcd64a 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -40,6 +40,7 @@ create_table()
}
$gcc -E -dM -x c -I $incpath/include/uapi $input \
- |sed -ne 's/^#define __NR_//p' \
- |sort -t' ' -k2 -n \
+ |awk '$2 ~ "__NR" && $3 !~ "__NR3264_" {
+ sub("^#define __NR(3264)?_", "");
+ print | "sort -k2 -n"}' \
|create_table
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH RESEND v3 4/5] perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
` (2 preceding siblings ...)
2023-05-30 10:09 ` [PATCH RESEND v3 3/5] perf arm64: Handle __NR3264_ prefixed syscall number Tiezhu Yang
@ 2023-05-30 10:10 ` Tiezhu Yang
2023-05-30 10:10 ` [PATCH RESEND v3 5/5] perf LoongArch: Simplify mksyscalltbl Tiezhu Yang
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Tiezhu Yang @ 2023-05-30 10:10 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-perf-users, loongarch
Like x86, powerpc, mips and s390, use max_nr which is a digital
number to define SYSCALLTBL_ARM64_MAX_ID.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 0bcd64a..27d747c 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -21,14 +21,14 @@ fi
create_sc_table()
{
- local sc nr last_sc
+ local sc nr max_nr
while read sc nr; do
printf "%s\n" " [$nr] = \"$sc\","
- last_sc=$sc
+ max_nr=$nr
done
- printf "%s\n" "#define SYSCALLTBL_ARM64_MAX_ID __NR_$last_sc"
+ echo "#define SYSCALLTBL_ARM64_MAX_ID $max_nr"
}
create_table()
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH RESEND v3 5/5] perf LoongArch: Simplify mksyscalltbl
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
` (3 preceding siblings ...)
2023-05-30 10:10 ` [PATCH RESEND v3 4/5] perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID Tiezhu Yang
@ 2023-05-30 10:10 ` Tiezhu Yang
2023-05-30 19:03 ` [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Ian Rogers
2023-05-31 7:58 ` Huacai Chen
6 siblings, 0 replies; 10+ messages in thread
From: Tiezhu Yang @ 2023-05-30 10:10 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-perf-users, loongarch
In order to print the numerical entries of the syscall table,
there is no need to call the host compiler to build and then
run a program, this can be done directly by the shell script.
This is similar with commit 9854e7ad35fe ("perf arm64: Simplify
mksyscalltbl"). For now, the mksyscalltbl file of LoongArch is
almost same with arm64.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
---
.../arch/loongarch/entry/syscalls/mksyscalltbl | 38 +++++++---------------
1 file changed, 11 insertions(+), 27 deletions(-)
diff --git a/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl b/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
index 5fb83bd..c10ad35 100755
--- a/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
@@ -18,44 +18,28 @@ if ! test -r $input; then
exit 1
fi
-create_table_from_c()
+create_sc_table()
{
- local sc nr last_sc
-
- create_table_exe=`mktemp ${TMPDIR:-/tmp}/create-table-XXXXXX`
-
- {
-
- cat <<-_EoHEADER
- #include <stdio.h>
- #include "$input"
- int main(int argc, char *argv[])
- {
- _EoHEADER
+ local sc nr max_nr
while read sc nr; do
- printf "%s\n" " printf(\"\\t[%d] = \\\"$sc\\\",\\n\", $nr);"
- last_sc=$nr
+ printf "%s\n" " [$nr] = \"$sc\","
+ max_nr=$nr
done
- printf "%s\n" " printf(\"#define SYSCALLTBL_LOONGARCH_MAX_ID %d\\n\", $last_sc);"
- printf "}\n"
-
- } | $hostcc -I $incpath/include/uapi -o $create_table_exe -x c -
-
- $create_table_exe
-
- rm -f $create_table_exe
+ echo "#define SYSCALLTBL_LOONGARCH_MAX_ID $max_nr"
}
create_table()
{
+ echo "#include \"$input\""
echo "static const char *const syscalltbl_loongarch[] = {"
- create_table_from_c
+ create_sc_table
echo "};"
}
-$gcc -E -dM -x c -I $incpath/include/uapi $input \
- |sed -ne 's/^#define __NR_//p' \
- |sort -t' ' -k2 -n \
+$gcc -E -dM -x c -I $incpath/include/uapi $input \
+ |awk '$2 ~ "__NR" && $3 !~ "__NR3264_" {
+ sub("^#define __NR(3264)?_", "");
+ print | "sort -k2 -n"}' \
|create_table
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
` (4 preceding siblings ...)
2023-05-30 10:10 ` [PATCH RESEND v3 5/5] perf LoongArch: Simplify mksyscalltbl Tiezhu Yang
@ 2023-05-30 19:03 ` Ian Rogers
2023-06-05 14:44 ` Arnaldo Carvalho de Melo
2023-05-31 7:58 ` Huacai Chen
6 siblings, 1 reply; 10+ messages in thread
From: Ian Rogers @ 2023-05-30 19:03 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
linux-perf-users, loongarch
On Tue, May 30, 2023 at 3:10 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> I'm sorry, somehow the patchset didn't reach mailing lists.
> Resending with a fewer people in the cc list, which probably
> was the reason.
>
> Thanks Alexander, Leo and Ian for your reviews and suggestions.
Thanks for the consts!
Acked-by: Ian Rogers <irogers@google.com>
> v3:
> -- Add a new patch to declare syscalltbl_*[] as const for all archs,
> suggested by Ian.
> -- Add a new patch to use max_nr to define SYSCALLTBL_ARM64_MAX_ID.
>
> v2:
> -- Add a new patch to rename create_table_from_c()
> to create_sc_table(), suggested by Leo.
> -- Simplify the shell script, suggested by Alexander.
>
> Tiezhu Yang (5):
> perf tools: Declare syscalltbl_*[] as const for all archs
> perf arm64: Rename create_table_from_c() to create_sc_table()
> perf arm64: Handle __NR3264_ prefixed syscall number
> perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID
> perf LoongArch: Simplify mksyscalltbl
>
> tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 17 ++++-----
> .../arch/loongarch/entry/syscalls/mksyscalltbl | 40 +++++++---------------
> tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 2 +-
> .../perf/arch/powerpc/entry/syscalls/mksyscalltbl | 2 +-
> tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 2 +-
> tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 2 +-
> tools/perf/util/syscalltbl.c | 14 ++++----
> 7 files changed, 32 insertions(+), 47 deletions(-)
>
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl
2023-05-30 19:03 ` [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Ian Rogers
@ 2023-06-05 14:44 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 10+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-06-05 14:44 UTC (permalink / raw)
To: Ian Rogers
Cc: Tiezhu Yang, Peter Zijlstra, Ingo Molnar, linux-perf-users,
loongarch
Em Tue, May 30, 2023 at 12:03:30PM -0700, Ian Rogers escreveu:
> On Tue, May 30, 2023 at 3:10 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> >
> > I'm sorry, somehow the patchset didn't reach mailing lists.
> > Resending with a fewer people in the cc list, which probably
> > was the reason.
> >
> > Thanks Alexander, Leo and Ian for your reviews and suggestions.
>
> Thanks for the consts!
>
> Acked-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
> > v3:
> > -- Add a new patch to declare syscalltbl_*[] as const for all archs,
> > suggested by Ian.
> > -- Add a new patch to use max_nr to define SYSCALLTBL_ARM64_MAX_ID.
> >
> > v2:
> > -- Add a new patch to rename create_table_from_c()
> > to create_sc_table(), suggested by Leo.
> > -- Simplify the shell script, suggested by Alexander.
> >
> > Tiezhu Yang (5):
> > perf tools: Declare syscalltbl_*[] as const for all archs
> > perf arm64: Rename create_table_from_c() to create_sc_table()
> > perf arm64: Handle __NR3264_ prefixed syscall number
> > perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID
> > perf LoongArch: Simplify mksyscalltbl
> >
> > tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 17 ++++-----
> > .../arch/loongarch/entry/syscalls/mksyscalltbl | 40 +++++++---------------
> > tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 2 +-
> > .../perf/arch/powerpc/entry/syscalls/mksyscalltbl | 2 +-
> > tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 2 +-
> > tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 2 +-
> > tools/perf/util/syscalltbl.c | 14 ++++----
> > 7 files changed, 32 insertions(+), 47 deletions(-)
> >
> > --
> > 2.1.0
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl
2023-05-30 10:09 [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Tiezhu Yang
` (5 preceding siblings ...)
2023-05-30 19:03 ` [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl Ian Rogers
@ 2023-05-31 7:58 ` Huacai Chen
2023-06-05 14:44 ` Arnaldo Carvalho de Melo
6 siblings, 1 reply; 10+ messages in thread
From: Huacai Chen @ 2023-05-31 7:58 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
linux-perf-users, loongarch
For the whole series,
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
On Tue, May 30, 2023 at 6:10 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> I'm sorry, somehow the patchset didn't reach mailing lists.
> Resending with a fewer people in the cc list, which probably
> was the reason.
>
> Thanks Alexander, Leo and Ian for your reviews and suggestions.
>
> v3:
> -- Add a new patch to declare syscalltbl_*[] as const for all archs,
> suggested by Ian.
> -- Add a new patch to use max_nr to define SYSCALLTBL_ARM64_MAX_ID.
>
> v2:
> -- Add a new patch to rename create_table_from_c()
> to create_sc_table(), suggested by Leo.
> -- Simplify the shell script, suggested by Alexander.
>
> Tiezhu Yang (5):
> perf tools: Declare syscalltbl_*[] as const for all archs
> perf arm64: Rename create_table_from_c() to create_sc_table()
> perf arm64: Handle __NR3264_ prefixed syscall number
> perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID
> perf LoongArch: Simplify mksyscalltbl
>
> tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 17 ++++-----
> .../arch/loongarch/entry/syscalls/mksyscalltbl | 40 +++++++---------------
> tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 2 +-
> .../perf/arch/powerpc/entry/syscalls/mksyscalltbl | 2 +-
> tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 2 +-
> tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 2 +-
> tools/perf/util/syscalltbl.c | 14 ++++----
> 7 files changed, 32 insertions(+), 47 deletions(-)
>
> --
> 2.1.0
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH RESEND v3 0/5] perf tools: Modify mksyscalltbl
2023-05-31 7:58 ` Huacai Chen
@ 2023-06-05 14:44 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 10+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-06-05 14:44 UTC (permalink / raw)
To: Huacai Chen
Cc: Tiezhu Yang, Peter Zijlstra, Ingo Molnar, linux-perf-users,
loongarch
Em Wed, May 31, 2023 at 03:58:41PM +0800, Huacai Chen escreveu:
> For the whole series,
> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Thanks, added to the patches.
- Arnaldo
> On Tue, May 30, 2023 at 6:10 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> >
> > I'm sorry, somehow the patchset didn't reach mailing lists.
> > Resending with a fewer people in the cc list, which probably
> > was the reason.
> >
> > Thanks Alexander, Leo and Ian for your reviews and suggestions.
> >
> > v3:
> > -- Add a new patch to declare syscalltbl_*[] as const for all archs,
> > suggested by Ian.
> > -- Add a new patch to use max_nr to define SYSCALLTBL_ARM64_MAX_ID.
> >
> > v2:
> > -- Add a new patch to rename create_table_from_c()
> > to create_sc_table(), suggested by Leo.
> > -- Simplify the shell script, suggested by Alexander.
> >
> > Tiezhu Yang (5):
> > perf tools: Declare syscalltbl_*[] as const for all archs
> > perf arm64: Rename create_table_from_c() to create_sc_table()
> > perf arm64: Handle __NR3264_ prefixed syscall number
> > perf arm64: Use max_nr to define SYSCALLTBL_ARM64_MAX_ID
> > perf LoongArch: Simplify mksyscalltbl
> >
> > tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 17 ++++-----
> > .../arch/loongarch/entry/syscalls/mksyscalltbl | 40 +++++++---------------
> > tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 2 +-
> > .../perf/arch/powerpc/entry/syscalls/mksyscalltbl | 2 +-
> > tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 2 +-
> > tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 2 +-
> > tools/perf/util/syscalltbl.c | 14 ++++----
> > 7 files changed, 32 insertions(+), 47 deletions(-)
> >
> > --
> > 2.1.0
> >
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 10+ messages in thread