Re: [LTP] [PATCH] Detect test results more accurately when generating HTML

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Wed, 2009-05-27 at 12:14 +0530, rohit verma wrote: 
> Hi Marc,
> 
> I think this a possible solution. I think the tag "initiation_status="
> can be moved after <<<execution_status>>>. Moving this tag to
> write_test_end() and shifting write_test_start() before fork() might
> solve the problem. However, corresponding changes have to be done in
> genhtml.pl

Yes, changes are required then in genhtml.pl also. So, go ahead and test
your solution.

Regards--
Subrata

> 
> Subrata: Just let me your view on this. I'll try and come up with a
> patch if the changes are acceptable.
> 
> Regards,
> Rohit.
> 
> 
> 
> On Wed, May 27, 2009 at 1:44 AM, Marc Gauthier <marc@tensilica.com> wrote:
> > Okay, so I looked at it a bit...
> >
> > Isn't the fundamental race condition because pan outputs
> > <<<test_start>>> *after* doing the fork(), rather than before?
> >
> > If some status info can't be output that early, maybe it just
> > needs to be output after <<<execution_status>>> as part of
> > write_test_end() ?
> >
> > -Marc
> >
> > P.S.  I find it useful to run genhtml against older LTP releases
> > (including those without genhtml), so might be useful to keep the
> > out-of-order workarounds even if ordering is fixed in this release.
> >
> >
> > Subrata Modak wrote:
> >> How much would you want to delay ? May be to some microsecs !!
> >> However delaying is not a good option, but, i am ready to consider.
> >> See, what is the reasanable time so that this problem vanishes.
> >>
> >> Meanwhile, i have generated this small patch. It tries to
> >> flush all data
> >> to be written to STDOUT before the Parent (PAN) tries to write his
> >> next tag. Moreover, i have included the fflush() to be executed inside
> >> the if()´s domain whenever the parent is writing from <<test_start>>
> >> till <<test_output>>. See, if this can help in solving the problem.
> >>
> >> Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
> >> ---
> >>
> >> --- ltp-intermediate-20090521/pan/ltp-pan.c.orig
> >> 2009-05-26 16:30:39.000000000 +0530
> >> +++ ltp-intermediate-20090521/pan/ltp-pan.c   2009-05-26
> >> 19:44:37.000000000 +0530
> >> @@ -1015,6 +1015,7 @@ static pid_t run_child(struct coll_entry
> >>               errbuf[errlen] = '\0';
> >>               /* fprintf(stderr, "%s", errbuf); */
> >>               waitpid(cpid, &status, 0);
> >> +             fflush(stdout); /* Flush any data before
> >> writing <<test_end>>*/
> >>               if (WIFSIGNALED(status)) {
> >>                       termid = WTERMSIG(status);
> >>                       termtype = "signaled";
> >> @@ -1300,14 +1301,14 @@ static void copy_buffered_output(struct
> >>
> >>  static void write_test_start(struct tag_pgrp *running, const
> >> char *init_status)
> >>  {
> >> -     if (!strcmp(reporttype, "rts"))
> >> +     if (!strcmp(reporttype, "rts")) {
> >>               printf("%s\ntag=%s
> >> stime=%ld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\niniti
> > ation_status=\"%s\"\n%s\n",
> >>                      "<<<test_start>>>",
> >>                      running->cmd->name, running->mystime,
> >> running->cmd->cmdline, "",
> >>                      "exit", init_status,
> >>                      "<<<test_output>>>");
> >> -
> >>       fflush(stdout);
> >> +     }
> >>  }
> >>
> >


------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list