[LTP] [PATCH] LTP May 2009 build fail fix for ssgetmask() syscall

[LTP] [PATCH] LTP May 2009 build fail fix for ssgetmask() syscall

[Subrata Modak]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3349 bytes --]

>On Thu, 2009-06-04 at 15:56 +0530, Munipradeep Beerakam wrote:
>Hi,
> 
> It failed on both x86 and x86_64 architectures
> 
> Regards
> Muni
> 
> On Thu, 2009-06-04 at 15:55 +0900, Nobuhiro Iwamatsu wrote:
> > Hi,
> > 
> > Munipradeep Beerakam wrote:
> >  > Hi,
> >  >
> >  > I tried to build the LTP tarball ltp-full-20090531.tgz on RHEL5.4
> >  > pre-Alpha Distribution. But build failed with the following error:
> >  >
> >  > ------------------------------------------------------------------
> >  >
> >  > make[4]: Entering directory
> >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> >  > gcc -g -O2 -I../../include -g -Wall -I../../../../include -Wall
> >  > sgetmask01.c  -L../../../../lib -lltp -o sgetmask01
> >  > sgetmask01.c: In function ���main���:
> >  > sgetmask01.c:142: error: ���__NR_ssetmask��� undeclared (first use in this
> >  > function)
> >  > sgetmask01.c:142: error: (Each undeclared identifier is reported only
> >  > once
> >  > sgetmask01.c:142: error: for each function it appears in.)
> >  > make[4]: *** [sgetmask01] Error 1
> >  > make[4]: Leaving directory
> >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> >  > make[3]: *** [all] Error 2
> >  > make[3]: Leaving directory
> >  > `/root/ltp-full-20090531/testcases/kernel/syscalls'
> >  > make[2]: *** [all] Error 2
> >  > make[2]: Leaving directory `/root/ltp-full-20090531/testcases/kernel'
> >  > make[1]: *** [all] Error 2
> >  > make[1]: Leaving directory `/root/ltp-full-20090531/testcases'
> >  > make: *** [all] Error 2
> 

Can you please try out this patch and see whether you are still
able to reproduce it in any of your architecture ?

Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---

--- ltp-full-20090531/testcases/kernel/syscalls/sgetmask/sgetmask01.c.orig	2009-06-04 16:41:22.000000000 +0530
+++ ltp-full-20090531/testcases/kernel/syscalls/sgetmask/sgetmask01.c	2009-06-04 16:51:36.000000000 +0530
@@ -49,7 +49,7 @@
 
 #include <stdio.h>
 #include <signal.h>
-#include <sys/syscall.h>
+#include <syscall.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <errno.h>
@@ -125,6 +125,7 @@ int main(int ac, char **av) {
 	int lc;                 /* loop counter */
         char *msg;              /* message returned from parse_opts */
 	
+#ifdef __NR_ssetmask
         /* parse standard options */
         if ((msg = parse_opts(ac, av, (option_t *)NULL, NULL)) != (char *)NULL){
              tst_brkm(TBROK, cleanup, "OPTION PARSING ERROR - %s", msg);
@@ -155,5 +156,9 @@ int main(int ac, char **av) {
         }	
 	cleanup();
         tst_exit();
+#else
+	tst_resm(TCONF,"__NR_ssetmask not defined for this Distro/Arch");
+	tst_exit();
+#endif
 }
 
---
Regards--
Subrata

>  >
> >  > ------------------------------------------------------------------
> >  >
> >  > The variable '__NR_ssetmask' declaration is available in /usr/include
> >  >
> >  > ~# grep -r "__NR_ssetmask" /usr/include/
> >  > /usr/include/bits/syscall.h:#define SYS_ssetmask __NR_ssetmask
> >  > /usr/include/asm-i386/unistd.h:#define __NR_ssetmask             69
> >  >
> >  > What could be the reason for failure?
> >  >
> > What kind of arch do you use?
> > x86_64? I became the same problem too.
> > x86_64 does not seem to have this systemcall.
> > 
> > Best regards,
> >   Nobuhiro
> > 
> 


[-- Attachment #2: Type: text/plain, Size: 408 bytes --]

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] LTP May 2009 build fail fix for ssgetmask() syscall

[Nicolas Joly]

On Thu, Jun 04, 2009 at 04:59:22PM +0530, Subrata Modak wrote:
> >On Thu, 2009-06-04 at 15:56 +0530, Munipradeep Beerakam wrote:
> >Hi,
> > 
> > It failed on both x86 and x86_64 architectures
> > 
> > Regards
> > Muni
> > 
> > On Thu, 2009-06-04 at 15:55 +0900, Nobuhiro Iwamatsu wrote:
> > > Hi,
> > > 
> > > Munipradeep Beerakam wrote:
> > >  > Hi,
> > >  >
> > >  > I tried to build the LTP tarball ltp-full-20090531.tgz on RHEL5.4
> > >  > pre-Alpha Distribution. But build failed with the following error:
> > >  >
> > >  > ------------------------------------------------------------------
> > >  >
> > >  > make[4]: Entering directory
> > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> > >  > gcc -g -O2 -I../../include -g -Wall -I../../../../include -Wall
> > >  > sgetmask01.c  -L../../../../lib -lltp -o sgetmask01
> > >  > sgetmask01.c: In function ‘main’:
> > >  > sgetmask01.c:142: error: ‘__NR_ssetmask’ undeclared (first use in this
> > >  > function)
> > >  > sgetmask01.c:142: error: (Each undeclared identifier is reported only
> > >  > once
> > >  > sgetmask01.c:142: error: for each function it appears in.)
> > >  > make[4]: *** [sgetmask01] Error 1
> > >  > make[4]: Leaving directory
> > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> > >  > make[3]: *** [all] Error 2
> > >  > make[3]: Leaving directory
> > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls'
> > >  > make[2]: *** [all] Error 2
> > >  > make[2]: Leaving directory `/root/ltp-full-20090531/testcases/kernel'
> > >  > make[1]: *** [all] Error 2
> > >  > make[1]: Leaving directory `/root/ltp-full-20090531/testcases'
> > >  > make: *** [all] Error 2
> > 
> 
> Can you please try out this patch and see whether you are still
> able to reproduce it in any of your architecture ?

Don't `syscall()' macro already take care ot this ? What about adding
the __NR_sgetmask/__NR_ssetmask to <arch>.in files instead ?

Just to test, i added the following lines to
testcases/kernel/include/i386.in :

__NR_sgetmask            68
__NR_ssetmask            69

and the problem on x86_64 is gone, without any further modification.

njoly@lanfeust [syscalls/sgetmask]> ./sgetmask01 
sgetmask01    1  CONF  :  syscall __NR_ssetmask not supported on your arch
sgetmask01    2  CONF  :  Remaining cases not appropriate for configuration

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] LTP May 2009 build fail fix for ssgetmask() syscall

[Munipradeep Beerakam]

Hi,

I applied this patch. Now, LTP is compiling successfully on both x86 and
x86_64 architectures.

Thanks
Muni

On Thu, 2009-06-04 at 16:59 +0530, Subrata Modak wrote:
> >On Thu, 2009-06-04 at 15:56 +0530, Munipradeep Beerakam wrote:
> >Hi,
> > 
> > It failed on both x86 and x86_64 architectures
> > 
> > Regards
> > Muni
> > 
> > On Thu, 2009-06-04 at 15:55 +0900, Nobuhiro Iwamatsu wrote:
> > > Hi,
> > > 
> > > Munipradeep Beerakam wrote:
> > >  > Hi,
> > >  >
> > >  > I tried to build the LTP tarball ltp-full-20090531.tgz on RHEL5.4
> > >  > pre-Alpha Distribution. But build failed with the following error:
> > >  >
> > >  > ------------------------------------------------------------------
> > >  >
> > >  > make[4]: Entering directory
> > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> > >  > gcc -g -O2 -I../../include -g -Wall -I../../../../include -Wall
> > >  > sgetmask01.c  -L../../../../lib -lltp -o sgetmask01
> > >  > sgetmask01.c: In function b\x18mainb\x19:
> > >  > sgetmask01.c:142: error: b\x18__NR_ssetmaskb\x19 undeclared (first use in this
> > >  > function)
> > >  > sgetmask01.c:142: error: (Each undeclared identifier is reported only
> > >  > once
> > >  > sgetmask01.c:142: error: for each function it appears in.)
> > >  > make[4]: *** [sgetmask01] Error 1
> > >  > make[4]: Leaving directory
> > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> > >  > make[3]: *** [all] Error 2
> > >  > make[3]: Leaving directory
> > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls'
> > >  > make[2]: *** [all] Error 2
> > >  > make[2]: Leaving directory `/root/ltp-full-20090531/testcases/kernel'
> > >  > make[1]: *** [all] Error 2
> > >  > make[1]: Leaving directory `/root/ltp-full-20090531/testcases'
> > >  > make: *** [all] Error 2
> > 
> 
> Can you please try out this patch and see whether you are still
> able to reproduce it in any of your architecture ?
> 
> Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
> ---
> 
> --- ltp-full-20090531/testcases/kernel/syscalls/sgetmask/sgetmask01.c.orig	2009-06-04 16:41:22.000000000 +0530
> +++ ltp-full-20090531/testcases/kernel/syscalls/sgetmask/sgetmask01.c	2009-06-04 16:51:36.000000000 +0530
> @@ -49,7 +49,7 @@
> 
>  #include <stdio.h>
>  #include <signal.h>
> -#include <sys/syscall.h>
> +#include <syscall.h>
>  #include <unistd.h>
>  #include <stdio.h>
>  #include <errno.h>
> @@ -125,6 +125,7 @@ int main(int ac, char **av) {
>  	int lc;                 /* loop counter */
>          char *msg;              /* message returned from parse_opts */
>  	
> +#ifdef __NR_ssetmask
>          /* parse standard options */
>          if ((msg = parse_opts(ac, av, (option_t *)NULL, NULL)) != (char *)NULL){
>               tst_brkm(TBROK, cleanup, "OPTION PARSING ERROR - %s", msg);
> @@ -155,5 +156,9 @@ int main(int ac, char **av) {
>          }	
>  	cleanup();
>          tst_exit();
> +#else
> +	tst_resm(TCONF,"__NR_ssetmask not defined for this Distro/Arch");
> +	tst_exit();
> +#endif
>  }
> 
> ---
> Regards--
> Subrata
> 
> >  >
> > >  > ------------------------------------------------------------------
> > >  >
> > >  > The variable '__NR_ssetmask' declaration is available in /usr/include
> > >  >
> > >  > ~# grep -r "__NR_ssetmask" /usr/include/
> > >  > /usr/include/bits/syscall.h:#define SYS_ssetmask __NR_ssetmask
> > >  > /usr/include/asm-i386/unistd.h:#define __NR_ssetmask             69
> > >  >
> > >  > What could be the reason for failure?
> > >  >
> > > What kind of arch do you use?
> > > x86_64? I became the same problem too.
> > > x86_64 does not seem to have this systemcall.
> > > 
> > > Best regards,
> > >   Nobuhiro
> > > 
> > 


------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] LTP May 2009 build fail fix for ssgetmask() syscall

[Subrata Modak]

On Thu, 2009-06-04 at 13:57 +0200, Nicolas Joly wrote: 
> On Thu, Jun 04, 2009 at 04:59:22PM +0530, Subrata Modak wrote:
> > >On Thu, 2009-06-04 at 15:56 +0530, Munipradeep Beerakam wrote:
> > >Hi,
> > > 
> > > It failed on both x86 and x86_64 architectures
> > > 
> > > Regards
> > > Muni
> > > 
> > > On Thu, 2009-06-04 at 15:55 +0900, Nobuhiro Iwamatsu wrote:
> > > > Hi,
> > > > 
> > > > Munipradeep Beerakam wrote:
> > > >  > Hi,
> > > >  >
> > > >  > I tried to build the LTP tarball ltp-full-20090531.tgz on RHEL5.4
> > > >  > pre-Alpha Distribution. But build failed with the following error:
> > > >  >
> > > >  > ------------------------------------------------------------------
> > > >  >
> > > >  > make[4]: Entering directory
> > > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> > > >  > gcc -g -O2 -I../../include -g -Wall -I../../../../include -Wall
> > > >  > sgetmask01.c  -L../../../../lib -lltp -o sgetmask01
> > > >  > sgetmask01.c: In function ‘main’:
> > > >  > sgetmask01.c:142: error: ‘__NR_ssetmask’ undeclared (first use in this
> > > >  > function)
> > > >  > sgetmask01.c:142: error: (Each undeclared identifier is reported only
> > > >  > once
> > > >  > sgetmask01.c:142: error: for each function it appears in.)
> > > >  > make[4]: *** [sgetmask01] Error 1
> > > >  > make[4]: Leaving directory
> > > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls/sgetmask'
> > > >  > make[3]: *** [all] Error 2
> > > >  > make[3]: Leaving directory
> > > >  > `/root/ltp-full-20090531/testcases/kernel/syscalls'
> > > >  > make[2]: *** [all] Error 2
> > > >  > make[2]: Leaving directory `/root/ltp-full-20090531/testcases/kernel'
> > > >  > make[1]: *** [all] Error 2
> > > >  > make[1]: Leaving directory `/root/ltp-full-20090531/testcases'
> > > >  > make: *** [all] Error 2
> > > 
> > 
> > Can you please try out this patch and see whether you are still
> > able to reproduce it in any of your architecture ?
> 
> Don't `syscall()' macro already take care ot this ? What about adding
> the __NR_sgetmask/__NR_ssetmask to <arch>.in files instead ?
> 
> Just to test, i added the following lines to
> testcases/kernel/include/i386.in :
> 
> __NR_sgetmask            68
> __NR_ssetmask            69
> 
> and the problem on x86_64 is gone, without any further modification.

Great. Much better solution. Thanks, and, made the changes.

Regards--
Subrata

> 
> njoly@lanfeust [syscalls/sgetmask]> ./sgetmask01 
> sgetmask01    1  CONF  :  syscall __NR_ssetmask not supported on your arch
> sgetmask01    2  CONF  :  Remaining cases not appropriate for configuration
> 


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list